IOS Platform view transform/clipping #9075

cyanglaz · 2019-05-24T01:42:22Z

WIP:

Introduce FlutterEmbededViewTransformStack to store all the transforms/clips layer before a platform view.

When we composite platform view, we traverse the stack and apply each transform/clip. If it is a transform we apply to the current view; if it is a clip, we create a super view and apply clip to the super view, then set the current view to this super view.

We also check whether the clip operation required for the current composition is the same as the old composition. If they are the same, we reuse the old UIView stacks; if not same, we add/remove views accordingly.

===============================

Another solution to this would be creating one UIView (say ClipView) for all the clips. So when we see a transform node, we apply the transform to the platform view directly. When we see a clip, we apply the totalMatrix until the clip to the clip and append to the current clip path. When we finish loop through all the nodes, we apply the total clip to the ClipView.

I am happy to try to implement this with the alternative solution to compare the performance.

@amirh

… clips dont match

flow/embedded_views.h

amirh

First pass, still need to review the ObjC++ code more thoroughly.

amirh · 2019-05-31T21:45:53Z

flow/embedded_views.h

@@ -42,8 +56,88 @@ class ExternalViewEmbedder {
  virtual ~ExternalViewEmbedder() = default;

  FML_DISALLOW_COPY_AND_ASSIGN(ExternalViewEmbedder);
+
+#pragma mark - transforms


I believe we don't do these in our C++ code

amirh · 2019-05-31T21:47:01Z

flow/embedded_views.h

+
+};  // ExternalViewEmbedder
+
+class FlutterEmbededViewTransformStack {


We can probably omit the "Flutter" prefix from these classes.

amirh · 2019-05-31T21:59:45Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

@@ -16,6 +16,134 @@
 #include "flutter/fml/platform/darwin/scoped_nsobject.h"
 #include "flutter/shell/platform/darwin/ios/framework/Headers/FlutterChannels.h"

+#pragma mark - Transforms Utils


nit: lets split these to a separate file, this one is getting too long

Should I just add these functions into the flutter namespace?

amirh · 2019-05-31T22:53:07Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+    case SkRRect::kNinePatch_Type:
+    case SkRRect::kComplex_Type: {
+      CGMutablePathRef mutablePathRef = CGPathCreateMutable();
+      // Complex types, we manually add each cornor.


s/cornor/corner/ (here and below)

amirh · 2019-06-03T18:22:04Z

flow/layers/clip_rect_layer.cc

@@ -50,13 +50,15 @@ void ClipRectLayer::Paint(PaintContext& context) const {
  SkAutoCanvasRestore save(context.internal_nodes_canvas, true);
  context.internal_nodes_canvas->clipRect(clip_rect_,
                                          clip_behavior_ != Clip::hardEdge);
+  context.view_embedder->transformStack->pushClipRect(clip_rect_);


view_embedder can be null, protect against it in all call sites.

amirh · 2019-06-03T18:25:32Z

flow/embedded_views.h

 class EmbeddedViewParams {
 public:
  SkPoint offsetPixels;
  SkSize sizePoints;
+  std::shared_ptr<FlutterEmbededViewTransformStack> transformStack;


why a shared pointer?

Both EmbededViewParams and ExternalViewEmbedder holds a reference to this object. I might be wrong but I thought I had to use shared for it?

amirh · 2019-06-03T18:33:21Z

flow/embedded_views.h

@@ -42,8 +56,88 @@ class ExternalViewEmbedder {
  virtual ~ExternalViewEmbedder() = default;

  FML_DISALLOW_COPY_AND_ASSIGN(ExternalViewEmbedder);
+
+#pragma mark - transforms
+  std::shared_ptr<FlutterEmbededViewTransformStack> transformStack;


This is the state of an ongoing paint traversal, I do not think it belongs in ExternalViewEmbedder(e.g think of an hypothetical world where we'll be painting multiple parts of the tree in parallel). I'd keep this in PaintContext.

Sure. Do you think all the stack related classes belong to the same file of paintContext?

amirh · 2019-06-03T18:40:22Z

flow/embedded_views.h

+
+};  // ExternalViewEmbedder
+
+class FlutterEmbededViewTransformStack {


Our language is a little ambiguous around "transforms", e.g usually we mean the transform matrix when we say transforms. I don't have a good idea though.

Update: I asked @chinmaygarde and he suggested to call it mutators, I think it's a much more reasonable name.

amirh · 2019-06-03T18:42:34Z

flow/embedded_views.h

+  // and destroys it.
+  void pop();
+
+  // Returns the iterator points to the bottom of the stack.


Just from reading this comment I'm not sure what's the "bottom of the stack" the mutator that should apply to all other mutators in the stack, or the one that all other mutators applies to? can you make this more clear in the comment ?(for both iterators)

Done. Updated to

// Returns the iterator points to the bottom of the stack. // When we composite an embedded view, this is the first mutator we should apply to the view. // And we should iterate through all the mutators until we reach `rend()` and apply all the mutations to the view along the way.

Let me know what you think.

Suggestion:

// A stack of mutators that can be applied to an embedded platform view. // // The stack may include mutators like transforms and clips, each mutator applies to all the mutators that are below it in the stack // and to the embedded view. // // For example consider the following stack: [T1, T2, T3], where T1 is the top of the stack and T3 is the bottom of the stack. // Applying this mutators stack to a platform view P1 will result in T1(T2(T2(P1))). class MutatorsStack { ... // Returns an iterator pointing to the top of the stack. std::vector<EmbeddedViewMutator>::reverse_iterator top(); // Returns an iterator pointing to the bottom of the stack. std::vector<EmbeddedViewMutator>::reverse_iterator bottom(); }

amirh · 2019-06-03T18:43:24Z

flow/embedded_views.h

+
+};  // ExternalViewEmbedder
+
+class FlutterEmbededViewTransformStack {


Add unit tests for this class.

…em to the flutter name space

amirh · 2019-06-04T17:06:18Z

flow/embedded_views.h

+  // and destroys it.
+  void pop();
+
+  // Returns the iterator points to the bottom of the stack.


Suggestion:

// A stack of mutators that can be applied to an embedded platform view. // // The stack may include mutators like transforms and clips, each mutator applies to all the mutators that are below it in the stack // and to the embedded view. // // For example consider the following stack: [T1, T2, T3], where T1 is the top of the stack and T3 is the bottom of the stack. // Applying this mutators stack to a platform view P1 will result in T1(T2(T2(P1))). class MutatorsStack { ... // Returns an iterator pointing to the top of the stack. std::vector<EmbeddedViewMutator>::reverse_iterator top(); // Returns an iterator pointing to the bottom of the stack. std::vector<EmbeddedViewMutator>::reverse_iterator bottom(); }

amirh · 2019-06-04T17:07:40Z

flow/embedded_views.cc

@@ -6,7 +6,46 @@

 namespace flutter {

+ExternalViewEmbedder::ExternalViewEmbedder()


amirh · 2019-06-04T17:08:13Z

flow/embedded_views.h

@@ -29,7 +38,7 @@ class EmbeddedViewParams {
 // FlutterPlatformViewsController which is owned by FlutterViewController.
 class ExternalViewEmbedder {
 public:
-  ExternalViewEmbedder() = default;
+  ExternalViewEmbedder();


amirh · 2019-06-04T17:08:29Z

flow/embedded_views.h

@@ -46,7 +55,86 @@ class ExternalViewEmbedder {
  virtual ~ExternalViewEmbedder() = default;

  FML_DISALLOW_COPY_AND_ASSIGN(ExternalViewEmbedder);
-};
+
+  std::shared_ptr<EmbeddedViewMutatorStack> transformStack;


keep this in PaintContext

amirh · 2019-06-04T17:11:34Z

flow/embedded_views.cc

+  EmbeddedViewMutator element = EmbeddedViewMutator();
+  element.setType(clip_rect);
+  element.setRect(rect);
+  vector_.push_back(element);


nit: we can save some copies by making it a vector of unique pointers

I tried it naively and caused some issue when trying to copy the stack to the params, reverting the change and adding a TODO and will work on it in future.

amirh · 2019-06-04T17:16:18Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

@@ -88,8 +113,10 @@ class FlutterPlatformViewsController {
  std::map<std::string, fml::scoped_nsobject<NSObject<FlutterPlatformViewFactory>>> factories_;
  std::map<int64_t, fml::scoped_nsobject<NSObject<FlutterPlatformView>>> views_;
  std::map<int64_t, fml::scoped_nsobject<FlutterTouchInterceptingView>> touch_interceptors_;
+  std::map<int64_t, fml::scoped_nsobject<UIView>> root_views_;


Can you add a comment explaining this and clip_count_?

amirh · 2019-06-04T17:41:06Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+
+  CGRect frame = CGRectMake(0, 0, params.sizePoints.width(), params.sizePoints.height());
+  touch_interceptor.frame = frame;
+  UIView* lastView = touch_interceptor;


It wasn't immediately clear to me what's lastView, the logic here is not completely trivial, maybe we can tell the story better by being a little more verbose on comment and names, maybe something like(pseudo code):

// Build a chain of UIViews that applies the mutations described by mutatorsStack. // // Clips are applied by adding a super view with the CALayer mask. Transforms are applied to the view that's at the // head of the chain. For example the following mutators stack [T_1, C_2, T_3, T_4, C_5, T_6] where T denotes a // transform and C denotes a clip, will result in the following UIView tree: // // C_2 -> C_5 -> PLATFORM_VIEW // (PLATFORM_VIEW is a subview of C_5 which is a subview of C_2) // // T_1 is applied to C_2, T_3 and T_4 are applied to C_5, and T_6 is applied to PLATFORM_VIEW. // // UIView instances used for clip mutations are re-used when possible. [ADD AN EXAMPLE HERE] // // Returns the UIView that's at the top of the generated chain(C_2 for the example above). UIView* FlutterPlatformViewsController::ApplyMutators(ViewMutatorsStack& mutators_stack, UIView* embedded_view) { UIView* head = embedded_view; // [instead of the current variable named lastView] ... }

amirh · 2019-06-04T17:42:34Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+
+  // If we have less cilp operations this time, remove unnecessary views.
+  // We skip this process if we have more clip operations this time.
+  int64_t extraClipsFromLastTime = clip_count_[view_id] - clipCount;


I'd keep this part in the proposed ApplyMutators

amirh · 2019-06-04T17:50:58Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+  // If we have less cilp operations this time, remove unnecessary views.
+  // We skip this process if we have more clip operations this time.
+  int64_t extraClipsFromLastTime = clip_count_[view_id] - clipCount;
+  if (extraClipsFromLastTime > 0 && lastView.superview) {


Maybe something like the following will look simpler:

if (!hasExtraClipViews) { return head; } [head removeFromSuperView]; [root_views_[view_id] removeFromSuperView]; [root_views_[view_id] release]; [root_views_[view_id] = [head retain]; // here add head to flutter_view_

amirh · 2019-06-04T17:51:39Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+      [superview release];
+      superview = superSuperView;
+    }
+    [flutter_view_.get() addSubview:lastView];


I think this might change the composition order in an unwanted way when we have multiple platform views, e.g [P_1, P_2] (in this order), and now the clip chain for P_1 changes, we remove the chain for P_1 and add it back to flutter_view_ which results in flipping the order([P_2, P]).

amirh · 2019-06-24T21:02:27Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

@@ -182,6 +183,117 @@
  return canvases;
 }

+int FlutterPlatformViewsController::GetNumberOfClips(const MutatorsStack& mutators_stack) {
+  // Apply transforms/clips.


stray comment?

amirh · 2019-06-24T21:05:07Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+UIView* FlutterPlatformViewsController::ReconstructClipViewsChain(int number_of_clips,
+                                                                  UIView* child,
+                                                                  UIView* parent) {
+  NSInteger index = -1;


nit: maybe call this indexInFlutterView?

amirh · 2019-06-24T21:05:37Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+  if (!needAddNewView && head != parent) {
+    [head removeFromSuperview];
+  }
+  if (index > -1) {


nit: add a comment saying a value of -1 means that the chain was not attached to the FlutterView

amirh · 2019-06-24T21:07:48Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+                                                                  UIView* parent) {
+  NSInteger index = -1;
+  if (parent.superview) {
+    // TODO(cyanglaz): protentially cache the index of oldPlatformViewRoot to make this a O(1).


File an issue so we don't lose track of this.

amirh · 2019-06-24T21:22:11Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+  return clipCount;
+}
+
+UIView* FlutterPlatformViewsController::ReconstructClipViewsChain(int number_of_clips,


I'm not sure what child and parent mean in this context... would it make sense to call it platform_view and head_clip_view?

amirh · 2019-06-24T21:30:37Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

+      case clip_rect:
+      case clip_rrect:
+      case clip_path: {
+        UIView* clipView = head.superview;


nit: maybe cast this to a ChildClippingView already here?
We can add a comment saying that this is called after ReconstructClipViewsChain which assures we have a ChildClippingView parent for each clip in the stack.

amirh · 2019-06-24T21:35:27Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

@@ -122,6 +152,33 @@ class FlutterPlatformViewsController {
  void EnsureGLOverlayInitialized(int64_t overlay_id,
                                  std::shared_ptr<IOSGLContext> gl_context,
                                  GrContext* gr_context);
+  // Traverse the `mutators_stack` and return the number of clip operations.
+  int GetNumberOfClips(const MutatorsStack& mutators_stack);


nit: CountClips

amirh · 2019-06-24T21:44:25Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

+  // numbers of UIViews between the `child` and the `parent` including the `parent`. Returns the new
+  // parent after reconsturcting. If the returning parent is not the same as child, it will be an
+  // instance of `ChildClippingView`.
+  UIView* ReconstructClipViewsChain(int number_of_clips, UIView* child, UIView* parent);


Suggestion:

// Make sure that platform_view has exactly clip_count ChildClippingView ancestors. // // Existing ChildClippingViews are re-used. If there are currently more ChildClippingView ancestors than needed // the extra views are detached. If there are less ChildClippingView ancestors than needed new ChildClippingViews will be added. // // If head_clip_view was attached as a subview to FlutterView, the head of the newly constructed ChildClippingViews chain is attached to FlutterView in the same position. // // Returns the new head of the clip views chain.

amirh · 2019-06-24T21:46:27Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

+  // instance of `ChildClippingView`.
+  UIView* ReconstructClipViewsChain(int number_of_clips, UIView* child, UIView* parent);
+
+  // Apply mutators in the mutators_stack to the UIView chain that was constructed by


nit: grammar - Applies the mutators

amirh · 2019-06-24T21:47:14Z

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

+  // After each clip operation, we update the head to the super view of the current head.
+  void ApplyMutators(const MutatorsStack& mutators_stack, UIView* embedded_view);
+
+  // Composite the platform view with the passed in `params`.


this comment doesn't add much information on top of the method and argument names.

amirh

LGTM

This reverts commit ebb5b90. Seeing the following breakage on host build: ``` ../../flutter/flow/scene_update_context.cc:205:36: error: non-const lvalue reference to type 'flutter::MutatorsStack' cannot bind to a value of unrelated type 'const flutter::Stopwatch' frame.context().raster_time(), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../flutter/flow/scene_update_context.cc:207:36: error: no viable conversion from 'flutter::TextureRegistry' to 'const flutter::Stopwatch' frame.context().texture_registry(), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../flutter/flow/instrumentation.h:55:32: note: candidate constructor not viable: no known conversion from 'flutter::TextureRegistry' to 'const flutter::Stopwatch &' for 1st argument FML_DISALLOW_COPY_AND_ASSIGN(Stopwatch); ^ ../../flutter/fml/macros.h:28:3: note: expanded from macro 'FML_DISALLOW_COPY_AND_ASSIGN' TypeName(const TypeName&) = delete; \ ^ ../../flutter/flow/scene_update_context.cc:208:36: error: non-const lvalue reference to type 'flutter::TextureRegistry' cannot bind to a temporary of type 'flutter::RasterCache *' &frame.context().raster_cache(), ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../flutter/flow/scene_update_context.cc:209:36: error: cannot initialize a member subobject of type 'const flutter::RasterCache *' with an rvalue of type 'bool' false}; ^~~~~ ```

…lutter#9480)" This reverts commit 00d929f.

flutter/engine@ae8e6d9...107fe82 git log ae8e6d9..107fe82 --no-merges --oneline 107fe82 Add --observatory-host switch (flutter/engine#9485) 20a76de Roll src/third_party/skia ebbc82c02471..69881fb0b5fb (11 commits) (flutter/engine#9479) 00d929f Revert "IOS Platform view transform/clipping (#9075)" (flutter/engine#9480) 3390019 fix NPE when a touch event is sent to an unknown Android platform view (flutter/engine#9476) ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075) 13145e9 ios-unit-tests: Started using rsync instead of cp -R to copy frameworks. (flutter/engine#9471) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.

…akage. (#9483) * Revert "Revert "IOS Platform view transform/clipping (#9075)" (#9480)" This reverts commit 00d929f. * fix fuschia buid

flutter/engine@ae8e6d9...107fe82 git log ae8e6d9..107fe82 --no-merges --oneline 107fe82 Add --observatory-host switch (flutter/engine#9485) 20a76de Roll src/third_party/skia ebbc82c02471..69881fb0b5fb (11 commits) (flutter/engine#9479) 00d929f Revert &flutter#34;IOS Platform view transform/clipping (flutter#9075)&flutter#34; (flutter/engine#9480) 3390019 fix NPE when a touch event is sent to an unknown Android platform view (flutter/engine#9476) ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075) 13145e9 ios-unit-tests: Started using rsync instead of cp -R to copy frameworks. (flutter/engine#9471) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.

Chris Yang added 7 commits May 16, 2019 16:33

get the stack ready

853cbd6

draft

72042cf

Do nothing if the params didn't change when compositing platform views.

8489c08

merge

647e66b

draft

f7d7aaa

draft

c0741b2

draft2

6e95d26

googlebot added the cla: yes label May 24, 2019

Chris Yang added 8 commits May 28, 2019 12:40

clip rrect

a3e1d61

typo fix

4cf9f8a

Merge branch 'master' into platform_view_transform

1daacb0

counting previous clips and only add and remove uiview when number of…

04d1f40

… clips dont match

draft

5b05eb2

draft

9b290cb

comments and formatting

52a8252

english

3a899fa

cyanglaz commented May 31, 2019

View reviewed changes

flow/embedded_views.h Outdated Show resolved Hide resolved

cyanglaz marked this pull request as ready for review May 31, 2019 17:18

cyanglaz requested a review from amirh May 31, 2019 17:18

remove friend from operator==

cabc67a

amirh reviewed Jun 3, 2019

View reviewed changes

Chris Yang added 4 commits June 3, 2019 13:33

merge master

4496b21

fix issue caused by merging

4bdae98

review fixes

33513b9

remove tranform\cilpping util method into a different file and add th…

e8926a5

…em to the flutter name space

amirh reviewed Jun 4, 2019

View reviewed changes

Chris Yang added 4 commits June 4, 2019 11:24

rename after review

3f4c586

move stack to paint context

d4f88f2

draft vector with unique_ptr

4eeb64f

more review fixes

6d78901

Chris Yang added 3 commits June 20, 2019 11:48

logs

455a495

move insert back uiview logic into recontruct method

cf36c46

rever unrelated changes

fd498ee

amirh reviewed Jun 24, 2019

View reviewed changes

Chris Yang added 2 commits June 24, 2019 15:26

review fixes

78acc1f

Merge branch 'master' into platform_view_transform

aeb56e0

amirh approved these changes Jun 24, 2019

View reviewed changes

cyanglaz merged commit ebb5b90 into flutter:master Jun 25, 2019

cyanglaz deleted the platform_view_transform branch June 25, 2019 16:45

engine-flutter-autoroll mentioned this pull request Jun 25, 2019

Roll engine ae8e6d9f4699..ebb5b909fbb1 (2 commits) flutter/flutter#35065

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2019

ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075)

5217c58

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2019

ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075)

c487aa2

engine-flutter-autoroll mentioned this pull request Jun 25, 2019

Roll engine ae8e6d9f4699..3390019225a2 (3 commits) flutter/flutter#35067

Closed

cyanglaz mentioned this pull request Jun 25, 2019

Platform view mutation #9481

Closed

cyanglaz pushed a commit to cyanglaz/engine that referenced this pull request Jun 25, 2019

Revert "Revert "IOS Platform view transform/clipping (flutter#9075)" (f…

7e00e0d

…lutter#9480)" This reverts commit 00d929f.

cyanglaz mentioned this pull request Jun 25, 2019

Reland "IOS Platform view transform/clipping (#9075)" and fix the breakage. #9483

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2019

ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075)

eca3862

This was referenced Jun 25, 2019

Roll engine ae8e6d9f4699..00d929f7f608 (4 commits) flutter/flutter#35073

Closed

Roll engine ae8e6d9f4699..20a76ded0f0b (5 commits) flutter/flutter#35076

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2019

ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075)

087ea2e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 25, 2019

ebb5b90 IOS Platform view transform/clipping (flutter/engine#9075)

bcc7a2a

engine-flutter-autoroll mentioned this pull request Jun 25, 2019

Roll engine ae8e6d9f4699..107fe823431a (6 commits) flutter/flutter#35085

Merged

cyanglaz pushed a commit that referenced this pull request Jun 25, 2019

Reland "IOS Platform view transform/clipping (#9075)" and fix the bre…

aa9b3a1

…akage. (#9483) * Revert "Revert "IOS Platform view transform/clipping (#9075)" (#9480)" This reverts commit 00d929f. * fix fuschia buid

cyanglaz mentioned this pull request Dec 5, 2019

iOS platform view cancels gesture while a new clip layer is added during the gesture. flutter/flutter#46167

Closed

dnfield mentioned this pull request Jul 16, 2020

remove obsolete check on FlutterPlatformViewsController::OnCreate #19819

Merged


		}; // ExternalViewEmbedder

		class FlutterEmbededViewTransformStack {

		@@ -6,7 +6,46 @@

		namespace flutter {

		ExternalViewEmbedder::ExternalViewEmbedder()

IOS Platform view transform/clipping #9075

IOS Platform view transform/clipping #9075

Conversation

cyanglaz commented May 24, 2019 • edited Loading

amirh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cyanglaz Jun 6, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amirh left a comment

Choose a reason for hiding this comment

cyanglaz commented May 24, 2019 •

edited

Loading

cyanglaz Jun 6, 2019 •

edited

Loading