This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Align fuchsia and non-fuchsia tracing #9199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
requested review from
chinmaygarde,
nathanrogersgoogle,
rmacnak-google and
zanderso
chinmaygarde
approved these changes
Jun 5, 2019
Contributor
Author
|
From offline conversation: it would be nice to rework these macros so they take variadic arguments and we can get rid of TRACE_FOO1/TRACE_FOO2. etc. |
Member
|
I don't think your editor is setup to format on save when doing a search and replace. In case you are using Sublime, Sublime Hooks with the Clang Format plugin works well for me. |
zanderso
approved these changes
Jun 5, 2019
runtime/dart_vm.cc
Outdated
| PushBackAll(&args, kDartTraceStreamsArgs, fml::size(kDartTraceStreamsArgs)); | ||
| #endif | ||
|
|
||
| // PushBackAll(&args, kDartTraceStreamsArgs, |
Member
There was a problem hiding this comment.
replace with a prose comment or TODO if needed.
Contributor
Author
|
I'm going to wait to land this until the related change in Dart is confirmed as good. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 5, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 6, 2019
flutter/engine@afb9d51...7826548 git log afb9d51..7826548 --no-merges --oneline 7826548 Align fuchsia and non-fuchsia tracing (flutter/engine#9199) 5ea125e Switch PlatformViewsController from Activity ref to Application ref. (flutter/engine#9193) fd4368c Skip golden tests on non-Linux OSes (flutter/engine#9198) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (bmparr@google.com), and stop the roller if necessary.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 6, 2019
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 12, 2019
zanderso
added a commit
to zanderso/engine
that referenced
this pull request
Jun 12, 2019
This reverts commit 7826548.
zanderso
added a commit
that referenced
this pull request
Jun 12, 2019
huqiuser
pushed a commit
to huqiuser/engine
that referenced
this pull request
Jun 13, 2019
* Revert "[fuchsia] Fix alignment of Fuchsia/non-Fuchsia tracing (flutter#9289)" This reverts commit f80ac5f. * Revert "Align fuchsia and non-fuchsia tracing (flutter#9199)" This reverts commit 7826548.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#33789
This will allow things like flutter driver to work, along with https://dart-review.googlesource.com/c/sdk/+/104948
Sorry for the size of the PR - the vast majority of the changes here are find and replaces for
TRACE_*toFML_TRACE_*.Key changes are in trace_event.h and dart_vm.cc.
trace_event.h:
FML_.dart_vm.cc:
The linked bug I'm removing a reference to (DNO-448) is marked as resolved in Jira.