This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "Load AOT compiled Dart assets only from ELF libraries" #9298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4d68474.
|
Do we have any way to experiment with different engine and framework builds in the device lab? So far we haven't been able to reproduce the benchmark regressions in other environments. I'd be curious to try doing another run of the benchmarks in the lab with flutter/flutter@e59d9a8 versus flutter/flutter@6d0e618 to confirm that the variation in benchmark results is consistently tied to the engine roll. |
|
Prefer fix forward instead. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9260
Although the exact cause has not been identified, it is most likely the regressions we have been seeing in various benchmarks originates in this change.
Since this seems to not want to repro locally, I propose we temporarily roll this back and see if it fixes it. There are only 3 commits in flutter/flutter@6d0e618 and this seems, out of 3 unlikely commits, to be the most likely one mostly because the other two commits are very small and mostly trivial.