This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Re-enable embedder_unittests. #9482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was disabled in flutter#6798 waiting for a Dart SDK patch to land dart-lang/sdk@e6d3a45 which has long since been addressed.
chinmaygarde
force-pushed
the
re_enable_test
branch
from
014db15 to
ad97939
Compare
|
In my investigation, I could not get to the root cause of the flaky a11y unit-test. I have disabled the one test and re-enabled all others. The issue filed for the same is linked here and in the test file. |
|
Landing on red as the framework was being manually rolled by @GaryQian when that presubmit fired. All engine test pass. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 28, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jun 28, 2019
flutter/engine@185087a...4aaa1a9 git log 185087a..4aaa1a9 --no-merges --oneline 4aaa1a9 Roll src/third_party/skia 842e92e29216..b851469b8e96 (6 commits) (flutter/engine#9568) 4e48fc4 Switched preprocessor logic for exporting symbols for testing. (NDEBUG (flutter/engine#9562) 50a8e73 Has a binary messenger (flutter/engine#9419) 7483665 Re-enable embedder_unittests. (flutter/engine#9482) 773cf53 Roll fuchsia/sdk/core/linux-amd64 from SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C to N9HpdqEHzWZIcSV_3JN4PNlUNeoK-Pism-mc-a7L-IoC (flutter/engine#9560) c2fa689 Roll src/third_party/skia d8f79a27b06b..842e92e29216 (108 commits) (flutter/engine#9558) 00c023b Roll fuchsia/sdk/core/mac-amd64 from dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC to 6WJ2NCb9uaOzVw20XC4kJqNcD4EP2VxT-PBocGsA6JsC (flutter/engine#9557) 7b9f59e Run benchmarks on try jobs. (flutter/engine#9493) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
johnsonmh
pushed a commit
to johnsonmh/flutter
that referenced
this pull request
Jul 30, 2019
flutter/engine@185087a...4aaa1a9 git log 185087a..4aaa1a9 --no-merges --oneline 4aaa1a9 Roll src/third_party/skia 842e92e29216..b851469b8e96 (6 commits) (flutter/engine#9568) 4e48fc4 Switched preprocessor logic for exporting symbols for testing. (NDEBUG (flutter/engine#9562) 50a8e73 Has a binary messenger (flutter/engine#9419) 7483665 Re-enable embedder_unittests. (flutter/engine#9482) 773cf53 Roll fuchsia/sdk/core/linux-amd64 from SuKWYMSXAMq1uTo9eaIdIOQqBb7Ro-zLyNk01GPOiU8C to N9HpdqEHzWZIcSV_3JN4PNlUNeoK-Pism-mc-a7L-IoC (flutter/engine#9560) c2fa689 Roll src/third_party/skia d8f79a27b06b..842e92e29216 (108 commits) (flutter/engine#9558) 00c023b Roll fuchsia/sdk/core/mac-amd64 from dcGnduqJ5C8ozmUHeeboHC76nOv7s4XfCKIfefQlGkQC to 6WJ2NCb9uaOzVw20XC4kJqNcD4EP2VxT-PBocGsA6JsC (flutter/engine#9557) 7b9f59e Run benchmarks on try jobs. (flutter/engine#9493) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (chinmaygarde@google.com), and stop the roller if necessary.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Oct 25, 2019
Removes a TODO implying that the embedder accessibility unittests were disabled due to flakiness. The tests were originally disabled in flutter#9482. The issue tracking re-enabling the tests was flutter/flutter#35218. This issue was resolved, and the tests re-enabled, in flutter#9585.
cbracken
added a commit
to cbracken/flutter_engine
that referenced
this pull request
Oct 25, 2019
Removes a TODO implying that the embedder accessibility unittests were disabled due to flakiness. The tests were originally disabled in flutter#9482. The issue tracking re-enabling the tests was flutter/flutter#35218. This issue was resolved, and the tests re-enabled, in flutter#9585.
cbracken
added a commit
that referenced
this pull request
Oct 25, 2019
Removes a TODO implying that the embedder accessibility unittests were disabled due to flakiness. The tests were originally disabled in #9482. The issue tracking re-enabling the tests was flutter/flutter#35218. This issue was resolved, and the tests re-enabled, in #9585.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was disabled in #6798 waiting for
a Dart SDK patch to land dart-lang/sdk@e6d3a45
which has long since been addressed.