Set shell as Rasterizer::Delegate in Fuchsia #9484
Conversation
|
Doesn't this need to be in the topaz repo at this point? Are we building out of flutter/engine yet? |
|
Good point. @nathanrogersgoogle : try to apply this change to topaz/runtime/flutter_runner/engine.cc if this patch doesn't solve your problem. |
|
@chinmaygarde : is this already replacing topaz/runtime/flutter_runner/engine.cc ? |
|
@liyuqian I locally patched this into "//topaz/runtime/flutter_runner/engine.cc" and can confirm that it fixes the issue discussed in #8970. Thanks! @chinmaygarde how should we land this patch in topaz and Flutter engine w.r.t. Flutter runner's current migration status? |
|
Ping @chinmaygarde on the Nathan's question above: how should we land this patch in topaz and Flutter engine w.r.t. Flutter runner's current migration status? |
|
AFAIK we still have to land these in Topaz. If that's not the case, I have other work that needs to be ported over. |
|
I think we should close this - this needs to be upstreamed to topaz. WDYT @liyuqian ? |
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Fuchsia doesn't get flutter_runner from here yet.
|
Sure, let's close this until the |
5 participants
No description provided.