Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intellij: "wrap with" does not work correctly on a parameter of format variable.property #2714

Closed
thefuzzyorange opened this issue Oct 20, 2018 · 2 comments
Closed

intellij: "wrap with" does not work correctly on a parameter of format variable.property #2714

thefuzzyorange opened this issue Oct 20, 2018 · 2 comments
Assignees
@scheglov
Labels
dependency: dart sdk topic-editing
Milestone
Backlog

Comments

@thefuzzyorange
Copy link

thefuzzyorange commented Oct 20, 2018 •
edited
Loading

When you have a parameter of the form variable.property and you invoke one of the wrap with methods only the portion where the caret is position gets wrapped.

Expected behaviour is that variable.property gets wrapped

Example 1: Caret on property

image

Results in

image

Example 2: Caret on variable

image

Results in

image

Expected results:

image

Version info

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, v0.10.1-pre.113, on Linux, locale en_GB.UTF-8)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.2)
[!] Android Studio (not installed)
[✓] IntelliJ IDEA Ultimate Edition (version 2018.2)
[✓] Connected device (1 available)
@pq
Copy link
Contributor

pq commented Oct 20, 2018

/cc @scheglov

@pq pq added this to the Backlog milestone Oct 20, 2018
@scheglov scheglov self-assigned this Oct 21, 2018
@scheglov
Copy link
Contributor

https://dart-review.googlesource.com/c/sdk/+/80985

dart-bot pushed a commit to dart-lang/sdk that referenced this issue Oct 21, 2018
@scheglov
Fix identifyWidgetExpression() for Flutter.
0265151 
Probably a bit pessimistic approach, allow only cases that we know
to be valid and useful.

R=brianwilkerson@google.com

Bug: flutter/flutter-intellij#2714
Change-Id: I8835c03d919c1f00a986ff3ef677c7f69995682f
Reviewed-on: https://dart-review.googlesource.com/c/80985
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
@scheglov scheglov mentioned this issue Dec 12, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scheglov scheglov

Labels
dependency: dart sdk topic-editing
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@pq @scheglov @thefuzzyorange