Skip to content

hot reload on save not work. #6996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YcDevs opened this issue Oct 26, 2023 · 26 comments
Closed

hot reload on save not work. #6996

YcDevs opened this issue Oct 26, 2023 · 26 comments

Comments

@YcDevs
Copy link

YcDevs commented Oct 26, 2023

Thanks for the feedback! If your issue is related to the Flutter framework itself,
please open an issue at
github.com/flutter/flutter.

Steps to Reproduce

When I update the plugin to the latest (version 72.1.2), command+s hot reload no work.
There is no reaction after preservation.
When I go back to the version(version 72.0.2), It worked.
The hot reload configuration item is enabled.
I thought it was a plugin update that caused the configuration to be lost,but obviously not.
I don't know what happened.

Version info

image

@lopo12123

This comment was marked as duplicate.

@whoevelmanns

This comment was marked as duplicate.

@Haval-dev

This comment was marked as duplicate.

@brandon3343
Copy link

brandon3343 commented Oct 27, 2023

I upgraded the plugin to the latest version(76.1.4) today and found that there was a problem, downgrade to version 76.0.4 and it's working.

IntelliJ IDEA version info

IntelliJ IDEA 2023.2.4 (Ultimate Edition)
Build #IU-232.10203.10, built on October 25, 2023

@nytoan

This comment was marked as duplicate.

@Lzyct

This comment was marked as duplicate.

@lukas-pierce

This comment was marked as duplicate.

@JaehyunYoo

This comment was marked as duplicate.

@zhoujia456888

This comment was marked as duplicate.

@IntCleastwood

This comment was marked as duplicate.

@HarryToo
Copy link

HarryToo commented Nov 1, 2023

I tried updating to 76.2 today, but it seems the issue still exists.

@poorankharol

This comment was marked as duplicate.

@i198622

This comment was marked as duplicate.

@SELiOTe

This comment was marked as duplicate.

@jorgevvr

This comment was marked as duplicate.

@jorgevvr

This comment was marked as duplicate.

@ByteSizedMarius
Copy link

dozens of people commenting "same" just makes it so no one can subscribe to this issue to get notified once it's fixed because of spam and literally helps no one. Everyone is aware this is an issue, just liking the original issue is more than enough. For now, just downgrade manually and do not update.

@SELiOTe
Copy link

SELiOTe commented Nov 4, 2023

Plugin bugs, but you can change one more dart file, and hot reload will working

@Sahilbhayani
Copy link

For now downgrad flutter plugin manually..

Downloading the 76.0.x or earlier zip file from this link
https://plugins.jetbrains.com/plugin/9212-flutter/versions/stable

And install the plugin manually from file, which will make the hot reload works again

Screenshot from 2023-11-06 18-34-10
Screenshot from 2023-11-06 18-34-10

jwren added a commit to jwren/flutter-intellij that referenced this issue Nov 7, 2023
…forward change for the IDEA platform as it introduces an issue for some users to prevent hot reload from working. (flutter#6996)
jwren added a commit that referenced this issue Nov 7, 2023
Prepare for point release 76.3.*. This reverts the AnActionEvent API
forward change for the IDEA platform
(a44fe2c)
as it introduces an issue for some users to prevent hot reload from
working. (#6996)
@jwren
Copy link
Member

jwren commented Nov 8, 2023

Hi all, I believe that this issue is fixed with the point release of 76.3.x that I just pushed out. Please let me know otherwise.

Thank you for the various reports and comments above.

@jwren
Copy link
Member

jwren commented Nov 8, 2023

(not yet showing up on the server, give it a few minutes)

@brandon3343
Copy link

It has been fixed on my computer.

flutter plugin: 76.3.4
IntelliJ IDEA 2023.2.4 (Ultimate Edition)
Build #IU-232.10203.10, built on October 25, 2023

@jorgevvr
Copy link

jorgevvr commented Nov 8, 2023

Fixed for me too.
flutter plugin: 76.3.4

Thank you.

@jwren
Copy link
Member

jwren commented Nov 8, 2023

Thank you for confirming. Closing this issue out. If there is still a regression for some platform version, open a new issue and tag me to escalate.

@Gaweringo
Copy link

Gaweringo commented Feb 19, 2024

I am having the same issue, that it's not hot reloading on save (format on save works), on Android Studio Hedgehog | 2023.1.1 Patch 2 with the Flutter plugin 78.0.1 and Flutter version:

Flutter 3.19.0 • channel stable • https://github.com/flutter/flutter.git
Framework • revision bae5e49bc2 (6 days ago) • 2024-02-13 17:46:18 -0800
Engine • revision 04817c99c9
Tools • Dart 3.3.0 • DevTools 2.31.1
Doctor summary (to see all details, run flutter doctor -v):
[!] Flutter (Channel stable, 3.19.0, on Microsoft Windows [Version 10.0.19045.4046], locale en-AT)
    ! Warning: `flutter` on your path resolves to C:\Users\gawer\scoop\apps\flutter\3.19.0\bin\flutter, which is not
      inside your current Flutter SDK checkout at C:\Users\gawer\scoop\apps\flutter\current. Consider adding
      C:\Users\gawer\scoop\apps\flutter\current\bin to the front of your path.
    ! Warning: `dart` on your path resolves to C:\Users\gawer\scoop\apps\flutter\3.19.0\bin\dart, which is not inside
      your current Flutter SDK checkout at C:\Users\gawer\scoop\apps\flutter\current. Consider adding
      C:\Users\gawer\scoop\apps\flutter\current\bin to the front of your path.
[✓] Windows Version (Installed version of Windows is version 10 or higher)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Chrome - develop for the web
[✓] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.0)
[✓] Android Studio (version 2023.1)
[✓] IntelliJ IDEA Community Edition (version 2023.3)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.3)
[✓] VS Code (version 1.86.2)
[✓] Connected device (3 available)
[✓] Network resources

! Doctor found issues in 1 category

It works in VS Code with the same project.
Is it ok, that I put this here as a reply or should I move it out to its own issue?

@theRookieCoder
Copy link

theRookieCoder commented Mar 6, 2024

I still have this issue on the latest plugin version 78.1.1, in fact I'm not even able to use the Ctrl+\ shortcut to trigger hot reload, only the button in the run console works. Somehow Shift+Ctrl+\ works for hot restarting.

Flutter 3.19.2 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 7482962148 (8 days ago) • 2024-02-27 16:51:22 -0500
Engine • revision 04817c99c9
Tools • Dart 3.3.0 • DevTools 2.31.1
[✓] Flutter (Channel stable, 3.19.2, on Fedora Linux 39 (KDE Plasma) 6.7.6-200.fc39.x86_64)
    • Flutter version 3.19.2 on channel stable at /home/<user>/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 7482962148 (8 days ago), 2024-02-27 16:51:22 -0500
    • Engine revision 04817c99c9
    • Dart version 3.3.0
    • DevTools version 2.31.1

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /home/<user>/Android/Sdk
    • Platform android-34, build-tools 34.0.0
    • ANDROID_SDK_ROOT = /home/<user>/Android/Sdk
    • Java binary at: /home/<user>/.local/share/JetBrains/Toolbox/apps/android-studio-2/jbr/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.17-11446219)
    • All Android licenses accepted.

[✗] Chrome - develop for the web (Cannot find Chrome executable at google-chrome)
    ! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.

[✓] Linux toolchain - develop for Linux desktop
    • clang version 17.0.6 (Fedora 17.0.6-2.fc39)
    • cmake version 3.27.7
    • ninja version 1.11.1
    • pkg-config version 1.9.5

[✓] Android Studio (version 2023.3)
    • Android Studio at /home/<user>/.local/share/JetBrains/Toolbox/apps/android-studio-2
    • Flutter plugin version 78.1.1
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.17-11446219)

[✓] IntelliJ IDEA Ultimate Edition (version 2023.3)
    • IntelliJ at /home/<user>/.local/share/JetBrains/Toolbox/apps/intellij-idea-ultimate
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart

[✓] VS Code (version 1.87.0)
    • VS Code at /usr/share/code
    • Flutter extension version 3.85.20240301

[✓] Network resources
    • All expected network resources are available.

pq added a commit that referenced this issue Apr 17, 2025
Migrate to safe `AnActionListener` APIs.

This migration has been attempted before but was reverted as possibly
causing a hot reload regression
(#6996).

I've confirmed that hot reload works (Mac OS Meerkat) but have preserved
the note in case anything odd happens.

See: #7718

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests