Restore Project Structure editor #1983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
I don't think I have enough context here why we're adding the menu item back into Android Studio - let's plan to discuss ~tomorrow am. |
devoncarew
reviewed
Mar 26, 2018
| @@ -30,5 +31,6 @@ public void runActivity(@NotNull Project project) { | |||
| // The IntelliJ version of this action spawns a new process for Android Studio. | |||
| // Since we're already running Android Studio we want to simply open the project in the current process. | |||
| replaceAction("flutter.androidstudio.open", new OpenAndroidModule()); | |||
| replaceAction("ShowProjectStructureSettings", new FlutterShowStructureSettingsAction()); | |||
There was a problem hiding this comment.
Can we only do this replace if the given project is a Flutter project? We have some utils for detecting this, that look inside the pubspec.yaml file.
devoncarew
approved these changes
Mar 26, 2018
|
I also think we should investigate ways we can get the new, JAVA_MODULE based flutter project type to be closer to something that Android Studio is happy with. |
|
I have implemented the guard clause and will add it with the next PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the Project Structure menu item to show up in Android Studio. Tested by building a 3.0 plugin and installing it into AS 3.0.1, and by running debuggable AS from sources.
It still uses the one that comes with IntelliJ, so needs some work, but at least it can be used to add (non-Dart) dependencies to Flutter modules. There is some code that is commented-out that will be useful in fixing up support for the new one (I hope).
@devoncarew @pq