Remove a modification for the idea 2023.2 version of the platform #7715
Conversation
| pluginList.add("org.jetbrains.android") | ||
| } else if (ide == "ideaIC") { | ||
| pluginList.add("org.jetbrains.android:$androidVersion") | ||
| } | ||
|
|
||
| if (ideVersion != "2023.2") { | ||
| pluginList.add(smaliPlugin) |
There was a problem hiding this comment.
So is this plugin not needed anymore when running in Android Studio?
There was a problem hiding this comment.
+1 - did we need to just remove the if condition or the whole block?
There was a problem hiding this comment.
This logic was used when building the Flutter plugin for the 2023.2 IDEA version of the product, at this point however we won't be pushing out a version of the Flutter plugin for 2023.2: https://github.com/flutter/flutter-intellij/blob/07610c1301ce8792975d10274266abc97e4b2699/product-matrix.json
There was a problem hiding this comment.
This logic looks like we wanted the smaliPlugin for all versions that were not 2023.2, including newer versions. So does that mean we should be changing this from
if (ideVersion != "2023.2") {
pluginList.add(smaliPlugin);
}
to
pluginList.add(smaliPlugin);
|
Closing as all the |
No description provided.