Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable notification when SDK will soon be unsupported soon #7763

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

jwren
Copy link
Member

@jwren jwren commented Nov 4, 2024

Flutter SDK version 3.10.0, Dart SDK version 3.0.0

This work is in prep for a point release soon (1-2 days).

This work is in sync with DartCode, see https://dartcode.org/releases/#v31000-2024-10-31.

Flutter SDK version 3.10.0, Dart SDK version 3.0.0
@jwren jwren requested a review from kenzieschmoll November 4, 2024 19:19
Comment on lines 381 to 389
//notification.addAction(new AnAction("More Info") {
// @Override
// public void actionPerformed(@NotNull AnActionEvent event) {
// // TODO(helin24): Update with informational URL.
// BrowserLauncher.getInstance().browse("https://www.google.com", null);
// settings.setSdkVersionOutdatedWarningAcknowledged(version.getVersionText(), true);
// notification.expire();
// }
//});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is commenting this out intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, what is unintentional is that a comment is missing, adding it now.

@jwren jwren merged commit 451654b into flutter:master Nov 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants