Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out the usage of the Flutter Outline view #7779

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

jwren
Copy link
Member

@jwren jwren commented Nov 11, 2024

This resolves #7778

@jwren jwren force-pushed the rm_flutter_outline branch from f9c05f1 to 35afa69 Compare November 11, 2024 20:25
@jwren
Copy link
Member Author

jwren commented Nov 11, 2024

Note: Don't commit this until all 82.x point releases are done

Comment on lines 330 to 331
<!-- <toolWindow id="Flutter Outline" anchor="right" icon="FlutterIcons.FlutterDefault"-->
<!-- factoryClass="io.flutter.preview.PreviewViewFactory"/>-->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how much work is it to commend out the tool window content instead so that a message can be displayed instructing users to open the Structure view?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be removing the current JComponent which holds the outline and buttons with a message and link to go use the provided Structure view.

We decided to remove the outline, this PR, but I didn't know if we decided on having a few simply point devs to a different window was a net-positive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it would be less jarring for users to have an explanation for why this tool window disappeared than it would be for the tool window to be completely gone. At least for one release cycle would be my preference. @anderdobo what do you think?

Options:

  1. completely remove the flutter outline view tool window in IntelliJ / Android Studio
  2. remove the outline view content, but leave the tool window. Replace the existing outline content with a message that instructs users to open the IntelliJ structure view to see the tree structure of their code, and to use alt + enter to view a list of available refactorings for a widget.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with #2. We should remove the outline view but have messaging in the tool window that guides developers.

@jwren jwren force-pushed the rm_flutter_outline branch from 35afa69 to b06cab3 Compare November 18, 2024 22:46
@jwren
Copy link
Member Author

jwren commented Nov 18, 2024

@kenzieschmoll @anderdobo

Updated and included information from https://www.jetbrains.com/guide/java/tips/context-actions/, see image:

Screenshot 2024-11-18 at 2 54 52 PM

@jwren jwren merged commit d9c5787 into flutter:master Nov 18, 2024
8 of 9 checks passed
jwren added a commit to jwren/flutter-intellij that referenced this pull request Nov 18, 2024
jwren added a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the Flutter Outline
4 participants