-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment out the usage of the Flutter Outline view #7779
Conversation
f9c05f1
to
35afa69
Compare
Note: Don't commit this until all |
<!-- <toolWindow id="Flutter Outline" anchor="right" icon="FlutterIcons.FlutterDefault"--> | ||
<!-- factoryClass="io.flutter.preview.PreviewViewFactory"/>--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how much work is it to commend out the tool window content instead so that a message can be displayed instructing users to open the Structure view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be removing the current JComponent which holds the outline and buttons with a message and link to go use the provided Structure view.
We decided to remove the outline, this PR, but I didn't know if we decided on having a few simply point devs to a different window was a net-positive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would be less jarring for users to have an explanation for why this tool window disappeared than it would be for the tool window to be completely gone. At least for one release cycle would be my preference. @anderdobo what do you think?
Options:
- completely remove the flutter outline view tool window in IntelliJ / Android Studio
- remove the outline view content, but leave the tool window. Replace the existing outline content with a message that instructs users to open the IntelliJ structure view to see the tree structure of their code, and to use alt + enter to view a list of available refactorings for a widget.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with #2. We should remove the outline view but have messaging in the tool window that guides developers.
…ter Outline to direct users to use Structure view
35afa69
to
b06cab3
Compare
Updated and included information from https://www.jetbrains.com/guide/java/tips/context-actions/, see image: |
This is a follow-up on flutter#7779
This resolves #7778