Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .adaptive constructor for Dialogs #102811

Closed
Tracked by #94821
guidezpl opened this issue Apr 29, 2022 · 5 comments · Fixed by #124336
Closed
Tracked by #94821

Add .adaptive constructor for Dialogs #102811

guidezpl opened this issue Apr 29, 2022 · 5 comments · Fixed by #124336
Assignees
@MitchellGoodwin
Labels
c: new feature Nothing broken; request for a new capability f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Comments

@guidezpl
Copy link
Member

guidezpl commented Apr 29, 2022 •
edited
Loading

This requires some investigation first on feasibility / desireability.
@guidezpl guidezpl mentioned this issue Apr 29, 2022
Closed
11 tasks
@guidezpl guidezpl changed the title Dialogs Add .adaptive constructor for Dialogs Apr 29, 2022
@guidezpl guidezpl mentioned this issue Apr 29, 2022
Closed
@danagbemava-nc danagbemava-nc added in triage Presently being triaged by the triage team framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository and removed in triage Presently being triaged by the triage team labels Apr 29, 2022
@guidezpl guidezpl added the c: new feature Nothing broken; request for a new capability label Apr 29, 2022
@mono0926
Copy link
Contributor

A package for the same purpose has already been released and is so popular now

@rydmike
Copy link
Contributor

rydmike commented Oct 3, 2022 •
edited
Loading

Any day I can add .adaptive to yet another Flutter SDK widget is a good day. Despite existing packages and my own internal version of this, I am for this and think it is a very desirable feature and hope to see it implemented 💙

@dshukertjr
Copy link

Couldn't agree more with @rydmike!

@vbuberen
Copy link

vbuberen commented Oct 5, 2022

A package for the same purpose has already been released and is so popular now

Yes, this is what is currently used by lots of people, but having an option to call .adaptive() (for example, like we can for CirculatProgressIndicator) is much better and straightforward.

@InMatrix InMatrix mentioned this issue Feb 27, 2023
Closed
@MitchellGoodwin MitchellGoodwin self-assigned this Mar 31, 2023
@MitchellGoodwin MitchellGoodwin mentioned this issue Apr 6, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this issue Apr 18, 2023
@MitchellGoodwin
Adaptive alert dialog (#124336)
bd2617e 
Fixes #102811. Adds an adaptive constructor to AlertDialog, along with the adaptive function showAdaptiveDialog.

<img width="357" alt="Screenshot 2023-04-06 at 10 40 18 AM" src="https://user-images.githubusercontent.com/58190796/230455412-31100922-cfc5-4252-b8c6-6f076353f29e.png">
<img width="350" alt="Screenshot 2023-04-06 at 10 42 50 AM" src="https://user-images.githubusercontent.com/58190796/230455454-363dd37e-c44e-4aca-b6a0-cfa1d959f606.png">
@github-actions
Copy link

github-actions bot commented May 2, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@MitchellGoodwin MitchellGoodwin

Labels
c: new feature Nothing broken; request for a new capability f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adaptive alert dialog MitchellGoodwin/flutter
7 participants
@mono0926 @guidezpl @vbuberen @dshukertjr @rydmike @MitchellGoodwin @danagbemava-nc