Skip to content

[web] Fix other places that use clientX/Y rather than offsetX/Y (text input?, semantics helper?) #116561

@ditman

Description

@ditman

So far, these are the places that I've found that aren't using the correct coordinates for the events they're handling (they'd only work in full-screen mode):

pointer_binding.dart

In the pointer_binding, it seems that 'pointerup' events are incorrectly attached to domWindow. Those should be attached to the glassPane. See:

(There's probably a need to synthesize a 'pointercancel' event if there's a pointerup detected OUTSIDE of the glassPane too!)

text_field.dart

See:

(and below)

semantics_helper.dart

See:

(Using client coordinates rather than offset. Note that for touch events, there's no "offset" and it needs to be computed from the clientBoundingRect of the event target!)

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listengineflutter/engine related. See also e: labels.platform-webWeb applications specificallyteam-webOwned by Web platform teamtriaged-webTriaged by Web platform team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions