-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Closed
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: typographyText rendering, possibly libtxtText rendering, possibly libtxtc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)e: web_canvaskitCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for WebCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Webengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specifically
Description
Multiple text layout benchmarks regressed by 3.5x. This started with #123423. The only thing in that roll that seems relevant is flutter/engine#40470. That change only flips the default build of CanvasKit from unpkg to the local build. I thought we were already using local build, so this is surprising. Maybe we were still hitting the NPM build in benchmarks. Perhaps the issue is in the Chromium build (cc @mdebbar). Could this be v8BreakIterator related? Should we cache string fragmentation results?
Metadata
Metadata
Assignees
Labels
P0Critical issues such as a build break or regressionCritical issues such as a build break or regressiona: typographyText rendering, possibly libtxtText rendering, possibly libtxtc: performanceRelates to speed or footprint issues (see "perf:" labels)Relates to speed or footprint issues (see "perf:" labels)e: web_canvaskitCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for WebCanvasKit (a.k.a. Skia-on-WebGL) rendering backend for Webengineflutter/engine related. See also e: labels.flutter/engine related. See also e: labels.platform-webWeb applications specificallyWeb applications specifically