-
Notifications
You must be signed in to change notification settings - Fork 29.6k
Closed
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.
Description
Currently unawaited_futures is disabled in flutter/packages to match flutter/flutter, where the comment is "too many false positives, especially with the way AnimationController works". Based on some preliminary investigation, I don't think this applies to flutter/packages in general; in most packages it seems like there are very few violations. We may want some packages to have custom rules (notably, animation) to suppress it, but we should have it on by default; async operations that should usually be awaited are a core aspect of plugins, and we've had a number of subtle bugs that the option would have prevented.
Metadata
Metadata
Assignees
Labels
P1High-priority issues at the top of the work listHigh-priority issues at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.Team-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.flutter/packages repository. See also p: labels.