Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP-request] Migrate event that is sent with every command for analytics in latest stable #141017

Closed
eliasyishak opened this issue Jan 5, 2024 · 4 comments
Assignees
Labels
P1 High-priority issues at the top of the work list team-tool Owned by Flutter Tool team

Comments

@eliasyishak
Copy link
Contributor

Currently, all of the analytics migration events are being tracked in the tracker issue below:

Those PRs are set to be merged into the latest stable release in version 3.19.0 in February 2024. However, with the timeline for deprecating key features from GA3 moved up to March 2024, we should have at least one event migrated into the current stable 3.16.

I propose that we migrate the event that is sent after each command has been run so that we can limit any drop in MAU numbers as people are slow to upgrade. The PR below adds the new event that is sent at the end of each flutter command invocation

This event is fired for every FlutterCommand since it is being sent from the verifyThenRunCommand method, which must be executed for each command.

@eliasyishak eliasyishak added P1 High-priority issues at the top of the work list team-tool Owned by Flutter Tool team labels Jan 5, 2024
@eliasyishak eliasyishak self-assigned this Jan 5, 2024
@itsjustkevin
Copy link
Contributor

@eliasyishak please use the cherry-pick template, if not the release team will not be informed of when a cherry-pick request has come in.

@eliasyishak
Copy link
Contributor Author

@eliasyishak please use the cherry-pick template, if not the release team will not be informed of when a cherry-pick request has come in.

That's my mistake, I linked the issue for the issue itself and not the CP issue, here's the issue I created through the request form

auto-submit bot pushed a commit that referenced this issue Jan 9, 2024
@eliasyishak
Copy link
Contributor Author

Completed

Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P1 High-priority issues at the top of the work list team-tool Owned by Flutter Tool team
Projects
None yet
Development

No branches or pull requests

2 participants