Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-issue: Update all code to use optional new/const #18604

Closed
3 of 4 tasks
mit-mit opened this issue Jun 19, 2018 · 15 comments
Closed
3 of 4 tasks

Meta-issue: Update all code to use optional new/const #18604

mit-mit opened this issue Jun 19, 2018 · 15 comments
Assignees
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@mit-mit
Copy link
Member

mit-mit commented Jun 19, 2018

Tracking issue for updating all our Flutter example code to use optional new/const (now that we are unblocked by the needed lint dart-lang/sdk#32602 being available):

  • Flutter.io homepage
  • flutter/flutter/examples
  • flutter/plugins/examples
  • flutter/packages/examples
@a14n
Copy link
Contributor

a14n commented Jun 19, 2018

Actually it's still blocked by dart-lang/sdk#57706 and dart-lang/sdk#57712

@mit-mit
Copy link
Member Author

mit-mit commented Jun 20, 2018

Thanks, I reactivated dart-lang/sdk#32596

@pq
Copy link
Contributor

pq commented Jun 26, 2018

@a14n : once the new linter makes it's way into a vended SDK will we be good to make these changes?

@a14n
Copy link
Contributor

a14n commented Jun 27, 2018

I tried to remove unnecessary new/const from flutter codebase and faced a new issue in analyzer dart-lang/sdk#33647

@a14n
Copy link
Contributor

a14n commented Jul 16, 2018

Optional const landed in #19342

@pq
Copy link
Contributor

pq commented Jul 16, 2018

@a14n: this is fantastic. Remind me the plan for unnecessary_new?

@mit-mit
Copy link
Member Author

mit-mit commented Aug 6, 2018

@a14n do we have the no new lint?

@a14n
Copy link
Contributor

a14n commented Aug 6, 2018

unnecessary_const landed with #20103 and flutter/plugins#682.
unnecessary_new is waiting for reviews with #20138 and flutter/plugins#701.

@zoechi zoechi added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label Aug 24, 2018
@a14n
Copy link
Contributor

a14n commented Oct 5, 2018

unnecessary new/const have been removed from flutter/flutter, flutter/plugins and soon in flutter/packages.
On flutter.io the only remaining place with new/const seems to be in images like on home page at the Fast development section.

@mit-mit
Copy link
Member Author

mit-mit commented Oct 8, 2018

Excellent! I'll make sure with @maguinis that we get all images updated!

@mit-mit
Copy link
Member Author

mit-mit commented Oct 15, 2018

Marking flutter/packages done as flutter/packages#4 was merged

@mit-mit
Copy link
Member Author

mit-mit commented Oct 15, 2018

Assigning to self as only item left is updating images on flutter.io

@mit-mit mit-mit self-assigned this Oct 15, 2018
@a14n
Copy link
Contributor

a14n commented Oct 15, 2018

Actually there's still flutter/plugins#818

@mit-mit
Copy link
Member Author

mit-mit commented Nov 14, 2018

This should be done now

@mit-mit mit-mit closed this as completed Nov 14, 2018
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

No branches or pull requests

4 participants