This repository was archived by the owner on Feb 22, 2023. It is now read-only.
enable lint unnecessary_const #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Jul 30, 2018
Member
goderbauer
left a comment
goderbauer
left a comment
There was a problem hiding this comment.
LGTM
@a14n Can You resolve the merge conflict?
Contributor
Author
|
Updated I don't understand why some CI tasks fail. |
Member
|
I've restarted those CI tasks. |
Contributor
Author
|
@tvolkert no problem with Fuchsia to merge this PR? (Re. flutter/flutter#19592 (comment)) |
Contributor
|
Let's hold off on merging just yet -- I'm still wrestling with rolling Flutter into Fuchsia. Thanks! |
Contributor
|
Ok, this is good to go with respect to Fuchsia! thanks 😄 |
This was referenced Aug 1, 2018
julianscheel
pushed a commit
to jusst-engineering/plugins
that referenced
this pull request
Mar 11, 2020
Akachu
pushed a commit
to Akachu/flutter_camera
that referenced
this pull request
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.