package_info broken on ios

[Rockvole]

I read the package_info in my code which works fine on Android.
On the IPhone 6 Plus - 11.4 the code just gives a stack trace.
Code line which crashes :

PackageInfo packageInfo = await PackageInfo.fromPlatform();

Version of package_info is the latest ^0.3.2
Error is :

*** First throw call stack:
(
	0   CoreFoundation                      0x000000010660a1e6 __exceptionPreprocess + 294
	1   libobjc.A.dylib                     0x0000000105856031 objc_exception_throw + 48
	2   CoreFoundation                      0x000000010664a0bc _CFThrowFormattedException + 194
	3   CoreFoundation                      0x000000010651d951 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 321
	4   CoreFoundation                      0x000000010651d7db +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59
	5   package_info                        0x00000001051fe6a3 -[FLTPackageInfoPlugin handleMethodCall:result:] + 707
	6   Flutter                             0x0000000103aaa3e3 __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 118
	7   Flutter                      <…>

[Rockvole]

[✓] Flutter (Channel master, v0.5.9-pre.29, on Mac OS X 10.13.6 17G65, locale en-CA)
    • Flutter version 0.5.9-pre.29 at /work/installs/flutter
    • Framework revision 5311dff1f4 (4 days ago), 2018-08-13 13:35:51 -0700
    • Engine revision e54bc4ea18
    • Dart version 2.0.0-dev.69.5.flutter-eab492385c

[✓] Android toolchain - develop for Android devices (Android SDK 28.0.1)
    • Android SDK at /Users/david/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 9.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 9.4.1, Build version 9F2000
    • ios-deploy 1.9.2
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 27.1.1
    • Dart plugin version 173.4700
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b01)

[✓] Connected devices (1 available)
    • iPhone 6 Plus • AD0930B1-ED30-4370-ACCF-279F86A48CAD • ios • iOS 11.4 (simulator)

• No issues found!

[Rockvole]

@goderbauer

[Rockvole]

@mehmetf @collinjackson @mravn-google @bkonyi @cbracken

[Rockvole]

I have found out how to reproduce this stack trace.
It seems to be related to the newly introduced :

version: 1.0.0+1

line in pubspec.yaml

If you comment out this line (or use an old project which does not have this line). Then you need to do a clean (I do it in XCode). You will get the stacktrace at the fromPlatform() line.

[cbracken]

/cc @bparrishMines too

@Rockvole thanks for reporting this! Sounds like us failing to check for nil values before putting them into the NSDictionary.

[Rockvole]

You are welcome :)

[rtolar]

I also have this issue.
The workaround stated above (add a 'version' tag in the pubspec.yaml) also works for me.

When I first used this feature on Oct 9, 2018, it worked correctly.
On Oct 30, 2018 I noticed that it was causing an application crash.
While I had not changed the immediate code line that causes this crash:

PackageInfo packageInfo = await PackageInfo.fromPlatform();

I had done other code changes in the application, and flutter upgrades.

For me, the crash only presents on iOS (not Android), and only in debug mode.
Release builds don't crash.
Occurs in both iOS simulator (iPhone XS Max), and physical phone (iphone X).

*** First throw call stack:
(
	0   CoreFoundation                      0x000000010ff7e29b __exceptionPreprocess + 331
	1   libobjc.A.dylib                     0x000000010f51a735 objc_exception_throw + 48
	2   CoreFoundation                      0x000000010fec88fc _CFThrowFormattedException + 194
	3   CoreFoundation                      0x000000010ffed5a1 -[__NSPlaceholderDictionary initWithObjects:forKeys:count:] + 321
	4   CoreFoundation                      0x000000010ff79d7b +[NSDictionary dictionaryWithObjects:forKeys:count:] + 59
	5   package_info                        0x000000010eecb6a0 -[FLTPackageInfoPlugin handleMethodCall:result:] + 720
	6   Flutter                             0x000000010d6c59df __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 118
	7   Flutter                      <…>
Lost connection to device.


Richards-MacBook-Pro:myapp3 mylogin$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel dev, v0.10.1, on Mac OS X 10.14 18A391, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK 28.0.2)
[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
[✓] Android Studio (version 3.2)
[✓] Connected device (2 available)

• No issues found!

[ralph-bergmann]

I have problems to reproduce it :-(

When I comment out version: 1.0.3+3 in pubspec.yaml I get in ios/Flutter/Generated.xcconfig

// This is a generated file; do not edit or check into version control.
FLUTTER_ROOT=/Users/ralphbergmann/development/github/flutter
FLUTTER_APPLICATION_PATH=/Users/ralphbergmann/development/flutter/foo
FLUTTER_TARGET=/Users/ralphbergmann/development/flutter/foo/lib/main.dart
FLUTTER_BUILD_DIR=build
SYMROOT=${SOURCE_ROOT}/../build/ios
FLUTTER_FRAMEWORK_DIR=/Users/ralphbergmann/development/github/flutter/bin/cache/artifacts/engine/ios
FLUTTER_BUILD_NAME=1.0.0
FLUTTER_BUILD_NUMBER=1

and if it is not commented out I get:

// This is a generated file; do not edit or check into version control.
FLUTTER_ROOT=/Users/ralphbergmann/development/github/flutter
FLUTTER_APPLICATION_PATH=/Users/ralphbergmann/development/flutter/foo
FLUTTER_TARGET=/Users/ralphbergmann/development/flutter/foo/lib/main.dart
FLUTTER_BUILD_DIR=build
SYMROOT=${SOURCE_ROOT}/../build/ios
FLUTTER_FRAMEWORK_DIR=/Users/ralphbergmann/development/github/flutter/bin/cache/artifacts/engine/ios
FLUTTER_BUILD_NAME=1.0.3
FLUTTER_BUILD_NUMBER=3

In both cases, the app runs on iOS and shows the values of FLUTTER_BUILD_NAME/FLUTTER_BUILD_NUMBER

$ flutter doctor -v
[✓] Flutter (Channel master, v0.10.2-pre.131, on Mac OS X 10.13.6 17G65, locale de-DE)
    • Flutter version 0.10.2-pre.131 at /Users/ralphbergmann/development/github/flutter
    • Framework revision 01c7081565 (10 hours ago), 2018-10-31 21:12:51 -0700
    • Engine revision c79faed71c
    • Dart version 2.1.0 (build 2.1.0-dev.8.0 bf26f760b1)

[✓] iOS toolchain - develop for iOS devices (Xcode 10.0)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.0, Build version 10A255
    • ios-deploy 2.0.0
    • CocoaPods version 1.5.3