Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance overlay can be broken by other layers #21095

Closed
xster opened this issue Aug 28, 2018 · 4 comments
Closed

Performance overlay can be broken by other layers #21095

xster opened this issue Aug 28, 2018 · 4 comments
Labels
engine flutter/engine repository. See also e: labels.

Comments

@xster
Copy link
Member

xster commented Aug 28, 2018

Run

void main() {
  runApp(new CupertinoApp(
      home: CupertinoPageScaffold(
          navigationBar: CupertinoNavigationBar(),
          child: Placeholder())));
}

and turn on the performance overlay.

screen shot 2018-08-27 at 7 54 07 pm

It gets clipped by a clip layer from the content below.

TransformLayer#5e392
 │ owner: RenderView#d1a52
 │ creator: [root]
 │ offset: Offset(0.0, 0.0)
 │ transform:
 │   [0] 2.0,0.0,0.0,0.0
 │   [1] 0.0,2.0,0.0,0.0
 │   [2] 0.0,0.0,1.0,0.0
 │   [3] 0.0,0.0,0.0,1.0
 │
 ├─child 1: OffsetLayer#4c3fc
 │ │ creator: RepaintBoundary ← _FocusScopeMarker ← Semantics ←
 │ │   FocusScope ← PageStorage ← Offstage ← _ModalScopeStatus ←
 │ │   _ModalScope<dynamic>-[LabeledGlobalKey<_ModalScopeState<dynamic>>#a52e8]
 │ │   ← _OverlayEntry-[LabeledGlobalKey<_OverlayEntryState>#f837c] ←
 │ │   Stack ← _Theatre ←
 │ │   Overlay-[LabeledGlobalKey<OverlayState>#e173c] ← ⋯
 │ │ offset: Offset(0.0, 0.0)
 │ │
 │ ├─child 1: PictureLayer#52289
 │ │   paint bounds: Rect.fromLTRB(0.0, 0.0, 375.0, 667.0)
 │ │
 │ └─child 2: OffsetLayer#b18e0
 │   │ creator: RepaintBoundary-[GlobalKey#82d7e] ← IgnorePointer ←
 │   │   Stack ← _CupertinoBackGestureDetector<dynamic> ← DecoratedBox ←
 │   │   DecoratedBoxTransition ← FractionalTranslation ←
 │   │   SlideTransition ← FractionalTranslation ← SlideTransition ←
 │   │   CupertinoPageTransition ← AnimatedBuilder ← ⋯
 │   │ offset: Offset(0.0, 0.0)
 │   │
 │   ├─child 1: PictureLayer#c4d91
 │   │   paint bounds: Rect.fromLTRB(0.0, 0.0, 375.0, 667.0)
 │   │
 │   └─child 2: ClipRectLayer#c2c0b
 │     │ clipRect: Rect.fromLTRB(0.0, 0.0, 375.0, 64.0)
 │     │
 │     └─child 1: BackdropFilterLayer#2ae16
 │       ├─child 1: PictureLayer#94c87
 │       │   paint bounds: Rect.fromLTRB(0.0, 0.0, 375.0, 64.0)
 │       │
 │       └─child 2: AnnotatedRegionLayer<SystemUiOverlayStyle>#60d94
 │           value: {systemNavigationBarColor: 4278190080,
 │             systemNavigationBarDividerColor: null, statusBarColor: null,
 │             statusBarBrightness: Brightness.light, statusBarIconBrightness:
 │             Brightness.dark, systemNavigationBarIconBrightness:
 │             Brightness.light}
 │           size: Size(375.0, 64.0)
 │
 ├─child 2: PerformanceOverlayLayer#bf57f
 └─child 3: PictureLayer#23747
     paint bounds: Rect.fromLTRB(0.0, 0.0, 750.0, 1334.0)
@xster xster added the engine flutter/engine repository. See also e: labels. label Aug 28, 2018
@xster
Copy link
Member Author

xster commented Aug 28, 2018

Actually this is only triggered if the clip layer (#c2c0b in the above) uses hardEdge clip behavior

@GaryQian
Copy link
Contributor

GaryQian commented Sep 5, 2018

I tried running the app, and the overlay is correctly on top of everything. Is this still an issue or was it fixed?

@xster
Copy link
Member Author

xster commented Sep 6, 2018

Ya, the caveat is it only breaks when the clip at

is using hardEdge clipBehavior

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Development

No branches or pull requests

2 participants