Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support floating cursor double press on iOS #30476

Closed
xster opened this issue Apr 4, 2019 · 2 comments · Fixed by #113048, flutter/engine#36643 or #116746
Closed

Support floating cursor double press on iOS #30476

xster opened this issue Apr 4, 2019 · 2 comments · Fixed by #113048, flutter/engine#36643 or #116746
Labels
a: fidelity Matching the OEM platforms better a: text input Entering text in a text field or keyboard related problems c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project platform-ios iOS applications specifically

Comments

@xster
Copy link
Member

xster commented Apr 4, 2019

1 force press on the keyboard engages the floating cursor move mode.
A second force press leaves a selection anchor and then selects full words between the anchor and the current floating cursor position.
@xster xster added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically a: fidelity Matching the OEM platforms better labels Apr 4, 2019
@xster xster mentioned this issue Apr 4, 2019
Merged
@VladyslavBondarenko VladyslavBondarenko added the framework flutter/packages/flutter repository. See also f: labels. label Jan 13, 2020
@TahaTesser TahaTesser added the c: new feature Nothing broken; request for a new capability label Mar 12, 2020
This was referenced Oct 6, 2022
Merged
Merged
@jmagman
Copy link
Member

jmagman commented Oct 10, 2022

@moffatman this should be linked to flutter/engine#36643 and reopened, correct?

@jmagman jmagman reopened this Oct 10, 2022
@moffatman moffatman mentioned this issue Dec 8, 2022
Merged
8 tasks
@moffatman moffatman reopened this Dec 10, 2022
@moffatman moffatman mentioned this issue Dec 21, 2022
Merged
8 tasks
@moffatman moffatman mentioned this issue Feb 3, 2023
Merged
8 tasks
@goderbauer goderbauer added P3 Issues that are less important to the Flutter project engine flutter/engine repository. See also e: labels. labels Feb 7, 2023
This was referenced Mar 7, 2023
Merged
Merged
@moffatman moffatman mentioned this issue Apr 18, 2023
Merged
8 tasks
auto-submit bot pushed a commit that referenced this issue Apr 22, 2023
@moffatman
Adjust selection rects inclusion criteria (#125022)
e84daf3 
Include rects with any overlap instead of only when top-left or bottom-right included. The previous criteria didn't send any selection rects when text was taller than the text box and scroll offset was not zero.

Part of #30476
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 11, 2023
@moffatman
iPhone floating cursor selection (#36643)
b120180 
Floating cursor selection hasn't worked as we haven't been returning a real value for `caretRectForPosition:`. If we have the selection rectangles, we can do so. 

Fixes [#30476](flutter/flutter#30476)

Requires selection rects to be turned on for iPhone (flutter/flutter#113048)

writing and running engine tests.
@hellohuanlin hellohuanlin mentioned this issue May 18, 2023
Merged
8 tasks
auto-submit bot pushed a commit to flutter/engine that referenced this issue May 19, 2023
@hellohuanlin
[floating_cursor_selection]add some comments on the tricky part (#42136)
f471b37 
Many parts of the floating cursor selection feature is pretty tricky. Some took me a while to figure out. So I added some comments to explain a bit for future readers. 

*List which issues are fixed by this PR. You must list at least one issue.*

flutter/flutter#30476

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
This was referenced May 19, 2023
Merged
Merged
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
a: fidelity Matching the OEM platforms better a: text input Entering text in a text field or keyboard related problems c: new feature Nothing broken; request for a new capability engine flutter/engine repository. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. P3 Issues that are less important to the Flutter project platform-ios iOS applications specifically
Projects
None yet
Milestone
No milestone
6 participants
@xster @jmagman @moffatman @goderbauer @VladyslavBondarenko @TahaTesser