update_dart_sdk.sh does not handle spaces in paths well #5022
Labels
tool
Affects the "flutter" command-line tool. See also t: labels.
Comments
devoncarew
added
the
tool
eseidelGoogle
changed the title
|
If we fix this and want to not break it again we'll want to change our bots to have a space in their path: https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipes/flutter/flutter.py This is a very common problem for tools in a unix-like environment to not handle spaces well. :/ |
|
@bkonyi This may be relevant to your current interests. |
|
/cc @cbracken as well |
chinmaygarde
added a commit
to chinmaygarde/flutter
that referenced
this issue
Apr 17, 2018
This roll includes the following engine commits: * flutter/engine@0c09bf03: In the service protocol, if no view is specified to flush tasks on, pick the first one. (flutter#5028) * flutter/engine@ecaefd7a: Roll src/third_party/skia/ 276886160..1cd6098d5 (50 commits) (flutter#5026) * flutter/engine@e6545573: Enable 'Speak Screen' and 'Switch Control' for iOS (flutter#5016) * flutter/engine@3393c179: Fix Android platform channels (flutter#5025) * flutter/engine@1bc0e1bb: On windows, refer to Dart snapshot directly executable. (flutter#5024) * flutter/engine@cf6ca32d: Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" (flutter#5023) * flutter/engine@4b45a53e: Only make ERROR and FATAL log levels visible by default. (flutter#5022) * flutter/engine@98f6c2d5: Fix shell launcher test (dart2 compliant and stop polling) (flutter#5009) * flutter/engine@75851f08: Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 (flutter#5020) * flutter/engine@9495a52d: On iOS, try to use ES3, then fall back to ES2. (flutter#5006) * flutter/engine@d6d4eec2: Fix broken Linux build (flutter#5019) * flutter/engine@d15dc76e: Fix broken Chromebot build (flutter#5018) * flutter/engine@c17a6290: Breadcrumbs to the wiki (flutter#5017) * flutter/engine@4eaf2c2f: Return raw (unencoded) bytes in Image.toByteData() (flutter#5008) * flutter/engine@d812a617: Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) (flutter#5014) * flutter/engine@62aeab72: Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. (flutter#5012) * flutter/engine@f4ebb180: Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) (flutter#5007) * flutter/engine@0b7d6be9: Re-land "do not pause rendering when android view loses focus" (flutter#5004) * flutter/engine@91dee598: If the rasterizer has a valid surface context, use that to create a snapshotting render target. (flutter#4979) * flutter/engine@570231b7: Specify the packages file path when running engine dart tests. (flutter#5005) * flutter/engine@0b9cef5a: Minor update to README (flutter#5003) * flutter/engine@c386418f: Promote line height in text style created from paragraph style (flutter#4995) * flutter/engine@4e0fbb6f: If the test specifies a .dill file, dont make the engine interpret is as source. (flutter#5002) * flutter/engine@58e84c8b: Re-land "Support multiple shells in a single process. (flutter#4932)" (flutter#4998) * flutter/engine@37e5df05: Remove only use of SkPaint::kGenA8FromLCD (flutter#4994) * flutter/engine@b7358b33: libtxt: cache font families that are remapped to the default font family (flutter#4990) * flutter/engine@a530035b: libtxt: fix leaks in Skia object reference counting (flutter#4988) * flutter/engine@0c74fc93: [fuchsia] Fix use-after-free (flutter#4987) * flutter/engine@b6d2dde9: [fuchsia] Fix build (flutter#4986) * flutter/engine@1dd12649: [async] Adapt to libasync API changes. (flutter#4980)
tvolkert
pushed a commit
that referenced
this issue
Apr 17, 2018
This roll includes the following engine commits: * flutter/engine@0c09bf03: In the service protocol, if no view is specified to flush tasks on, pick the first one. (#5028) * flutter/engine@ecaefd7a: Roll src/third_party/skia/ 276886160..1cd6098d5 (50 commits) (#5026) * flutter/engine@e6545573: Enable 'Speak Screen' and 'Switch Control' for iOS (#5016) * flutter/engine@3393c179: Fix Android platform channels (#5025) * flutter/engine@1bc0e1bb: On windows, refer to Dart snapshot directly executable. (#5024) * flutter/engine@cf6ca32d: Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" (#5023) * flutter/engine@4b45a53e: Only make ERROR and FATAL log levels visible by default. (#5022) * flutter/engine@98f6c2d5: Fix shell launcher test (dart2 compliant and stop polling) (#5009) * flutter/engine@75851f08: Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 (#5020) * flutter/engine@9495a52d: On iOS, try to use ES3, then fall back to ES2. (#5006) * flutter/engine@d6d4eec2: Fix broken Linux build (#5019) * flutter/engine@d15dc76e: Fix broken Chromebot build (#5018) * flutter/engine@c17a6290: Breadcrumbs to the wiki (#5017) * flutter/engine@4eaf2c2f: Return raw (unencoded) bytes in Image.toByteData() (#5008) * flutter/engine@d812a617: Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) (#5014) * flutter/engine@62aeab72: Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. (#5012) * flutter/engine@f4ebb180: Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) (#5007) * flutter/engine@0b7d6be9: Re-land "do not pause rendering when android view loses focus" (#5004) * flutter/engine@91dee598: If the rasterizer has a valid surface context, use that to create a snapshotting render target. (#4979) * flutter/engine@570231b7: Specify the packages file path when running engine dart tests. (#5005) * flutter/engine@0b9cef5a: Minor update to README (#5003) * flutter/engine@c386418f: Promote line height in text style created from paragraph style (#4995) * flutter/engine@4e0fbb6f: If the test specifies a .dill file, dont make the engine interpret is as source. (#5002) * flutter/engine@58e84c8b: Re-land "Support multiple shells in a single process. (#4932)" (#4998) * flutter/engine@37e5df05: Remove only use of SkPaint::kGenA8FromLCD (#4994) * flutter/engine@b7358b33: libtxt: cache font families that are remapped to the default font family (#4990) * flutter/engine@a530035b: libtxt: fix leaks in Skia object reference counting (#4988) * flutter/engine@0c74fc93: [fuchsia] Fix use-after-free (#4987) * flutter/engine@b6d2dde9: [fuchsia] Fix build (#4986) * flutter/engine@1dd12649: [async] Adapt to libasync API changes. (#4980)
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this issue
May 14, 2018
This roll includes the following engine commits: * flutter/engine@0c09bf03: In the service protocol, if no view is specified to flush tasks on, pick the first one. (flutter#5028) * flutter/engine@ecaefd7a: Roll src/third_party/skia/ 276886160..1cd6098d5 (50 commits) (flutter#5026) * flutter/engine@e6545573: Enable 'Speak Screen' and 'Switch Control' for iOS (flutter#5016) * flutter/engine@3393c179: Fix Android platform channels (flutter#5025) * flutter/engine@1bc0e1bb: On windows, refer to Dart snapshot directly executable. (flutter#5024) * flutter/engine@cf6ca32d: Revert "Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79" (flutter#5023) * flutter/engine@4b45a53e: Only make ERROR and FATAL log levels visible by default. (flutter#5022) * flutter/engine@98f6c2d5: Fix shell launcher test (dart2 compliant and stop polling) (flutter#5009) * flutter/engine@75851f08: Roll Dart to fe606f890b0a311da802c78b0af414a3c2087a79 (flutter#5020) * flutter/engine@9495a52d: On iOS, try to use ES3, then fall back to ES2. (flutter#5006) * flutter/engine@d6d4eec2: Fix broken Linux build (flutter#5019) * flutter/engine@d15dc76e: Fix broken Chromebot build (flutter#5018) * flutter/engine@c17a6290: Breadcrumbs to the wiki (flutter#5017) * flutter/engine@4eaf2c2f: Return raw (unencoded) bytes in Image.toByteData() (flutter#5008) * flutter/engine@d812a617: Roll src/third_party/skia/ e669bdfad..276886160 (9 commits) (flutter#5014) * flutter/engine@62aeab72: Call SkSurface::flush instead of getting a backend handle in vulkan_swapchain. (flutter#5012) * flutter/engine@f4ebb180: Roll src/third_party/skia/ 3462eb034..e669bdfad (54 commits) (flutter#5007) * flutter/engine@0b7d6be9: Re-land "do not pause rendering when android view loses focus" (flutter#5004) * flutter/engine@91dee598: If the rasterizer has a valid surface context, use that to create a snapshotting render target. (flutter#4979) * flutter/engine@570231b7: Specify the packages file path when running engine dart tests. (flutter#5005) * flutter/engine@0b9cef5a: Minor update to README (flutter#5003) * flutter/engine@c386418f: Promote line height in text style created from paragraph style (flutter#4995) * flutter/engine@4e0fbb6f: If the test specifies a .dill file, dont make the engine interpret is as source. (flutter#5002) * flutter/engine@58e84c8b: Re-land "Support multiple shells in a single process. (flutter#4932)" (flutter#4998) * flutter/engine@37e5df05: Remove only use of SkPaint::kGenA8FromLCD (flutter#4994) * flutter/engine@b7358b33: libtxt: cache font families that are remapped to the default font family (flutter#4990) * flutter/engine@a530035b: libtxt: fix leaks in Skia object reference counting (flutter#4988) * flutter/engine@0c74fc93: [fuchsia] Fix use-after-free (flutter#4987) * flutter/engine@b6d2dde9: [fuchsia] Fix build (flutter#4986) * flutter/engine@1dd12649: [async] Adapt to libasync API changes. (flutter#4980)
|
Fixed in #8014 |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We see:
from
update_dart_sdk.sh.https://github.com/flutter/flutter/blob/master/bin/cache/update_dart_sdk.sh#L8
The text was updated successfully, but these errors were encountered: