Skip to content

Upgrade java mockito to 2 #59356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xster opened this issue Jun 12, 2020 · 1 comment
Open

Upgrade java mockito to 2 #59356

xster opened this issue Jun 12, 2020 · 1 comment
Labels
a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-android Owned by Android platform team triaged-android Triaged by Android platform team

Comments

@xster
Copy link
Member

xster commented Jun 12, 2020

https://github.com/flutter/engine/blob/d417772d7acddd447bd503e6cecefec862ab1622/shell/platform/android/embedding_bundle/build.gradle#L59-L59

There's no reason why we should be on 1 still. For instance mockito 1 can't mock final classes.
@xster xster added a: tests "flutter test", flutter_test, or one of our tests team Infra upgrades, team productivity, code health, technical debt. See also team: labels. platform-android Android applications specifically engine flutter/engine repository. See also e: labels. labels Jun 12, 2020
@xster xster mentioned this issue Jun 12, 2020
Merged
@pedromassangocode
Copy link

Still valid on latest master: Mockito currently is: embeddingTesting "org.mockito:mockito-all:1.10.19"

https://github.com/flutter/engine/blob/1281b830108c16c6a8a432034361623b0990cc76/shell/platform/android/embedding_bundle/build.gradle#L65

@pedromassangocode pedromassangocode added found in release: 1.25 Found to occur in 1.25 passed first triage c: tech-debt Technical debt, code quality, testing, etc. and removed found in release: 1.25 Found to occur in 1.25 labels Dec 4, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label Dec 11, 2020
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-android Owned by Android platform team triaged-android Triaged by Android platform team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: tests "flutter test", flutter_test, or one of our tests c: tech-debt Technical debt, code quality, testing, etc. engine flutter/engine repository. See also e: labels. P2 Important issues not at the top of the work list platform-android Android applications specifically team Infra upgrades, team productivity, code health, technical debt. See also team: labels. team-android Owned by Android platform team triaged-android Triaged by Android platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@xster @Hixie @kf6gpe @pedromassangocode