Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tooltip textAlign property #103475

Merged
merged 1 commit into from
May 12, 2022

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented May 11, 2022

Description

This PR add a new textAlign property to Tooltip and TooltipThemeData.
Default value is TextAlign.start.

Related Issue

Fixes #82629

Tests

Add 2 tests, one for Tooltip and one for TooltipThemeData.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels May 11, 2022
@bleroux bleroux requested a review from chunhtai May 11, 2022 08:53
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -197,6 +198,13 @@ class Tooltip extends StatefulWidget {
/// used with [Colors.black].
final TextStyle? textStyle;

/// How the message of the tooltip should be aligned horizontally.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// How the message of the tooltip should be aligned horizontally.
/// How the message of the tooltip is aligned horizontally.

@bleroux bleroux force-pushed the add_tooltip_text_align branch 2 times, most recently from 3f3c7d5 to ba11a87 Compare May 12, 2022 07:25
@bleroux bleroux force-pushed the add_tooltip_text_align branch from ba11a87 to 34083e7 Compare May 12, 2022 19:26
@fluttergithubbot fluttergithubbot merged commit 190d776 into flutter:master May 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 12, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip widget is missing textAlign: property
3 participants