Skip to content

Delete flaky flutter_gallery XCUITest #103666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2022
Merged

Delete flaky flutter_gallery XCUITest #103666

merged 1 commit into from
May 13, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented May 12, 2022

Fixes #95193

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this May 12, 2022
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label May 12, 2022
@jmagman jmagman requested a review from cyanglaz May 13, 2022 00:23
cyanglaz
cyanglaz approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented May 13, 2022

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit 145be18 into flutter:master May 13, 2022
christopherfujino added a commit that referenced this pull request May 13, 2022
@christopherfujino
Revert "Delete flaky flutter_gallery XCUITest (#103666)"
bd8d0f3 
This reverts commit 145be18.
@christopherfujino christopherfujino mentioned this pull request May 13, 2022
Merged
@jmagman jmagman mentioned this pull request May 13, 2022
Merged
8 tasks
christopherfujino added a commit that referenced this pull request May 13, 2022
@christopherfujino
Revert "Delete flaky flutter_gallery XCUITest (#103666)" (#103726)
708c363 
This reverts commit 145be18.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
d2038b7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 13, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
42a9170
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
86cc3f1
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
7729e91
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
23bf793
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 13, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 13, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
801c686
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
1a7fc56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 14, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
76db261
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
2827a25
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
33f3d90
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
c0a9ca5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 15, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
c6d41bb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
bfa629c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
542d287
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
2e5325a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
0762d82
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
4950f57
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
059c28c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
6dd95c0
@jmagman jmagman deleted the gallery-delete-ui-test branch May 16, 2022 23:00
@jmagman jmagman restored the gallery-delete-ui-test branch May 16, 2022 23:00
@jmagman jmagman mentioned this pull request May 16, 2022
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 16, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
57745d3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request May 17, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
0a2acb9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
2721d34
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
@engine-flutter-autoroll
145be18 Delete flaky flutter_gallery XCUITest (flutter/flutter#103666)
87e121c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@cyanglaz cyanglaz cyanglaz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac_ios native_ui_tests_ios is 2.00% flaky, crash in XCUIApplicationMonitor

3 participants

@jmagman @fluttergithubbot @cyanglaz