Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fuchsia] Change format of ffx call to debug spam. #105169

Merged
merged 1 commit into from
Jul 10, 2022

Conversation

akbiggs
Copy link
Contributor

@akbiggs akbiggs commented Jun 1, 2022

Fuchsia is seeing a large amount of
ffx analytics spam with the command
ffx -T 30 target list --format s. We
suspect it is coming from this file but are
not 100% sure. We are changing the format of this
call to verify that the spammed command also
changes in our analytics.

@akbiggs akbiggs requested a review from christopherfujino June 1, 2022 21:35
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 1, 2022
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino
Copy link
Member

Pushed a merge from upstream to to fix the JWT error on cirrus

@akbiggs
Copy link
Contributor Author

akbiggs commented Jun 2, 2022

Thanks!

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino
Copy link
Member

Let me push a unit test fix, too

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for consistency, should we also update line 88?

@akbiggs akbiggs force-pushed the debug-analytics branch 2 times, most recently from 9d21a6b to 0c20d9f Compare June 2, 2022 22:14
@akbiggs
Copy link
Contributor Author

akbiggs commented Jun 2, 2022

Updated that line now, thanks.

@christopherfujino
Copy link
Member

Working to fix unit tests...

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows tool_tests_general has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite tool_tests-general-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac_android run_release_test has failed. Please fix the issues identified (or deflake) before re-applying this label.

@akbiggs akbiggs force-pushed the debug-analytics branch 3 times, most recently from eff97e7 to 3ddcfb9 Compare June 14, 2022 23:37
@flutter-dashboard
Copy link

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Fuchsia is seeing a large amount of
ffx analytics spam with the command
`ffx -T 30 target list --format s`. We
suspect it is  coming from this file but are
not sure. We are changing the format of this call to
verify that the spammed command also
changes in our analytics.
@akbiggs akbiggs added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 10, 2022
@auto-submit auto-submit bot merged commit 7db73c0 into flutter:master Jul 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Jul 12, 2022
camsim99 pushed a commit to camsim99/flutter that referenced this pull request Aug 10, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants