Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required dependencies for Mac flutter_gallery_macos__compile target. #110366

Merged
merged 2 commits into from
Aug 26, 2022
Merged

Add required dependencies for Mac flutter_gallery_macos__compile target. #110366

merged 2 commits into from
Aug 26, 2022

Conversation

a-wallen
Copy link
Contributor

@a-wallen a-wallen commented Aug 26, 2022 •
edited
Loading

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@a-wallen a-wallen assigned loic-sharma and unassigned loic-sharma Aug 26, 2022
@a-wallen a-wallen requested a review from loic-sharma August 26, 2022 18:49
@a-wallen a-wallen added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 26, 2022
@a-wallen a-wallen marked this pull request as ready for review August 26, 2022 19:11
@a-wallen a-wallen requested a review from keyonghan as a code owner August 26, 2022 19:11
@auto-submit auto-submit bot merged commit b3ae6ff into flutter:master Aug 26, 2022
a-wallen added a commit that referenced this pull request Aug 26, 2022
@a-wallen
Revert "Add required dependencies for `Mac flutter_gallery_macos__com…
c1ffb94 
…pile` target. (#110366)"

This reverts commit b3ae6ff.
@a-wallen a-wallen mentioned this pull request Aug 26, 2022
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 26, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 26, 2022
@engine-flutter-autoroll
b3ae6ff Add required dependencies for `Mac flutter_gallery_macos__com…
5c8e5e9 
…pile` target. (flutter/flutter#110366)
@a-wallen a-wallen mentioned this pull request Aug 26, 2022
Closed
8 tasks
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 27, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Aug 27, 2022
@engine-flutter-autoroll
b3ae6ff Add required dependencies for `Mac flutter_gallery_macos__com…
9725ec1 
…pile` target. (flutter/flutter#110366)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2022
@engine-flutter-autoroll
b3ae6ff Add required dependencies for `Mac flutter_gallery_macos__com…
dcfdaa9 
…pile` target. (flutter/flutter#110366)
@a-wallen a-wallen mentioned this pull request Aug 29, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaakovschectman yaakovschectman yaakovschectman approved these changes

@cbracken cbracken Awaiting requested review from cbracken

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

@keyonghan keyonghan Awaiting requested review from keyonghan

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-wallen @yaakovschectman @loic-sharma