Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reland - Fix ExpansionTile shows children background when expanded #112178

Closed
wants to merge 1 commit into from
Closed

Reland - Fix ExpansionTile shows children background when expanded #112178

wants to merge 1 commit into from

Conversation

bleroux
Copy link
Contributor

@bleroux bleroux commented Sep 22, 2022

Description

Reland #107834, which was reverted in #108844.
(With a slight change at the end of the test due to #108648 which changed how the Material widget is rendered: calling drawRect instead of drawPath).

Related issues

Fixes #107030

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Sep 22, 2022
@bleroux bleroux mentioned this pull request Sep 22, 2022
Merged
@bleroux bleroux requested a review from Piinks September 22, 2022 15:13
@keyonghan keyonghan mentioned this pull request Sep 22, 2022
Closed
@bleroux bleroux force-pushed the reland_fix_expansion_tile_convenient_material_above_children branch from 0d6fa25 to db565c0 Compare September 23, 2022 20:29
Piinks
Piinks reviewed Oct 3, 2022
View reviewed changes
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bleroux! I am investigating the internal tests now. :)

@Piinks
Copy link
Contributor

Piinks commented Oct 4, 2022

This broke many tests internally from several different projects, so I don't think we'll move forward with this change right now. I'll leave a note in the issue stating that we have a fix, but need to plan a customer migration before proceeding with it. Thanks @bleroux for reopening this. It's really helpful to know what we need to plan for. :)

@Piinks Piinks closed this Oct 4, 2022
@Piinks Piinks mentioned this pull request Oct 4, 2022
Open
@bleroux bleroux deleted the reland_fix_expansion_tile_convenient_material_above_children branch October 4, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Piinks Piinks Piinks left review comments

Assignees
No one assigned
Labels
f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ExpansionTile shows children background on animation
2 participants
@bleroux @Piinks