-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #121220
Revert "Speed up first asset load by using the binary-formatted asset manifest for image resolution" #121220
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#118782 made Flutter throw an error earlier when trying to resolve an asset that wasn't included using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…r-image-resolution
auto label is removed for flutter/flutter, pr: 121220, due to - The status or check suite docs-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
…r-image-resolution
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
…ed asset manifest for image resolution (#118782)" (flutter/flutter#121220)
Reverts #118782
This is breaking internal tests as some goldens are showing an asset can no longer be found.