-
Notifications
You must be signed in to change notification settings - Fork 28.6k
Update Material 3 bottom sheet #122445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Material 3 bottom sheet #122445
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Quick comments about docs and relation with enableDrag
Everything LGTM now except what's covered in existing open threads: I'll leave @HansMuller and @guidezpl to wrap those up and approve the PR when they think it's ready. Thanks for all your work on this! |
052f822
to
fe04be7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just minor nits about formatting and docs
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
ce7faf5
to
0d7efc7
Compare
auto label is removed for flutter/flutter, pr: 122445, due to - The status or check suite Windows web_tool_tests_1_2 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
e756a8f
to
d45e0e6
Compare
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Co-authored-by: Pierre-Louis <6655696+guidezpl@users.noreply.github.com>
Update bottom_sheet_test.dart Update bottom_sheet.dart
d45e0e6
to
2b10969
Compare
issue:#111448
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.