Add Java-Gradle-AGP validation to flutter analyze #123916

reidbaker · 2023-04-01T01:01:01Z

Doc covering a broad set of issues related to android studio updating.
https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1#

Specifically this pr:

Adds new functions to find a projects AGP, Gradle and java versions, and tests.
Adds new functions that take versions and parse if the versions are compatible with each other, and tests.
Adds validator for flutter analyze --suggestions that evaluates the java/gradle/agp versions and checks if they are compatible, and integration test.
Updates the version of gradle used by dev/integration_tests/flutter_gallery/ to the minimum supported by java 18 so that the integration tests pass (It is unknown why the java version is 18.9 instead of 11)
Moves isWithinVersionRange to version.dart, and tests.
Adds FakeAndroidStudio to fakes to be used in multiple tests but does not remove existing copies.

Metrics will be included as part of the definition of done for this bug but not as part of this cl. It is already too big.

Known work still left in this pr:

Understand why analyze integration tests are failing.

Example output if Java and gradle are not compatible:

┌───────────────────────────────────────────────────────────────────┐
│ General Info                                                      │
│ [✓] App Name: espresso_example                                    │
│ [✓] Supported Platforms: android                                  │
│ [✓] Is Flutter Package: yes                                       │
│ [✓] Uses Material Design: yes                                     │
│ [✓] Is Plugin: no                                                 │
│ [✗] Java/Gradle/Android Gradle Plugin:                            │
│                                                                   │
│ Incompatible Java/Gradle versions.                                │
│                                                                   │
│ Java Version: 17.0.6, Gradle Version: 7.0.2                       │
│                                                                   │
│ See the link below for more information.                          │
│ https://docs.gradle.org/current/userguide/compatibility.html#java │
│                                                                   │
└───────────────────────────────────────────────────────────────────┘

Example output if Gradle and AGP are not compatible

┌─────────────────────────────────────────────────────────────────────────────┐
│ General Info                                                                │
│ [✓] App Name: espresso_example                                              │
│ [✓] Supported Platforms: android                                            │
│ [✓] Is Flutter Package: yes                                                 │
│ [✓] Uses Material Design: yes                                               │
│ [✓] Is Plugin: no                                                           │
│ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions.    │
│                                                                             │
│ Gradle Version: 7.0.2, AGP Version: 7.4.2                                   │
│                                                                             │
│ Update gradle to at least "7.5".                                            │
│ See the link below for more information:                                    │
│ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │
│                                                                             │
│ Incompatible Java/Gradle versions.                                          │
│                                                                             │
│ Java Version: 17.0.6, Gradle Version: 7.0.2                                 │
│                                                                             │
│ See the link below for more information:                                    │
│ https://docs.gradle.org/current/userguide/compatibility.html#java           │
│                                                                             │
└─────────────────────────────────────────────────────────────────────────────┘

Example output if Java/Gradle/Agp are not compatible.


┌─────────────────────────────────────────────────────────────────────────────┐
│ General Info                                                                │
│ [✓] App Name: espresso_example                                              │
│ [✓] Supported Platforms: android                                            │
│ [✓] Is Flutter Package: yes                                                 │
│ [✓] Uses Material Design: yes                                               │
│ [✓] Is Plugin: no                                                           │
│ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions.    │
│                                                                             │
│ Gradle Version: 7.0.2, AGP Version: 7.4.2                                   │
│                                                                             │
│ Update gradle to at least "7.5".                                            │
│ See the link below for more information:                                    │
│ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │
│                                                                             │
│ Incompatible Java/Gradle versions.                                          │
│                                                                             │
│ Java Version: 17.0.6, Gradle Version: 7.0.2                                 │
│                                                                             │
│ See the link below for more information:                                    │
│ https://docs.gradle.org/current/userguide/compatibility.html#java           │
│                                                                             │
└─────────────────────────────────────────────────────────────────────────────┘

Commit messages

Add function to gradle_utils.dart that gets the gradle version from wrapper or system and add a test for each situation
Add method to get agp version, add method to validate agp against gradle version, update documentation, add tests for agp validation.
Update dart doc for validateGradleAndAgp to describe where the info came from and corner case behavior, create function to validate java and gradle and hardcode return to false
Fill out and test java gradle compatibility function in gradle_utils
Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with hardcoded java version
Add java --version output parsing and tests
Add getJavaBinary test
Update comment in android_sdk for mac behavior with java_home -v

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

…rapper or system and add a test for each situation

…ration test

…dle version, update documenation, add tests for agp validation.

…java version.

…lilty

…ame from and corner case behavior, create function to validate java and gradle and hardcode return to false

… hardcoded java version

…r of data

packages/flutter_tools/lib/src/android/gradle_utils.dart

reidbaker · 2023-04-01T01:57:59Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

+  // Update these when new versions of AGP or Gradle come out.
+  const String maxKnownAgpVersion = '8.1';
+
+  // TODO are these the correct values we want to support?


Open to feedback here.

bartekpacia · 2023-04-04T20:21:38Z

packages/flutter_tools/lib/src/android/android_sdk.dart

+  // Returns the version of java in the format \d(.\d)+(.\d)+
+  // Returns null if version not found.


Shouldn't these be ///?

good catch fixed.

bartekpacia · 2023-04-04T20:22:02Z

packages/flutter_tools/lib/src/android/android_sdk.dart

+    return parseJavaVersion(result.stdout);
+  }
+
+  // Extracts jdk version from the output of java --version.


Same here.

Also, I prefer "JDK" to "jdk" :P

Fixed but I doubt I will get all the places updated.

bartekpacia · 2023-04-04T20:23:46Z

packages/flutter_tools/lib/src/android/android_sdk.dart

-    return operatingSystemUtils.which(_javaExecutable)?.path;
+    final String? pathJava = operatingSystemUtils.which(_javaExecutable)?.path;
+    if (pathJava != null) {
+      globals.printTrace('Using path java.');


tiny nit ("path java" took me a few seconds to parse&understand than "java from PATH")

Suggested change

globals.printTrace('Using path java.');

globals.printTrace('Using java from PATH.');

Good readability suggestion. Fixed.

bartekpacia · 2023-04-04T20:25:41Z

packages/flutter_tools/lib/src/project.dart

+  /// Ensures Java Sdk is compatible with the project's gradle version and
+  /// the project's gradle version is compatible with the AGP version used
+  /// in build.gradle.


Suggested change

/// Ensures Java Sdk is compatible with the project's gradle version and

/// the project's gradle version is compatible with the AGP version used

/// in build.gradle.

/// Ensures Java SDK is compatible with the project's Gradle version and

/// the project's Gradle version is compatible with the AGP version used

/// in build.gradle.

bartekpacia · 2023-04-04T20:25:57Z

packages/flutter_tools/lib/src/project.dart

+      description = '''
+Incompatible Gradle/AGP versions. \n
+Gradle Version: $gradleVersion, AGP Version: $agpVersion
+Update gradle to at least "${gradle.getGradleVersionFor(agpVersion!)}".\n


Suggested change

Update gradle to at least "${gradle.getGradleVersionFor(agpVersion!)}".\n

Update Gradle to at least "${gradle.getGradleVersionFor(agpVersion!)}".\n

bartekpacia · 2023-04-04T20:27:57Z

packages/flutter_tools/test/general.shard/utils_test.dart

it'd be nice if all the test cases in this file had the same formatting

I agree. For the life of this cl I was fighting and auto formatter and given its size and some of the edge cases I didnt want a bunch of extra whitespace formatting making the review harder. That said I like individual tests cases instead of tests with dozens of test cases. I ran my formatter on just the lines I added to make sure they are consistent.

In general the Flutter repo does not use an auto-formatter:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#in-defense-of-the-extra-work-that-hand-formatting-entails

So if you have an auto-formatter running in your editor, it's probably a good idea to turn it off so that you don't have to fight it.

I ran my formatter on just the lines I added to make sure they are consistent.

Sometimes an auto-formatter makes things less consistent with each other, rather than more consistent. I think this is one of those times. There's three different formats in this test file:

test('pre java 8 format included', () { expect(isWithinVersionRange('1.0.0_201', min: '1.0.0', max: '1.1.3'), isTrue); }); test('min included by default', () { expect( isWithinVersionRange('1.0.0', min: '1.0.0', max: '1.1.3'), isTrue); }); // … test('inclusive min excluded', () { expect( isWithinVersionRange('1.0.0', min: '1.0.0', max: '1.1.3', inclusiveMin: false), isFalse); });

and those look to me like the kind of inconsistency that is typical for an auto-formatter to produce. It'd be better to pick one consistent format for all these test cases.

I think that first format is a good one, with just the isTrue or isFalse on a new line. That, or putting the whole thing on one line:

test('pre java 8 format included', () { expect(isWithinVersionRange('1.0.0_201', min: '1.0.0', max: '1.1.3'), isTrue); });

bartekpacia · 2023-04-04T20:29:57Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

@@ -43,25 +44,45 @@ const String minSdkVersion = '16';
 const String targetSdkVersion = '31';
 const String ndkVersion = '23.1.7779620';

-final RegExp _androidPluginRegExp = RegExp(r'com\.android\.tools\.build:gradle:(\d+\.\d+\.\d+)');
+// Update this when new versions of Gradle come out.
+const String _maxKnownAndSupportedGradleVersion = '8.0';


Should it also be updated for minor versions like 8.0.2? Might be worth including this info in the comment.

Yes, and comment updated.

packages/flutter_tools/lib/src/android/gradle_utils.dart

…lilty

gnprice · 2023-04-05T18:03:37Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

+    JavaGradleCompat(
+      javaMin: '19',
+      javaMax: '20',
+      gradleMin: '7.6',
+      gradleMax: _maxKnownAndSupportedGradleVersion,
+    ),
+    JavaGradleCompat(
+      javaMin: '18',
+      javaMax: '19',
+      gradleMin: '7.5',
+      gradleMax: _maxKnownAndSupportedGradleVersion,
+    ),


I think it would be reasonable to give gradleMax a default value in the constructor here. Or to have the loop body say max: _maxKnownAndSupportedGradleVersion instead of max: data.gradleMax, and just not have a gradleMax field in the class.

Then this list can get a lot more compact, which I think will make it easier to scan through and spot patterns or possible problems in:

Suggested change

JavaGradleCompat(

javaMin: '19',

javaMax: '20',

gradleMin: '7.6',

gradleMax: _maxKnownAndSupportedGradleVersion,

),

JavaGradleCompat(

javaMin: '18',

javaMax: '19',

gradleMin: '7.5',

gradleMax: _maxKnownAndSupportedGradleVersion,

),

JavaGradleCompat(javaMin: '19', javaMax: '20', gradleMin: '7.6'),

JavaGradleCompat(javaMin: '18', javaMax: '19', gradleMin: '7.5'),

gnprice · 2023-04-05T18:06:45Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

+    JavaGradleCompat(
+      javaMin: '1.8',
+      javaMax: '1.9',
+      gradleMin: '2.0',
+      gradleMax: _maxKnownAndSupportedGradleVersion,
+    ),
+  ];
+  for (final JavaGradleCompat data in compatList) {
+    if (isWithinVersionRange(javaV, min: data.javaMin, max: data.javaMax, inclusiveMax: false)) {
+      return isWithinVersionRange(gradleV, min: data.gradleMin, max: data.gradleMax);


It looks like this class exists only for the sake of this list. So you could also skip having the class definition at all, and use the spiffy new Dart "records" feature:

Suggested change

JavaGradleCompat(

javaMin: '1.8',

javaMax: '1.9',

gradleMin: '2.0',

gradleMax: _maxKnownAndSupportedGradleVersion,

),

];

for (final JavaGradleCompat data in compatList) {

if (isWithinVersionRange(javaV, min: data.javaMin, max: data.javaMax, inclusiveMax: false)) {

return isWithinVersionRange(gradleV, min: data.gradleMin, max: data.gradleMax);

{javaMin: '1.8', javaMax: '1.9', gradleMin: '2.0'},

];

for (final {:javaMin, :javaMax, :gradleMin} in compatList) {

if (isWithinVersionRange(javaV, min: javaMin, max: javaMax, inclusiveMax: false)) {

return isWithinVersionRange(gradleV, min: gradleMin, max: _maxKnownAndSupportedGradleVersion);

I think that would be quite clean, because it makes these records purely local to this loop — it avoids any worry about whether leaving out a gradleMax makes the class too specific for its name, or for hypothetical other ways one might use such a class.

gnprice · 2023-04-05T18:10:52Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

+    // Version can have 2 or 3 numbers.
+    // 'distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip'
+    final RegExp distributionUrlRegex =
+        RegExp(r'distributionUrl\s?=\s?.*\.zip');


Suggested change

RegExp(r'distributionUrl\s?=\s?.*\.zip');

RegExp(r'^\s*distributionUrl\s?=\s?.*\.zip');

That way this avoids matching a commented-out line.

gnprice · 2023-04-05T18:14:57Z

packages/flutter_tools/lib/src/android/gradle_utils.dart

+  if (isWithinVersionRange(agpV,
+      min: '4.0.0', max: '4.1.0', inclusiveMax: false)) {
+    return isWithinVersionRange(gradleV,
+        min: '6.1.1', max: _maxKnownAndSupportedGradleVersion);
+  }
+  if (isWithinVersionRange(
+    agpV,
+    min: '3.6.0',
+    max: '3.6.4',
+  )) {
+    return isWithinVersionRange(gradleV,
+        min: '5.6.4', max: _maxKnownAndSupportedGradleVersion);
+  }


This could benefit from the same loop-through-a-list treatment as in getGradleVersionFor.

reidbaker · 2023-04-05T18:35:57Z

Frob is having issues and the branch cut is today. Merging to get this in prior.

reidbaker · 2023-04-05T18:38:29Z

@gnprice sorry I missed your comments I merged on a non refreshed tab. Will handle them in a follow up pr

gnprice · 2023-04-05T18:52:03Z

@gnprice sorry I missed your comments I merged on a non refreshed tab. Will handle them in a follow up pr

No problem. I've certainly encountered that GitHub issue myself.

…utter#123916)

#123917 Missed feedback from #123916 - Handle commented out lines in gradle-wrapper.properties This is 1 of 2 prs to handle missed feedback. Formatting will be done in the second whereas this one captures a weakness missed in the last pr. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.

flutter#123917 Doc covering a broad set of issues related to android studio updating. https://docs.google.com/document/d/1hTXkjbUrBnXgu8NQsth1c3aEqo77rWoEj8CcsQ39wwQ/edit?pli=1# Specifically this pr: - Adds new functions to find a projects AGP, Gradle and java versions, and tests. - Adds new functions that take versions and parse if the versions are compatible with each other, and tests. - Adds validator for `flutter analyze --suggestions` that evaluates the java/gradle/agp versions and checks if they are compatible, and integration test. - Updates the version of gradle used by dev/integration_tests/flutter_gallery/ to the minimum supported by java 18 so that the integration tests pass (It is unknown why the java version is 18.9 instead of 11) - Moves `isWithinVersionRange` to version.dart, and tests. - Adds FakeAndroidStudio to fakes to be used in multiple tests but does not remove existing copies. Metrics will be included as part of the definition of done for this bug but not as part of this cl. It is already too big. Known work still left in this pr: * Understand why analyze integration tests are failing. Example output if Java and gradle are not compatible: ``` ┌───────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information. │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └───────────────────────────────────────────────────────────────────┘ ``` Example output if Gradle and AGP are not compatible ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Example output if Java/Gradle/Agp are not compatible. ``` ┌─────────────────────────────────────────────────────────────────────────────┐ │ General Info │ │ [✓] App Name: espresso_example │ │ [✓] Supported Platforms: android │ │ [✓] Is Flutter Package: yes │ │ [✓] Uses Material Design: yes │ │ [✓] Is Plugin: no │ │ [✗] Java/Gradle/Android Gradle Plugin: Incompatible Gradle/AGP versions. │ │ │ │ Gradle Version: 7.0.2, AGP Version: 7.4.2 │ │ │ │ Update gradle to at least "7.5". │ │ See the link below for more information: │ │ https://developer.android.com/studio/releases/gradle-plugin#updating-gradle │ │ │ │ Incompatible Java/Gradle versions. │ │ │ │ Java Version: 17.0.6, Gradle Version: 7.0.2 │ │ │ │ See the link below for more information: │ │ https://docs.gradle.org/current/userguide/compatibility.html#java │ │ │ └─────────────────────────────────────────────────────────────────────────────┘ ``` Commit messages - Add function to gradle_utils.dart that gets the gradle version from wrapper or system and add a test for each situation - Add method to get agp version, add method to validate agp against gradle version, update documentation, add tests for agp validation. - Update dart doc for validateGradleAndAgp to describe where the info came from and corner case behavior, create function to validate java and gradle and hardcode return to false - Fill out and test java gradle compatibility function in gradle_utils - Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with hardcoded java version - Add java --version output parsing and tests - Add getJavaBinary test - Update comment in android_sdk for mac behavior with java_home -v ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] All existing and new tests are passing.

flutter#123917 Missed feedback from flutter#123916 - Handle commented out lines in gradle-wrapper.properties This is 1 of 2 prs to handle missed feedback. Formatting will be done in the second whereas this one captures a weakness missed in the last pr. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] All existing and new tests are passing.

…utter#123916)

amorenew · 2023-05-12T20:22:22Z

@reidbaker Your document allows anyone as an editor, it is better to make it view only

reidbaker · 2023-05-12T20:38:53Z

@reidbaker Your document allows anyone as an editor, it is better to make it view only

Thanks I think I had it set to comment access only but now it is view only.

reidbaker added 12 commits March 23, 2023 18:10

Add function to gradle_utils.dart that gets the gradle version from w…

a07f7ee

…rapper or system and add a test for each situation

Add validator that alwasys returns false and test, plus todo in integ…

7b4f418

…ration test

Update documentation, add constants in gradle_utils.dart

2b95eb5

Add method to get agp version, add method to validate agp against gra…

477734e

…dle version, update documenation, add tests for agp validation.

Add task to projects evaluated by flutter.gradle that will print the …

5a8005a

…java version.

Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…

e05aa96

…lilty

Update dart doc for validateGradleAndAgp to describe where the info c…

53e89a0

…ame from and corner case behavior, create function to validate java and gradle and hardcode return to false

Fill out and test java gradle compatability function in gradle_utils

af3c647

Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with…

7e643a6

… hardcoded java version

Add java --version output parsing and tests

6b4ed1b

Add getJavaBinary test

96cae3d

Update comment in android_sdk for mac behavior with java_home -v

5e08847

flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 1, 2023

reidbaker added 2 commits March 31, 2023 21:34

Update format of group java/gradle/agp tests to have one test per pai…

b263dfc

…r of data

Handle mid java values

1a5e9e1

reidbaker commented Apr 1, 2023

View reviewed changes

packages/flutter_tools/lib/src/android/gradle_utils.dart Show resolved Hide resolved

reidbaker commented Apr 1, 2023

View reviewed changes

packages/flutter_tools/lib/src/android/gradle_utils.dart Show resolved Hide resolved

reidbaker commented Apr 1, 2023

View reviewed changes

reidbaker added 4 commits March 31, 2023 22:14

pre review feedback and cleanup of todos

4749a95

Undo formatting

fff074e

Undo formatting 2

2df3691

Add fake AndroidStudio and more formatting fixes

3815b0c

reidbaker mentioned this pull request Apr 1, 2023

Migration to Gradle 7.3+, for compatibility with the JDK 17 in Android Studio Flamingo #122376

Closed

reidbaker requested review from christopherfujino, gmackall and camsim99 April 1, 2023 02:58

reidbaker added 4 commits March 31, 2023 23:04

remove hardcoded values

21b8887

make getJavaVersion callable

87ea610

Undo accidental revert of project.dart using java version

7bc2f4b

Add validator to list

565dd58

bartekpacia reviewed Apr 4, 2023

View reviewed changes

reidbaker added 6 commits April 4, 2023 18:59

formatting and dart docs

ae705bf

Handle newer patch versions of java and gradle and add test to cover

6e69b85

dart docs and formatting

da7b866

spelling fix

e0572ac

Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…

3165cbf

…lilty

Make test value final

deb320f

reidbaker mentioned this pull request Apr 5, 2023

[Android] Catch and rethrow Java/Gradle incompatibility error #124084

Merged

8 tasks

gnprice mentioned this pull request Apr 5, 2023

Add migrator to upgrade gradle version when conflict with Android Studio bundled Java version is detected #124085

Merged

8 tasks

gnprice reviewed Apr 5, 2023

View reviewed changes

reidbaker merged commit 2383400 into flutter:master Apr 5, 2023

reidbaker deleted the i122376-warn-on-gradle-java-AGP-incompatiblilty branch April 5, 2023 18:37

reidbaker mentioned this pull request Apr 5, 2023

Update getGradleVersion to ignore commented out lines #124260

Merged

8 tasks

reidbaker requested a review from zanderso April 5, 2023 19:31

reidbaker mentioned this pull request Apr 5, 2023

Normalize Java SDK (JDK) location logic across the tool #124233

Merged

8 tasks

engine-flutter-autoroll mentioned this pull request Apr 6, 2023

Roll Flutter from daaa32bc0638 to a086c640dcc4 (27 revisions) flutter/packages#3654

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 6, 2023

2383400 Add Java-Gradle-AGP validation to flutter analyze (flutter/fl…

ca4af00

…utter#123916)

navaronbracke mentioned this pull request Apr 7, 2023

Add validation of Java Gradle and AGP version compatibility to flutter analyze --suggestions #123917

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

2383400 Add Java-Gradle-AGP validation to flutter analyze (flutter/fl…

ce588cf

…utter#123916)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 10, 2023

2383400 Add Java-Gradle-AGP validation to flutter analyze (flutter/fl…

1f86410

…utter#123916)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Java-Gradle-AGP validation to flutter analyze #123916

Add Java-Gradle-AGP validation to flutter analyze #123916

reidbaker commented Apr 1, 2023 •

edited

Loading

reidbaker Apr 1, 2023

bartekpacia Apr 4, 2023

reidbaker Apr 4, 2023

bartekpacia Apr 4, 2023

reidbaker Apr 4, 2023

bartekpacia Apr 4, 2023

reidbaker Apr 4, 2023

bartekpacia Apr 4, 2023 •

edited

Loading

reidbaker Apr 4, 2023

bartekpacia Apr 4, 2023

reidbaker Apr 4, 2023

bartekpacia Apr 4, 2023

reidbaker Apr 4, 2023

gnprice Apr 5, 2023

bartekpacia Apr 4, 2023

reidbaker Apr 4, 2023

gnprice Apr 5, 2023

gnprice Apr 5, 2023

gnprice Apr 5, 2023

gnprice Apr 5, 2023

reidbaker commented Apr 5, 2023

reidbaker commented Apr 5, 2023

gnprice commented Apr 5, 2023 •

edited

Loading

amorenew commented May 12, 2023 •

edited

Loading

reidbaker commented May 12, 2023

		// Returns the version of java in the format \d(.\d)+(.\d)+
		// Returns null if version not found.

	globals.printTrace('Using path java.');
	globals.printTrace('Using java from PATH.');

	Update gradle to at least "${gradle.getGradleVersionFor(agpVersion!)}".\n
	Update Gradle to at least "${gradle.getGradleVersionFor(agpVersion!)}".\n

	RegExp(r'distributionUrl\s?=\s?.*\.zip');
	RegExp(r'^\sdistributionUrl\s?=\s?.\.zip');

Add Java-Gradle-AGP validation to flutter analyze #123916

Add Java-Gradle-AGP validation to flutter analyze #123916

Conversation

reidbaker commented Apr 1, 2023 • edited Loading

Pre-launch Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bartekpacia Apr 4, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reidbaker commented Apr 5, 2023

reidbaker commented Apr 5, 2023

gnprice commented Apr 5, 2023 • edited Loading

amorenew commented May 12, 2023 • edited Loading

reidbaker commented May 12, 2023

reidbaker commented Apr 1, 2023 •

edited

Loading

bartekpacia Apr 4, 2023 •

edited

Loading

gnprice commented Apr 5, 2023 •

edited

Loading

amorenew commented May 12, 2023 •

edited

Loading