Fix iOS touch drag behavior #125169

Renzo-Olivares · 2023-04-19T22:39:27Z

Before this change on a quick touch drag the cursor, where the touch is not on the previous collapsed selection, the cursor would move to the tapped position.

After this change on a quick touch drag the cursor does not move unless the touch is on the previously collapsed selection. This is inline with native behavior.

Before	After	Native
fixed.mov	Screen.Recording.2023-04-19.at.4.59.31.PM.mov	native.mov

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

justinmc

LGTM 👍

justinmc · 2023-04-20T21:00:01Z

packages/flutter/lib/src/widgets/text_selection.dart

+                  from: details.globalPosition,
+                  cause: SelectionChangedCause.drag,
+                );
+                _showMagnifierIfSupportedByPlatform(details.globalPosition);


Why didn't the magnifier show up in the video in your description?

I took the videos before the magnifier was merged in, it works though.

Ok cool 👍

justinmc · 2023-04-20T21:00:51Z

packages/flutter/lib/src/widgets/text_selection.dart

@@ -2572,6 +2572,7 @@ class TextSelectionGestureDetectorBuilder {
    _dragStartSelection = renderEditable.selection;
    _dragStartScrollOffset = _scrollPosition;
    _dragStartViewportOffset = renderEditable.offset.pixels;
+    _dragBeganOnPreviousSelection ??= _positionOnSelection(details.globalPosition, _dragStartSelection);


Do you still need the ?? even though this is now in the Start handler?

Good point i'll remove it.

auto-submit · 2023-04-21T00:13:07Z

auto label is removed for flutter/flutter, pr: 125169, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Renzo-Olivares · 2023-04-21T20:45:24Z

This PR is failing test because _showMagnifierIfSupportedByPlatform and its hide variant have not been merged into g3 yet. I'll re-run tests and merge once that happens.

Roll Flutter from c9004ff to 66fa4c5 (68 revisions) flutter/flutter@c9004ff...66fa4c5 2023-04-26 zanderso@users.noreply.github.com Remove web compile benchmarks that specify an attached device (flutter/flutter#125559) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from f75908135e10 to f125a54f5a57 (1 revision) (flutter/flutter#125560) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from c9db1587f207 to f75908135e10 (1 revision) (flutter/flutter#125558) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 58a5a1e3f2c1 to c9db1587f207 (1 revision) (flutter/flutter#125555) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 321f8015b9c2 to 58a5a1e3f2c1 (1 revision) (flutter/flutter#125552) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 87f5f4e939cf to 321f8015b9c2 (1 revision) (flutter/flutter#125549) 2023-04-26 goderbauer@google.com Update prefer_final_parameters comment (flutter/flutter#125465) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 706c023df44b to 87f5f4e939cf (1 revision) (flutter/flutter#125539) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7b385abd18a2 to 706c023df44b (1 revision) (flutter/flutter#125536) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 610c57781b47 to 7b385abd18a2 (1 revision) (flutter/flutter#125533) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from b3cbf0678487 to 610c57781b47 (1 revision) (flutter/flutter#125531) 2023-04-26 zanderso@users.noreply.github.com Add hostonly web compile size benchmarks (flutter/flutter#125518) 2023-04-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 34ece7a4abac to b3cbf0678487 (6 revisions) (flutter/flutter#125529) 2023-04-25 thkim1011@users.noreply.github.com Handle dollar signs properly when generating localizations (flutter/flutter#125514) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 6d798393a15a to 34ece7a4abac (1 revision) (flutter/flutter#125516) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 469e5b409686 to 6d798393a15a (2 revisions) (flutter/flutter#125513) 2023-04-25 47866232+chunhtai@users.noreply.github.com Adds selected semantics flag to radio button for Apple devices (flutter/flutter#125499) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 0e236982086b to 469e5b409686 (1 revision) (flutter/flutter#125510) 2023-04-25 58529443+srujzs@users.noreply.github.com Relabel JSFunction as JSExportedDartFunction (flutter/flutter#125453) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 60c4e61416cd to 0e236982086b (2 revisions) (flutter/flutter#125504) 2023-04-25 jmccandless@google.com iOS TextField spell check style (flutter/flutter#125432) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 308bce499087 to 60c4e61416cd (1 revision) (flutter/flutter#125490) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 54ddef68b124 to 308bce499087 (1 revision) (flutter/flutter#125485) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 307416f43b5a to 54ddef68b124 (1 revision) (flutter/flutter#125481) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 232810b36671 to 307416f43b5a (1 revision) (flutter/flutter#125475) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1c4b6c0cb862 to 232810b36671 (2 revisions) (flutter/flutter#125472) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from a26a479e86b3 to 1c4b6c0cb862 (1 revision) (flutter/flutter#125463) 2023-04-25 tessertaha@gmail.com Fix `SliverAppBar.medium` & `SliverAppBar.large` text scale (flutter/flutter#125038) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f4116c225e8 to a26a479e86b3 (1 revision) (flutter/flutter#125459) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 64882f4b7371 to 3f4116c225e8 (2 revisions) (flutter/flutter#125458) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8fe8e94c02fc to 64882f4b7371 (1 revision) (flutter/flutter#125454) 2023-04-25 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5fbde6c0fc57 to 8fe8e94c02fc (10 revisions) (flutter/flutter#125452) 2023-04-24 tessertaha@gmail.com Add Sliders to `macrobenchmarks` (flutter/flutter#125296) 2023-04-24 pateltirth454@gmail.com [date_picker] [date_range_picker] add properties to change switch-to icons (flutter/flutter#124881) 2023-04-24 thkim1011@users.noreply.github.com Sliver Constrained Cross Axis (flutter/flutter#125239) 2023-04-24 kevmoo@users.noreply.github.com tool: Move cdKey to CustomDimensionsEnum (flutter/flutter#125335) 2023-04-24 bernaferrari2@gmail.com Add `borderRadius` to LinearProgressIndicator (flutter/flutter#123517) 2023-04-24 58529443+srujzs@users.noreply.github.com Fix JS types in _test_http_request.dart (flutter/flutter#125220) 2023-04-24 tessertaha@gmail.com Fix `OutlinedButton`, `TextButton`, and `IconButton` throw exception when passing only one cursor to `styleFrom` (flutter/flutter#125204) 2023-04-24 magder@google.com Swap some iOS TESTOWNERS (flutter/flutter#125340) 2023-04-24 rmolivares@renzo-olivares.dev Fix iOS touch drag behavior (flutter/flutter#125169) 2023-04-24 54558023+keyonghan@users.noreply.github.com Mark module_test_ios flaky (flutter/flutter#125426) 2023-04-24 47866232+chunhtai@users.noreply.github.com Implement url support for RouteInformation and didPushRouteInformation (flutter/flutter#119968) 2023-04-24 kevmoo@users.noreply.github.com [tool,web] Include more info URI on Wasm init failure (flutter/flutter#125312) 2023-04-24 magder@google.com Do not run `windows_home_scroll_perf__timeline_summary` benchmark in presubmit (flutter/flutter#125343) 2023-04-24 5236035+fzyzcjy@users.noreply.github.com Tiny fix doc pointing to incorrect widget confusing the readers (flutter/flutter#125394) ...

flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 19, 2023

Renzo-Olivares marked this pull request as ready for review April 19, 2023 23:29

Renzo-Olivares requested a review from justinmc April 19, 2023 23:29

flutter-dashboard bot added the f: cupertino flutter/packages/flutter/cupertino repository label Apr 20, 2023

Renzo-Olivares force-pushed the fix-ios-drag-start branch 4 times, most recently from 5c5f317 to 80692d8 Compare April 20, 2023 20:21

justinmc approved these changes Apr 20, 2023

View reviewed changes

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 20, 2023

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 21, 2023

Renzo-Olivares added 5 commits April 24, 2023 09:59

Prevent cursor from moving on a quick touch drag

8ee6546

Add test

16a9347

add cupertino tests

1526f21

updates

2069f24

Address comments

6e08f76

Renzo-Olivares force-pushed the fix-ios-drag-start branch from 1a8bc4f to 6e08f76 Compare April 24, 2023 16:59

Renzo-Olivares added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2023

auto-submit bot merged commit 1a51dc2 into flutter:master Apr 24, 2023

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 932faedce2f8 (93 revisions) flutter/packages#3813

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

1a51dc2 Fix iOS touch drag behavior (flutter/flutter#125169)

67351df

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from 3476b966524f to 8cd11e91fb7d (94 revisions) flutter/packages#3815

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

1a51dc2 Fix iOS touch drag behavior (flutter/flutter#125169)

6ae78d3

engine-flutter-autoroll mentioned this pull request Apr 25, 2023

Roll Flutter from c9004ff822cf to 8cd11e91fb7d (47 revisions) flutter/packages#3817

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2023

1a51dc2 Fix iOS touch drag behavior (flutter/flutter#125169)

d593f22

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to b0ae2e81bab5 (66 revisions) flutter/packages#3827

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

1a51dc2 Fix iOS touch drag behavior (flutter/flutter#125169)

9f31fd3

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to c9d7bed4216b (67 revisions) flutter/packages#3829

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

1a51dc2 Fix iOS touch drag behavior (flutter/flutter#125169)

a35496d

engine-flutter-autoroll mentioned this pull request Apr 26, 2023

Roll Flutter from c9004ff822cf to 66fa4c5d301c (68 revisions) flutter/packages#3830

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 26, 2023

1a51dc2 Fix iOS touch drag behavior (flutter/flutter#125169)

f7be469

HansMuller mentioned this pull request Apr 28, 2023

Flutter Framework Team: Notable Commits #121415

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix iOS touch drag behavior #125169

Fix iOS touch drag behavior #125169

Renzo-Olivares commented Apr 19, 2023 •

edited

Loading

justinmc left a comment

justinmc Apr 20, 2023

Renzo-Olivares Apr 20, 2023

justinmc Apr 20, 2023

justinmc Apr 20, 2023

Renzo-Olivares Apr 20, 2023

auto-submit bot commented Apr 21, 2023

Renzo-Olivares commented Apr 21, 2023 •

edited

Loading

Fix iOS touch drag behavior #125169

Fix iOS touch drag behavior #125169

Conversation

Renzo-Olivares commented Apr 19, 2023 • edited Loading

Pre-launch Checklist

justinmc left a comment

Choose a reason for hiding this comment

justinmc Apr 20, 2023

Choose a reason for hiding this comment

Renzo-Olivares Apr 20, 2023

Choose a reason for hiding this comment

justinmc Apr 20, 2023

Choose a reason for hiding this comment

justinmc Apr 20, 2023

Choose a reason for hiding this comment

Renzo-Olivares Apr 20, 2023

Choose a reason for hiding this comment

auto-submit bot commented Apr 21, 2023

Renzo-Olivares commented Apr 21, 2023 • edited Loading

Renzo-Olivares commented Apr 19, 2023 •

edited

Loading

Renzo-Olivares commented Apr 21, 2023 •

edited

Loading