Skip to content

Add debugging for iOS startup test flakes #130099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2023
Merged

Add debugging for iOS startup test flakes #130099

merged 1 commit into from
Jul 7, 2023

Conversation

@vashworth
Copy link
Contributor

@vashworth vashworth commented Jul 6, 2023 •
edited
Loading

Adding debugging for #129836.

Takes a screenshot when startup test takes too long (10 minutes).

Also, removes some old debugging and add new debugging message.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Jul 6, 2023
vashworth
vashworth commented Jul 6, 2023
View reviewed changes
dev/devicelab/lib/tasks/perf_tests.dart
// Startup should not take more than a few minutes. After 10 minutes,
// take a screenshot to help debug.
final Timer timer = Timer(const Duration(minutes: 10), () async {
print('Startup not completed within 10 minutes. Taking a screenshot...');
Copy link
Contributor Author

@vashworth vashworth Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10 minutes is basically just an arbitrary time I picked. Our CI times out at 30 minutes, and it can retest up to 3 times when it fails. Typically, it looks like it usually takes under 3 minutes.

Copy link
Contributor

@christopherfujino christopherfujino Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also log the filename? or is this gonna be obvious from the LUCI build output?

Copy link
Contributor Author

@vashworth vashworth Jul 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gets logged by the screenshot command. It'll print something like

[STDOUT] stdout: Screenshot written to /path/to/screenshot_startup_2023-07-06T16:38:37.674817.png (683kB).

@vashworth vashworth marked this pull request as ready for review July 6, 2023 22:20
christopherfujino
christopherfujino approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vashworth vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 7, 2023
@auto-submit auto-submit bot merged commit 6683468 into flutter:master Jul 7, 2023
@vashworth vashworth mentioned this pull request Jul 7, 2023
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2023
@engine-flutter-autoroll
6683468 Add debugging for iOS startup test flakes (flutter/flutter#13…
6751747 
…0099)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 8, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 8, 2023
@engine-flutter-autoroll
6683468 Add debugging for iOS startup test flakes (flutter/flutter#13…
317503c 
…0099)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 8, 2023
@engine-flutter-autoroll
Roll Flutter from d55a7d8 to 65ff3cb (21 revisions) (#4413)
4469c5e 
flutter/flutter@d55a7d8...65ff3cb

2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 69eb8275ce47 to 189f823e7b41 (1 revision) (flutter/flutter#130201)
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from d5a35b4650b1 to 69eb8275ce47 (1 revision) (flutter/flutter#130199)
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9006633571bb to d5a35b4650b1 (1 revision) (flutter/flutter#130197)
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4ca619166c4a to 9006633571bb (2 revisions) (flutter/flutter#130195)
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 13d9d84e8aba to 4ca619166c4a (2 revisions) (flutter/flutter#130191)
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 40a8732a5de0 to 13d9d84e8aba (2 revisions) (flutter/flutter#130189)
2023-07-08 cychiang0823@gmail.com fix: duplicated Intellij IDE message when running flutter doctor (flutter/flutter#129030)
2023-07-08 32242716+ricardoamador@users.noreply.github.com Remove unneeded configuration file  (flutter/flutter#130183)
2023-07-08 engine-flutter-autoroll@skia.org Roll Flutter Engine from 893ab3bf7bb9 to 40a8732a5de0 (1 revision) (flutter/flutter#130186)
2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b39e6fe4b3bf to 893ab3bf7bb9 (1 revision) (flutter/flutter#130180)
2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 7c83ea3e8542 to b39e6fe4b3bf (1 revision) (flutter/flutter#130176)
2023-07-07 jhy03261997@gmail.com Add a threshold when comparing screen order for selectables. (flutter/flutter#130043)
2023-07-07 aam@google.com Upgrade framework pub dependencies, roll engine with rolled dart sdk (flutter/flutter#130163)
2023-07-07 jesus_sguerrero@hotmail.com Revert "[a11y] CupertinoSwitch On/Off labels" (flutter/flutter#130166)
2023-07-07 polinach@google.com Test that inspector does not hold objects. (flutter/flutter#130102)
2023-07-07 caiquer.eds@gmail.com Fix XCode download link (flutter/flutter#129795)
2023-07-07 engine-flutter-autoroll@skia.org Roll Packages from 9bcf4bf to b61eea1 (1 revision) (flutter/flutter#130154)
2023-07-07 cbobbe@zulip.com (Raw)Autocomplete: Add optional [optionsViewOpenDirection] param (flutter/flutter#129802)
2023-07-07 5236035+fzyzcjy@users.noreply.github.com Tiny one space formatting fix (flutter/flutter#130053)
2023-07-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 8aa2e6516af1 to 5ae09b8b4fa3 (7 revisions) (flutter/flutter#130150)
2023-07-07 15619084+vashworth@users.noreply.github.com Add debugging for iOS startup test flakes (flutter/flutter#130099)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vashworth @christopherfujino