Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied the logo to the Discord badge. #134339

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Applied the logo to the Discord badge. #134339

merged 1 commit into from
Sep 15, 2023

Conversation

K9i-0
Copy link
Contributor

@K9i-0 K9i-0 commented Sep 9, 2023

Before
image

After

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

goderbauer
goderbauer approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023
@auto-submit
Copy link
Contributor

auto-submit bot commented Sep 11, 2023

auto label is removed for flutter/flutter/134339, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.

  • Merge guidelines: You need at least one approved review if you are already part of flutter-hackers or two member reviews if you are not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2023
@AlexV525 AlexV525 added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 15, 2023
@auto-submit auto-submit bot merged commit 0b540a8 into flutter:master Sep 15, 2023
31 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
0b540a8 Applied the logo to the Discord badge. (flutter/flutter#134339)
6fe81d8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
0b540a8 Applied the logo to the Discord badge. (flutter/flutter#134339)
0d4f04b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 15, 2023
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
0b540a8 Applied the logo to the Discord badge. (flutter/flutter#134339)
0a93bae
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Sep 15, 2023
@engine-flutter-autoroll
Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (#4934)
f194f59 
flutter/flutter@58ba6c2...72b69f9

2023-09-15 polinach@google.com Date picker dialog state should dispose members. (flutter/flutter#134804)
2023-09-15 engine-flutter-autoroll@skia.org Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823)
2023-09-15 leroux_bruno@yahoo.fr Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815)
2023-09-15 k_hayashi@yumemi.co.jp Applied the logo to the Discord badge. (flutter/flutter#134339)
2023-09-15 sokolovskyi.konstantin@gmail.com Fix memory leak in ListWheelScrollView (flutter/flutter#134732)
2023-09-15 zanderso@users.noreply.github.com Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789)
2023-09-14 pavel.mazhnik@gmail.com [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769)
2023-09-14 47866232+chunhtai@users.noreply.github.com Allows page removal that contains Localhistoryentry (flutter/flutter#134757)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763)
2023-09-14 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking #3 (flutter/flutter#134576)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755)
2023-09-14 15619084+vashworth@users.noreply.github.com Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693)
2023-09-14 82763757+NobodyForNothing@users.noreply.github.com Cover some Services tests with leak tracing (flutter/flutter#134381)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749)
2023-09-14 github@alexv525.com � Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492)
2023-09-14 leroux_bruno@yahoo.fr Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695)
2023-09-14 30870216+gaaclarke@users.noreply.github.com Added a devicelab test for vulkan validation layers (flutter/flutter#134685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@K9i-0 @Mairramer
Applied the logo to the Discord badge. (flutter#134339)
7cded56 
Before
<img width="414" alt="image" src="https://github.com/flutter/flutter/assets/90010509/af386804-a8a2-43b9-a7fd-6e79df400734">

After

<img width="412" alt="image" src="https://github.com/flutter/flutter/assets/90010509/5e289946-7690-414a-8ff0-9abeb861842b">
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
0b540a8 Applied the logo to the Discord badge. (flutter/flutter#134339)
7ef27f4
HugoOlthof pushed a commit to moneybird/packages that referenced this pull request Dec 13, 2023
@engine-flutter-autoroll @HugoOlthof
Roll Flutter from 58ba6c2 to 72b69f9 (21 revisions) (flutter#4934)
911e540 
flutter/flutter@58ba6c2...72b69f9

2023-09-15 polinach@google.com Date picker dialog state should dispose members. (flutter/flutter#134804)
2023-09-15 engine-flutter-autoroll@skia.org Roll Packages from 275b76c to bc8c2f2 (7 revisions) (flutter/flutter#134823)
2023-09-15 leroux_bruno@yahoo.fr Fix navigation rail hover misplaced when direction is RTL and extended is true (flutter/flutter#134815)
2023-09-15 k_hayashi@yumemi.co.jp Applied the logo to the Discord badge. (flutter/flutter#134339)
2023-09-15 sokolovskyi.konstantin@gmail.com Fix memory leak in ListWheelScrollView (flutter/flutter#134732)
2023-09-15 zanderso@users.noreply.github.com Move two tests on Pixel 7 from staging to prod (flutter/flutter#134784)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 683bca53d4d7 to 45bc4307cda3 (2 revisions) (flutter/flutter#134789)
2023-09-14 pavel.mazhnik@gmail.com [web] provide serviceWorkerVersion to the getNewServiceWorker function (flutter/flutter#131240)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3a3a2807c3b6 to 683bca53d4d7 (3 revisions) (flutter/flutter#134778)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 035932d64017 to 3a3a2807c3b6 (5 revisions) (flutter/flutter#134769)
2023-09-14 47866232+chunhtai@users.noreply.github.com Allows page removal that contains Localhistoryentry (flutter/flutter#134757)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from e0b5b6c4eb76 to 035932d64017 (2 revisions) (flutter/flutter#134763)
2023-09-14 sokolovskyi.konstantin@gmail.com Cover more test/widgets tests with leak tracking flutter#3 (flutter/flutter#134576)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 2cd34d23c1a2 to e0b5b6c4eb76 (2 revisions) (flutter/flutter#134755)
2023-09-14 15619084+vashworth@users.noreply.github.com Set xcode version to older compatible version for microbenchmarks_ios_xcode_debug test (flutter/flutter#134693)
2023-09-14 82763757+NobodyForNothing@users.noreply.github.com Cover some Services tests with leak tracing (flutter/flutter#134381)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4160ebacdae2 to 2cd34d23c1a2 (18 revisions) (flutter/flutter#134749)
2023-09-14 github@alexv525.com � Setup color tween for `RefreshIndicator` in a better way (flutter/flutter#134492)
2023-09-14 leroux_bruno@yahoo.fr Fix NavigationRail hover misplaced when using large icons (flutter/flutter#134719)
2023-09-14 engine-flutter-autoroll@skia.org Roll Flutter Engine from cd90cc8469fb to 4160ebacdae2 (5 revisions) (flutter/flutter#134695)
2023-09-14 30870216+gaaclarke@users.noreply.github.com Added a devicelab test for vulkan validation layers (flutter/flutter#134685)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC camillesimon@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 approved these changes

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@K9i-0 @goderbauer @AlexV525