Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix _paintAvatar in chip.dart to dispose layer. [prod-leak-fix] #135228

Merged
merged 19 commits into from
Sep 22, 2023
Merged

Fix _paintAvatar in chip.dart to dispose layer. [prod-leak-fix] #135228

merged 19 commits into from
Sep 22, 2023

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c commented Sep 21, 2023 •
edited
Loading

Similar PR: #134708

@polina-c polina-c added the a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker label Sep 21, 2023
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 21, 2023
@polina-c polina-c mentioned this pull request Sep 21, 2023
Merged
@polina-c polina-c mentioned this pull request Sep 21, 2023
Closed
@polina-c polina-c marked this pull request as ready for review September 22, 2023 21:20
@polina-c polina-c requested a review from goderbauer September 22, 2023 21:20
goderbauer
goderbauer approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@polina-c polina-c merged commit c00e979 into flutter:master Sep 22, 2023
65 checks passed
@polina-c polina-c deleted the _RenderChip1 branch September 22, 2023 22:27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 25, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 25, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
bb107f6 
…ter#135228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
de1eb88 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
28be035 
…ter#135228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
6f1dca1 
…ter#135228)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 26, 2023
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
8948c0d 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 26, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
990f2bb 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
fac1313 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
0ce06b5 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
f076594 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
7fe02f1 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 27, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
66150e1 
…ter#135228)
@HansMuller HansMuller mentioned this pull request Sep 28, 2023
Open
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
3777f5e 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
0dafa72 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
fdc11ee 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
5a8ea23 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
5310523 
…ter#135228)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 28, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
3434292 
…ter#135228)
Mairramer pushed a commit to Mairramer/flutter that referenced this pull request Oct 10, 2023
@polina-c @Mairramer
Fix _paintAvatar in chip.dart to dispose layer. (flutter#135228)
707fccc
@droidbg droidbg mentioned this pull request Oct 14, 2023
Merged
8 tasks
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 15, 2023
@engine-flutter-autoroll
c00e979 Fix _paintAvatar in chip.dart to dispose layer. (flutter/flut…
db1b8d6 
…ter#135228)
@polina-c polina-c changed the title Fix _paintAvatar in chip.dart to dispose layer. Fix _paintAvatar in chip.dart to dispose layer. [prod-leak-fix] Aug 29, 2024
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: leak tracking Issues and PRs related to memory leaks detected by leak_tracker f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@polina-c @goderbauer