-
Notifications
You must be signed in to change notification settings - Fork 28.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change flutter_build_with_compilation_error_test to check stdout or stderr #152404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 1, 2024
Manual roll requested by stuartmorgan@google.com flutter/flutter@031dc3d...4d12197 2024-07-26 andrewrkolos@gmail.com further shard Mac tool_integration_tests from 4 to 5 shards (flutter/flutter#152399) 2024-07-26 magder@google.com Change flutter_build_with_compilation_error_test to check stdout or stderr (flutter/flutter#152404) 2024-07-26 victorsanniay@gmail.com [cupertino/icons.dart] Replace ligature references with characters corresponding to codepoints (flutter/flutter#152387) 2024-07-26 737941+loic-sharma@users.noreply.github.com Update minimum macOS version as needed in Swift package (flutter/flutter#152347) 2024-07-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.14 to 3.25.15 (flutter/flutter#152401) 2024-07-26 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/flutter#152400) 2024-07-26 31859944+LongCatIsLooong@users.noreply.github.com Update text_painter.dart (flutter/flutter#152398) 2024-07-26 737941+loic-sharma@users.noreply.github.com Fix some tests that fail with Swift Package Manager enabled (flutter/flutter#152267) 2024-07-26 bkonyi@google.com Reland "Launch DDS from Dart SDK and prepare to serve DevTools from DDS (#146593)" (flutter/flutter#152386) 2024-07-26 angelosilvestre.ccp@gmail.com Make `DragGestureRecognizer` abstract methods public (flutter/flutter#151627) 2024-07-26 koji.wakamiya@gmail.com Fix cursor position when Unicode Zs category is entered in TextField (flutter/flutter#152215) 2024-07-26 engine-flutter-autoroll@skia.org Roll Flutter Engine from 354abf2800a0 to e28f8755e25b (2 revisions) (flutter/flutter#152388) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…tderr (flutter#152404) On Xcode 16 beta 3 stderr is: ``` ** BUILD FAILED ** ``` stdout is: ``` Writing result bundle at path: /var/folders/fm/wjzsj_z95ydgn4khxqgbtqx000mfq2/T/flutter_tools.PeJZlH/flutter_ios_build_temp_dirqmiKld/temporary_xcresult_bundle error: lib/main.dart:13:11: Error: A value of type 'String' can't be assigned to a variable of type 'int'. int x = 'String'; ^ Target kernel_snapshot_program failed: Exception Failed to package /Users/m/Projects/test_create. note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Runner' from project 'Runner') note: Run script build phase 'Thin Binary' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') note: Run script build phase 'Run Script' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') ``` The tool output of `flutter build ios` shows both: ``` Building com.example.testCreate for device (ios-release)... Automatically signing iOS for device deployment using specified development team in Xcode project: S8QB4VV633 Running Xcode build... Xcode build done. 10.1s Failed to build iOS app Error output from Xcode build: â�³ ** BUILD FAILED ** Xcode's output: â�³ Writing result bundle at path: /var/folders/fm/wjzsj_z95ydgn4khxqgbtqx000mfq2/T/flutter_tools.Dgnlxc/flutt er_ios_build_temp_dirpKTDdk/temporary_xcresult_bundle error: lib/main.dart:13:11: Error: A value of type 'String' can't be assigned to a variable of type 'int'. int x = 'String'; ^ Target kernel_snapshot_program failed: Exception Failed to package /Users/magder/Projects/test_create. note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Runner' from project 'Runner') note: Run script build phase 'Run Script' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') note: Run script build phase 'Thin Binary' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') Encountered error while building for device. ``` The point of this test is that you can see the error `int x = 'String';` error in the tool output. flutter#72608 (comment) I think just updating the test to check stderr or stdout is sufficient without touching the tool behavior. Fixes flutter#151553
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Aug 8, 2024
…tderr (flutter#152404) On Xcode 16 beta 3 stderr is: ``` ** BUILD FAILED ** ``` stdout is: ``` Writing result bundle at path: /var/folders/fm/wjzsj_z95ydgn4khxqgbtqx000mfq2/T/flutter_tools.PeJZlH/flutter_ios_build_temp_dirqmiKld/temporary_xcresult_bundle error: lib/main.dart:13:11: Error: A value of type 'String' can't be assigned to a variable of type 'int'. int x = 'String'; ^ Target kernel_snapshot_program failed: Exception Failed to package /Users/m/Projects/test_create. note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Runner' from project 'Runner') note: Run script build phase 'Thin Binary' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') note: Run script build phase 'Run Script' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') ``` The tool output of `flutter build ios` shows both: ``` Building com.example.testCreate for device (ios-release)... Automatically signing iOS for device deployment using specified development team in Xcode project: S8QB4VV633 Running Xcode build... Xcode build done. 10.1s Failed to build iOS app Error output from Xcode build: â�³ ** BUILD FAILED ** Xcode's output: â�³ Writing result bundle at path: /var/folders/fm/wjzsj_z95ydgn4khxqgbtqx000mfq2/T/flutter_tools.Dgnlxc/flutt er_ios_build_temp_dirpKTDdk/temporary_xcresult_bundle error: lib/main.dart:13:11: Error: A value of type 'String' can't be assigned to a variable of type 'int'. int x = 'String'; ^ Target kernel_snapshot_program failed: Exception Failed to package /Users/magder/Projects/test_create. note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Runner' from project 'Runner') note: Run script build phase 'Run Script' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') note: Run script build phase 'Thin Binary' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') Encountered error while building for device. ``` The point of this test is that you can see the error `int x = 'String';` error in the tool output. flutter#72608 (comment) I think just updating the test to check stderr or stdout is sufficient without touching the tool behavior. Fixes flutter#151553
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…tderr (flutter#152404) On Xcode 16 beta 3 stderr is: ``` ** BUILD FAILED ** ``` stdout is: ``` Writing result bundle at path: /var/folders/fm/wjzsj_z95ydgn4khxqgbtqx000mfq2/T/flutter_tools.PeJZlH/flutter_ios_build_temp_dirqmiKld/temporary_xcresult_bundle error: lib/main.dart:13:11: Error: A value of type 'String' can't be assigned to a variable of type 'int'. int x = 'String'; ^ Target kernel_snapshot_program failed: Exception Failed to package /Users/m/Projects/test_create. note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Runner' from project 'Runner') note: Run script build phase 'Thin Binary' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') note: Run script build phase 'Run Script' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') ``` The tool output of `flutter build ios` shows both: ``` Building com.example.testCreate for device (ios-release)... Automatically signing iOS for device deployment using specified development team in Xcode project: S8QB4VV633 Running Xcode build... Xcode build done. 10.1s Failed to build iOS app Error output from Xcode build: â�³ ** BUILD FAILED ** Xcode's output: â�³ Writing result bundle at path: /var/folders/fm/wjzsj_z95ydgn4khxqgbtqx000mfq2/T/flutter_tools.Dgnlxc/flutt er_ios_build_temp_dirpKTDdk/temporary_xcresult_bundle error: lib/main.dart:13:11: Error: A value of type 'String' can't be assigned to a variable of type 'int'. int x = 'String'; ^ Target kernel_snapshot_program failed: Exception Failed to package /Users/magder/Projects/test_create. note: Disabling previews because SWIFT_VERSION is set and SWIFT_OPTIMIZATION_LEVEL=-O, expected -Onone (in target 'Runner' from project 'Runner') note: Run script build phase 'Run Script' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') note: Run script build phase 'Thin Binary' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'Runner' from project 'Runner') Encountered error while building for device. ``` The point of this test is that you can see the error `int x = 'String';` error in the tool output. flutter#72608 (comment) I think just updating the test to check stderr or stdout is sufficient without touching the tool behavior. Fixes flutter#151553
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
autosubmit
Merge PR when tree becomes green via auto submit App
cp: stable
cherry pick this pull request to stable release candidate branch
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Xcode 16 beta 3 stderr is:
stdout is:
The tool output of
flutter build ios
shows both:The point of this test is that you can see the error
int x = 'String';
error in the tool output. #72608 (comment)I think just updating the test to check stderr or stdout is sufficient without touching the tool behavior.
Fixes #151553
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.