Refactor devfs_web_ddc_modules_test.dart #155609
Merged
+1,334
−1,574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nate-thegrate
added
the
refactor
github-actions
bot
added
the
tool
nate-thegrate
force-pushed
the
testbed
branch
from
588de85
to
88d1c76
Compare
nate-thegrate
force-pushed
the
testbed
branch
from
88d1c76
to
e990a03
Compare
andrewkolos
reviewed
Sep 26, 2024
packages/flutter_tools/test/general.shard/web/devfs_web_ddc_modules_test.dart
Outdated
Show resolved
Hide resolved
andrewkolos
reviewed
Sep 26, 2024
packages/flutter_tools/test/general.shard/web/devfs_web_ddc_modules_test.dart
Outdated
Show resolved
Hide resolved
andrewkolos
reviewed
Sep 26, 2024
packages/flutter_tools/test/general.shard/web/devfs_web_ddc_modules_test.dart
Outdated
Show resolved
Hide resolved
Co-authored-by: Andrew Kolos <andrewrkolos@gmail.com>
nate-thegrate
force-pushed
the
testbed
branch
from
7eb7948
to
d6c4875
Compare
|
Sweet, looks like things are passing! |
andrewkolos
reviewed
Sep 26, 2024
packages/flutter_tools/test/general.shard/web/devfs_web_ddc_modules_test.dart
Show resolved
Hide resolved
andrewkolos
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 4, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a local function
runInTestbed()to devfs_web_ddc_modules_test.dart, which wraps thetestbed.run()method. Several whitespace adjustments have been made as well.It's much easier to read after clicking "hide whitespace".
Relevant style guidelines:
=>when everything, including the function declaration, fits on a single line.