-
Notifications
You must be signed in to change notification settings - Fork 27.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RenderParagraph
should invalidate its _SelectableFragment
s cached rects on window size updates
#155719
RenderParagraph
should invalidate its _SelectableFragment
s cached rects on window size updates
#155719
Conversation
_SelectableFragment
s cached rects on window size change_SelectableFragment
s cached rects on window size updates
_SelectableFragment
s cached rects on window size updatesRenderParagraph
should invalidate its _SelectableFragment
s cached rects on window size updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -809,6 +809,7 @@ class RenderParagraph extends RenderBox with ContainerRenderObjectMixin<RenderBo | |||
|
|||
@override | |||
void performLayout() { | |||
_lastSelectableFragments?.forEach((_SelectableFragment element) => element.didChangeParagraphLayout()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this happen at the end of performLayout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be fine here, since all we do is null
the _cachedRect
. We also call this at the beginning of markNeedsLayout
, but that doesn't catch cases where the window resizes.
await gesture.up(); | ||
await tester.pumpAndSettle(); | ||
}, variant: TargetPlatformVariant.all(), | ||
skip: kIsWeb); // https://github.com/flutter/flutter/issues/125582. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Closing parenthesis on the next line I think?
01eec26
to
de7efe5
Compare
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
…t`s cached rects on window size updates (flutter/flutter#155719)
Fixes #155143
Fixes #120578
Pre-launch Checklist
///
).