Make pressing and moving on CupertinoButton closer to native behavior. #161731

yiiim · 2025-01-16T14:44:43Z

This PR adds an onTapMove event to TapGestureRecognizer, and then CupertinoButton uses this event to implement the behavior of the native iOS UIButton (as shown in the issue). It is worth noting that this PR slightly changes the way CupertinoButton's onPressed is triggered. Specifically, it changes from being triggered by TapGestureRecognizer's onTap to checking if the event position is still above the button in TapGestureRecognizer's onTapUp. Additionally, it removes the previous behavior where the gesture was canceled if moved beyond kScaleSlop (18 logical pixels). Overall, previously, onPressed could not be triggered if the button was pressed and then moved more than 18 pixels. This PR adjusts it so that onPressed cannot be triggered if the button is pressed and then moved outside the button.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…nto cupertion_button_gesture

dkwingsmt · 2025-01-27T09:52:02Z

This is awesome! I'm still reading the code (and it looks great so far) and I have a question: If I understand correctly, only Cupertino uses the tap-move gesture, while other existing code (such as Material) still cancels on movement. How did BaseTapGestureRecognizer distinguish between the two behaviors?

dkwingsmt

Generally great! I think iOS's button behavior is slightly different from the current code (see comments below), but no major issues!

packages/flutter/lib/src/cupertino/constants.dart

packages/flutter/lib/src/cupertino/button.dart

dkwingsmt · 2025-01-27T10:02:58Z

packages/flutter/test/material/selection_area_test.dart

      expect(find.text('Copy'), findsOneWidget);
    },
-    variant: TargetPlatformVariant.all(),
+    variant: TargetPlatformVariant.mobile(),


Can you explain why this is changed?

+1, maybe just don't do this in this PR. I guess you did it just because this test appears to be relevant only to mobile? But I worry that it could conceal a failure if we make this change in this PR.

dkwingsmt · 2025-01-27T10:09:25Z

packages/flutter/lib/src/cupertino/button.dart

  }

+  void _handTapMove(TapMoveDetails event) {
+    final double distance = switch (defaultTargetPlatform) {


I'm a bit troubled by the duplicate switch statement here and in the unit test. What do you think if we extract this switch statement as a function and replace the kCupertinoButtonTapMoveOpacityChangeDistance constant?

packages/flutter/test/cupertino/button_test.dart

yiiim · 2025-02-07T05:23:01Z

Sorry for the delay due to the Chinese New Year holiday.

How did BaseTapGestureRecognizer distinguish between the two behaviors?

BaseTapGestureRecognizer does not care whether onTap or onTapMove is used. However, should this be clarified for the users of the button?

dkwingsmt · 2025-02-07T08:51:07Z

The reason why I asked that is because there would be two kinds of behaviors:

Traditional Flutter tap gesture, where moving after tapping down cancels the tap (triggering onTapCancel.
The new iOS gesture, where moving after tapping triggers the onTapMove.

Does your PR keep the first kind for existing widgets, and if so, how?

yiiim · 2025-02-07T09:52:57Z

@dkwingsmt In BaseTapGestureRecognizer, the cancellation of the tap gesture is set through postAcceptSlopTolerance. postAcceptSlopTolerance is still retained, but it is set to null in CupertinoButton. This change does not affect BaseTapGestureRecognizer at all. Only CupertinoButton is affected.

packages/flutter/lib/src/gestures/tap.dart

dkwingsmt

LGTM with minor suggestions. Thank you very much!

packages/flutter/test/cupertino/button_test.dart

justinmc

Just a few questions and small changes. I think the only real blockers are the "eyeballed" comment and the question about being a breaking change.

Thanks for the PR! It looks like this required some reworking of the events here that probably wasn't easy, but everything looks very Fluttery and like a good change.

packages/flutter/lib/src/cupertino/constants.dart

packages/flutter/lib/src/cupertino/button.dart

justinmc · 2025-02-20T00:30:41Z

packages/flutter/lib/src/gestures/tap.dart

+  /// The parameter `move` is the move event of the primary pointer that started
+  /// the tap sequence.
+  @protected
+  void handleTapMove({required PointerMoveEvent move});


Could this possibly be a breaking change for users that implement BaseTapGestureRecognizer? Would it be desirable to add a default implementation here to avoid this, or do we want to break people that implement BaseTapGestureRecognizer?

I'm running the Google tests on this PR to check if there are breakages there.

Recently there has been a complaint about we adding such methods breaking packages that implement it. I think it'll help developers if we mention such "non-breaking-by-Flutter-standards" changes, especially "notable new methods" in the patchnotes. What do you think?

Yeah that sounds like a good idea to me. I've seen this kind of thing come up before too.

I think in this case it makes sense to allow users to subtype BaseTapGestureRecognizer, right? And if they are, then do they care about implementing handleTapMove? Maybe not, since I guess they would probably have some specific use case for their subclass that doesn't care about this "tap and move" bug.

Yeah it makes sense to provide a default implementation in this case too.

justinmc · 2025-02-20T00:32:01Z

packages/flutter/lib/src/widgets/modal_barrier.dart

  String get debugDescription => 'any tap';
+
+  @override
+  void handleTapMove({required PointerMoveEvent move}) {


If you provided a default implementation for handleTapMove, then you wouldn't need this. Not sure if that's good or not though.

packages/flutter/test/cupertino/button_test.dart

justinmc · 2025-02-20T00:36:43Z

packages/flutter/test/material/selection_area_test.dart

      expect(find.text('Copy'), findsOneWidget);
    },
-    variant: TargetPlatformVariant.all(),
+    variant: TargetPlatformVariant.mobile(),


+1, maybe just don't do this in this PR. I guess you did it just because this test appears to be relevant only to mobile? But I worry that it could conceal a failure if we make this change in this PR.

yiiim · 2025-02-28T04:37:14Z

@dkwingsmt @justinmc Waiting for a new LGTM.

dkwingsmt

LGTM

justinmc

LGTM 👍 Thanks for the fixes.

…behavior. (flutter/flutter#161731)

Roll Flutter from 2e570ca to 842db35 (59 revisions) flutter/flutter@2e570ca...842db35 2025-03-02 engine-flutter-autoroll@skia.org Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449) 2025-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440) 2025-03-02 chris@bracken.jp android: Clean up gen_snapshot artifact build (flutter/flutter#164418) 2025-03-02 matanlurey@users.noreply.github.com Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352) 2025-03-01 chris@bracken.jp Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410) 2025-03-01 chris@bracken.jp Delete unused build archive targets (flutter/flutter#164414) 2025-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423) 2025-03-01 engine-flutter-autoroll@skia.org Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413) 2025-03-01 eric@shorebird.dev Update linux_host_engine.json ci/host_release description (flutter/flutter#164402) 2025-03-01 jason-simmons@users.noreply.github.com In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395) 2025-03-01 matanlurey@users.noreply.github.com Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401) 2025-02-28 ybz975218925@gmail.com Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731) 2025-02-28 engine-flutter-autoroll@skia.org Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404) 2025-02-28 matej.knopp@gmail.com [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962) 2025-02-28 matej.knopp@gmail.com Add PlatformDispatcher.engineId (flutter/flutter#163476) 2025-02-28 matanlurey@users.noreply.github.com Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398) 2025-02-28 34465683+rkishan516@users.noreply.github.com Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853) 2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396) 2025-02-28 47989573+Hannnes1@users.noreply.github.com Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575) 2025-02-28 reidbaker@google.com Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200) 2025-02-28 engine-flutter-autoroll@skia.org Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380) 2025-02-28 51940183+Sameri11@users.noreply.github.com [tool] Allow using archiveName in android bundle build (flutter/flutter#162390) 2025-02-28 ueman@users.noreply.github.com Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101) 2025-02-28 robert.ancell@canonical.com Support forward and back buttons (flutter/flutter#164356) 2025-02-28 robert.ancell@canonical.com Fix window creation callback for multi-window (flutter/flutter#164353) 2025-02-28 robert.ancell@canonical.com Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334) 2025-02-28 sigurdm@google.com Refactor writing of package config in tests (flutter/flutter#163734) 2025-02-28 ybz975218925@gmail.com Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996) 2025-02-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#164357) 2025-02-28 codefu@google.com Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350) 2025-02-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351) 2025-02-28 ybz975218925@gmail.com Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723) 2025-02-28 jonahwilliams@google.com [Android] Use java for looking up Android API level. (flutter/flutter#163558) 2025-02-28 matanlurey@users.noreply.github.com Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317) 2025-02-27 47866232+chunhtai@users.noreply.github.com Wires up expanded state in web engine (flutter/flutter#164048) 2025-02-27 matanlurey@users.noreply.github.com Remove Cheserton's File (flutter/flutter#164340) 2025-02-27 robert.ancell@canonical.com Replace update semantics handler with signal. (flutter/flutter#163583) 2025-02-27 30870216+gaaclarke@users.noreply.github.com Split up the conical gradient fragment shader (flutter/flutter#164058) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339) 2025-02-27 matanlurey@users.noreply.github.com Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324) 2025-02-27 matanlurey@users.noreply.github.com Document how `engine.version` (is/will be) computed (flutter/flutter#164335) 2025-02-27 christopherfujino@gmail.com Update conductor to write engine.version file (flutter/flutter#163350) 2025-02-27 reidbaker@google.com remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198) 2025-02-27 matanlurey@users.noreply.github.com Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328) 2025-02-27 34871572+gmackall@users.noreply.github.com Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233) 2025-02-27 aam@google.com Revert dart sdks that were causing dartaotruntime issues in g3 (flutter/flutter#164307) ...

…behavior. (flutter/flutter#161731)

Roll Flutter from 2e570ca to 842db35 (59 revisions) flutter/flutter@2e570ca...842db35 2025-03-02 engine-flutter-autoroll@skia.org Roll Skia from ad64415050aa to 101eee8fce59 (1 revision) (flutter/flutter#164449) 2025-03-02 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ln3joxJfRN2XGhvCv... to AO1KirSDI7-MVYNPN... (flutter/flutter#164440) 2025-03-02 chris@bracken.jp android: Clean up gen_snapshot artifact build (flutter/flutter#164418) 2025-03-02 matanlurey@users.noreply.github.com Start using `bin/cache/engine.{stamp|realm}` instead of `bin/internal/engine.{realm|version}`. (flutter/flutter#164352) 2025-03-01 chris@bracken.jp Add macos/android_debug_unopt to local_engine.json (flutter/flutter#164410) 2025-03-01 chris@bracken.jp Delete unused build archive targets (flutter/flutter#164414) 2025-03-01 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from QMun2itYrV_zUYrvW... to ln3joxJfRN2XGhvCv... (flutter/flutter#164423) 2025-03-01 engine-flutter-autoroll@skia.org Roll Skia from ac14158663ea to ad64415050aa (1 revision) (flutter/flutter#164413) 2025-03-01 eric@shorebird.dev Update linux_host_engine.json ci/host_release description (flutter/flutter#164402) 2025-03-01 jason-simmons@users.noreply.github.com In update_engine_version_test.dart, do not populate the test environment with the host platform environment (flutter/flutter#164395) 2025-03-01 matanlurey@users.noreply.github.com Roll-forward #164317: Use `bin/cache/engine.stamp` (flutter/flutter#164401) 2025-02-28 ybz975218925@gmail.com Make pressing and moving on CupertinoButton closer to native behavior. (flutter/flutter#161731) 2025-02-28 engine-flutter-autoroll@skia.org Roll Skia from 4005ba3ca7b6 to ac14158663ea (7 revisions) (flutter/flutter#164404) 2025-02-28 matej.knopp@gmail.com [macOS] Prepare FlutterKeyboardManager for multi-view (flutter/flutter#163962) 2025-02-28 matej.knopp@gmail.com Add PlatformDispatcher.engineId (flutter/flutter#163476) 2025-02-28 matanlurey@users.noreply.github.com Move `integration_test.FlutterDeviceScreenshotTest` to the framework slow shard (flutter/flutter#164398) 2025-02-28 34465683+rkishan516@users.noreply.github.com Fix: Update DelegatedTransition animation parameter correctly (flutter/flutter#163853) 2025-02-28 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Write an identical value to `bin/cache/engine.stamp` to prepare for migration (#164317)" (flutter/flutter#164396) 2025-02-28 47989573+Hannnes1@users.noreply.github.com Add action for configuring default action of EditableText.onTapUpOutside (flutter/flutter#162575) 2025-02-28 reidbaker@google.com Align jvmTarget usages across codebase, while editing build.gradle files align them with android version documentation (flutter/flutter#164200) 2025-02-28 engine-flutter-autoroll@skia.org Roll Packages from 01d3d5c to 70b41e1 (5 revisions) (flutter/flutter#164380) 2025-02-28 51940183+Sameri11@users.noreply.github.com [tool] Allow using archiveName in android bundle build (flutter/flutter#162390) 2025-02-28 ueman@users.noreply.github.com Fix incorrectly checking for invalid environment variables in the tool (flutter/flutter#164101) 2025-02-28 robert.ancell@canonical.com Support forward and back buttons (flutter/flutter#164356) 2025-02-28 robert.ancell@canonical.com Fix window creation callback for multi-window (flutter/flutter#164353) 2025-02-28 robert.ancell@canonical.com Fix flutter doctor usage of eglinfo in failure cases. (flutter/flutter#164334) 2025-02-28 sigurdm@google.com Refactor writing of package config in tests (flutter/flutter#163734) 2025-02-28 ybz975218925@gmail.com Fixed the issue that Slider's secondaryTrackValue is not updated. (flutter/flutter#163996) 2025-02-28 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#164357) 2025-02-28 codefu@google.com Remove `Mac mac_unopt` presubmit retry count (flutter/flutter#164350) 2025-02-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 1elkOxihZuTEiTXzY... to QMun2itYrV_zUYrvW... (flutter/flutter#164351) 2025-02-28 ybz975218925@gmail.com Drag handles only need to be tested on mobile platforms. (flutter/flutter#163723) 2025-02-28 jonahwilliams@google.com [Android] Use java for looking up Android API level. (flutter/flutter#163558) 2025-02-28 matanlurey@users.noreply.github.com Write an identical value to `bin/cache/engine.stamp` to prepare for migration (flutter/flutter#164317) 2025-02-27 47866232+chunhtai@users.noreply.github.com Wires up expanded state in web engine (flutter/flutter#164048) 2025-02-27 matanlurey@users.noreply.github.com Remove Cheserton's File (flutter/flutter#164340) 2025-02-27 robert.ancell@canonical.com Replace update semantics handler with signal. (flutter/flutter#163583) 2025-02-27 30870216+gaaclarke@users.noreply.github.com Split up the conical gradient fragment shader (flutter/flutter#164058) 2025-02-27 engine-flutter-autoroll@skia.org Roll Skia from c16b145749d4 to 4005ba3ca7b6 (3 revisions) (flutter/flutter#164339) 2025-02-27 matanlurey@users.noreply.github.com Delete and update stale documentation regarding engine/engine hash. (flutter/flutter#164324) 2025-02-27 matanlurey@users.noreply.github.com Document how `engine.version` (is/will be) computed (flutter/flutter#164335) 2025-02-27 christopherfujino@gmail.com Update conductor to write engine.version file (flutter/flutter#163350) 2025-02-27 reidbaker@google.com remove last usages of min/compile/target SdkVersion, align sourceCompatibility across repo and update android version documentation (flutter/flutter#164198) 2025-02-27 matanlurey@users.noreply.github.com Update links to the `flutter/engine` repository for the monorepo. (flutter/flutter#164328) 2025-02-27 34871572+gmackall@users.noreply.github.com Add empty `io.flutter.app.FlutterApplication` to give deprecation notice, and un-break projects that have not migrated (flutter/flutter#164233) 2025-02-27 aam@google.com Revert dart sdks that were causing dartaotruntime issues in g3 (flutter/flutter#164307) ...

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository f: gestures flutter/packages/flutter/gestures repository. labels Jan 16, 2025

cupertion button

560a9ff

yiiim force-pushed the cupertion_button_gesture branch from ceb258b to 560a9ff Compare January 17, 2025 13:36

github-actions bot added the f: material design flutter/packages/flutter/material repository. label Jan 17, 2025

yiiim added 2 commits January 17, 2025 21:44

fix test

b15f6c7

Merge branch 'master' into cupertion_button_gesture

228f3e7

dkwingsmt self-requested a review January 22, 2025 19:25

yiiim added 6 commits January 24, 2025 16:17

++

722c3fd

Merge branch 'master' into cupertion_button_gesture

2932a74

onTapMove test

697e982

Merge branch 'cupertion_button_gesture' of github.com:yiiim/flutter i…

5ea7302

…nto cupertion_button_gesture

Merge branch 'master' into cupertion_button_gesture

a8c6896

format

3b11335

dkwingsmt reviewed Jan 27, 2025

View reviewed changes

yiiim and others added 3 commits February 6, 2025 20:54

++

04f8a89

Merge branch 'master' into cupertion_button_gesture

74570e7

fix test

0318e5b

yiiim requested a review from dkwingsmt February 7, 2025 08:15

dkwingsmt reviewed Feb 20, 2025

View reviewed changes

packages/flutter/lib/src/gestures/tap.dart Show resolved Hide resolved

dkwingsmt approved these changes Feb 20, 2025

View reviewed changes

packages/flutter/test/cupertino/button_test.dart Outdated Show resolved Hide resolved

justinmc reviewed Feb 20, 2025

View reviewed changes

++

4c1d138

github-actions bot removed the f: material design flutter/packages/flutter/material repository. label Feb 20, 2025

Merge branch 'master' into cupertion_button_gesture

2e32f92

Merge branch 'master' into cupertion_button_gesture

b06517e

dkwingsmt approved these changes Feb 28, 2025

View reviewed changes

dkwingsmt requested a review from justinmc February 28, 2025 23:12

justinmc approved these changes Feb 28, 2025

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2025

auto-submit bot added this pull request to the merge queue Feb 28, 2025

Merged via the queue into flutter:master with commit 246d6c6 Mar 1, 2025
75 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 1, 2025

engine-flutter-autoroll mentioned this pull request Mar 1, 2025

Roll Flutter from 2e570ca393c8 to 0c055f2c508a (55 revisions) flutter/packages#8767

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

8a62d2a

…behavior. (flutter/flutter#161731)

engine-flutter-autoroll mentioned this pull request Mar 1, 2025

Roll Flutter from 2e570ca393c8 to 0c055f2c508a (55 revisions) flutter/packages#8768

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 1, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

c384859

…behavior. (flutter/flutter#161731)

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 619d4248114d (58 revisions) flutter/packages#8769

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

de2d2da

…behavior. (flutter/flutter#161731)

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 842db35d27b8 (59 revisions) flutter/packages#8770

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

40dedc0

…behavior. (flutter/flutter#161731)

engine-flutter-autoroll mentioned this pull request Mar 2, 2025

Roll Flutter from 2e570ca393c8 to 842db35d27b8 (59 revisions) flutter/packages#8771

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 2, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

566123e

…behavior. (flutter/flutter#161731)

Piinks mentioned this pull request Mar 7, 2025

Flutter Notable Commits - 2025 #161460

Open

KyleFin mentioned this pull request Mar 20, 2025

kTouchSlop too low and not configurable (RE: kTouchSlop const needs to change from 18 to 64 for touches to feel responsive #137962) #154215

Closed

jason-simmons mentioned this pull request Mar 22, 2025

CupertinoButton inside ListView remains pressed after tapping and quickly dragging outside the button #165724

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

a30bdf8

…behavior. (flutter/flutter#161731)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

cc7320d

…behavior. (flutter/flutter#161731)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025

246d6c6 Make pressing and moving on CupertinoButton closer to native …

39e9551

…behavior. (flutter/flutter#161731)

chunhtai mentioned this pull request Jun 12, 2025

CupertinoButton does not handle VoiceOver taps correctly on iOS #170348

Closed

Make pressing and moving on CupertinoButton closer to native behavior. #161731

Make pressing and moving on CupertinoButton closer to native behavior. #161731

Uh oh!

Conversation

yiiim commented Jan 16, 2025

Pre-launch Checklist

Uh oh!

dkwingsmt commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dkwingsmt left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yiiim commented Feb 7, 2025

Uh oh!

dkwingsmt commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yiiim commented Feb 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yiiim commented Feb 28, 2025

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dkwingsmt commented Jan 27, 2025 •

edited

Loading

dkwingsmt left a comment •

edited

Loading

dkwingsmt commented Feb 7, 2025 •

edited

Loading

yiiim commented Feb 7, 2025 •

edited

Loading