Skip to content

Conversation

@loic-sharma
Copy link
Member

This reverts commit afdc861.

See: #167418

@loic-sharma loic-sharma requested review from knopp and matanlurey April 18, 2025 21:10
@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically a: desktop Running on desktop labels Apr 18, 2025
@matanlurey
Copy link
Contributor

If there is a fix-forward I am OK with that, given the 1-2 tests failing seem perhaps trivial?

Up to you though, will LGTM optimistically.

@loic-sharma
Copy link
Member Author

loic-sharma commented Apr 18, 2025

If there is a fix-forward I am OK with that, given the 1-2 tests failing seem perhaps trivial?

I'd like to use this PR to unblock the tree instead of #167419 so that we can keep Windows tests as required

@loic-sharma loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Apr 18, 2025
Merged via the queue into flutter:master with commit 66ecc88 Apr 18, 2025
179 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 18, 2025
github-merge-queue bot pushed a commit that referenced this pull request Apr 18, 2025
<!-- start_original_pr_link -->
Reverts: #167419
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Test should no longer be flaky now that
#167420 has landed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
See #167418.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 19, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 20, 2025
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Apr 20, 2025
flutter/flutter@3ed38e2...cfb887c

2025-04-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 jason-simmons@users.noreply.github.com Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 huy@nevercode.io Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 34465683+rkishan516@users.noreply.github.com Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 matt.boetger@gmail.com Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 737941+loic-sharma@users.noreply.github.com Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 greg@zulip.com Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 152275799+shaymolcho@users.noreply.github.com Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 louisehsu@google.com Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 matanlurey@users.noreply.github.com Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 yjbanov@google.com [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
knopp added a commit to knopp/flutter that referenced this pull request Apr 21, 2025
jason-simmons added a commit to jason-simmons/flutter that referenced this pull request Apr 22, 2025
knopp added a commit to knopp/flutter that referenced this pull request Apr 23, 2025
raju-muliyashiya pushed a commit to raju-muliyashiya/flutter_packages that referenced this pull request Apr 26, 2025
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 jason-simmons@users.noreply.github.com Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 huy@nevercode.io Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 34465683+rkishan516@users.noreply.github.com Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 matt.boetger@gmail.com Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 737941+loic-sharma@users.noreply.github.com Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 greg@zulip.com Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 152275799+shaymolcho@users.noreply.github.com Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 louisehsu@google.com Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 matanlurey@users.noreply.github.com Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 yjbanov@google.com [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
CodixNinja pushed a commit to CodixNinja/flutter that referenced this pull request May 15, 2025
<!-- start_original_pr_link -->
Reverts: flutter/flutter#167419
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Test should no longer be flaky now that
flutter/flutter#167420 has landed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
See flutter/flutter#167418.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 jason-simmons@users.noreply.github.com Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 huy@nevercode.io Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 34465683+rkishan516@users.noreply.github.com Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 matt.boetger@gmail.com Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 737941+loic-sharma@users.noreply.github.com Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 greg@zulip.com Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 152275799+shaymolcho@users.noreply.github.com Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 louisehsu@google.com Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 matanlurey@users.noreply.github.com Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 yjbanov@google.com [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 jason-simmons@users.noreply.github.com Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 huy@nevercode.io Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 34465683+rkishan516@users.noreply.github.com Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 matt.boetger@gmail.com Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 737941+loic-sharma@users.noreply.github.com Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 greg@zulip.com Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 152275799+shaymolcho@users.noreply.github.com Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 louisehsu@google.com Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 matanlurey@users.noreply.github.com Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 yjbanov@google.com [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Ortes pushed a commit to Ortes/packages that referenced this pull request Jun 25, 2025
…r#9118)

flutter/flutter@3ed38e2...cfb887c

2025-04-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0U_vEALFF7qRJZ_cE... to RGmU4KeQhrxqE7hsr... (flutter/flutter#167447)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 3dc3ffeb45f0 to bd9ef4955aad (1 revision) (flutter/flutter#167434)
2025-04-19 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from MwYckh5OvwwmIYLx0... to 0U_vEALFF7qRJZ_cE... (flutter/flutter#167430)
2025-04-19 engine-flutter-autoroll@skia.org Roll Skia from 177a2929e32f to 3dc3ffeb45f0 (1 revision) (flutter/flutter#167428)
2025-04-19 jason-simmons@users.noreply.github.com Revert "Reduce app startup latency by initializing the engine on a separate thread (#166918)" (flutter/flutter#167427)
2025-04-18 huy@nevercode.io Fix keyboard cover SearchAnchor list results (flutter/flutter#165382)
2025-04-18 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Mark `windows_host_engine_test` flaky (#167419)" (flutter/flutter#167425)
2025-04-18 34465683+rkishan516@users.noreply.github.com Docs: Update date picker theme day color properties doc (flutter/flutter#166122)
2025-04-18 matt.boetger@gmail.com Add ktlint test for generated files from templates (flutter/flutter#167378)
2025-04-18 737941+loic-sharma@users.noreply.github.com Revert "[Windows] Enable merged platform and UI thread by default" (flutter/flutter#167420)
2025-04-18 greg@zulip.com Add a DrivenScrollActivity.simulation constructor (flutter/flutter#166730)
2025-04-18 152275799+shaymolcho@users.noreply.github.com Added missing period for consistency and readability (flutter/flutter#162887)
2025-04-18 engine-flutter-autoroll@skia.org Roll Skia from 6c4595124690 to 177a2929e32f (1 revision) (flutter/flutter#167417)
2025-04-18 louisehsu@google.com Fix codesigning for `Mac_arm64_ios imitation_game_flutter` (flutter/flutter#167307)
2025-04-18 matanlurey@users.noreply.github.com Mark `windows_host_engine_test` flaky (flutter/flutter#167419)
2025-04-18 engine-flutter-autoroll@skia.org Roll Dart SDK from ab60afc99bcb to 0cfefe2a03fb (1 revision) (flutter/flutter#167414)
2025-04-18 yjbanov@google.com [web] close input connection when window/iframe loses focus (flutter/flutter#166804)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC stuartmorgan@google.com,tarrinneal@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2025
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
romanejaquez pushed a commit to romanejaquez/flutter that referenced this pull request Aug 14, 2025
…tter#167425)

<!-- start_original_pr_link -->
Reverts: flutter#167419
<!-- end_original_pr_link -->
<!-- start_initiating_author -->
Initiated by: loic-sharma
<!-- end_initiating_author -->
<!-- start_revert_reason -->
Reason for reverting: Test should no longer be flaky now that
flutter#167420 has landed.
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: matanlurey
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {jtmcdole}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
See flutter#167418.
<!-- end_revert_body -->

Co-authored-by: auto-submit[bot] <flutter-engprod-team@google.com>
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop engine flutter/engine related. See also e: labels. platform-windows Building on or for Windows specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants