Fix InputDecoration does not apply errorStyle to error #174787

bleroux · 2025-09-01T09:33:32Z

Description

This PR fixes InpuDecorator not applying InputDecoration.errorStyle to InputDecoration.error.

Before

Text from InputDecoration.error is not styled correctly:

After

Text from InputDecoration.error is styled correctly:

Related Issue

Fixes InputDecorator does not apply errorStyle to error

Tests

Adds 1 test.

gemini-code-assist

Code Review

This pull request correctly fixes an issue where InputDecoration.errorStyle was not applied to the InputDecoration.error widget. The implementation is sound and a regression test has been added to verify the fix. My feedback includes a suggestion to enhance the test coverage by adding a test case for custom errorStyle to ensure all scenarios are covered.

packages/flutter/test/material/input_decorator_test.dart

bleroux · 2025-09-04T14:15:38Z

@justinmc If you get a chance to review this PR, it would be great if it can get merged before or not long after #174831 (which relies on this fix to get a proper visual rendering).

ValentinVignal

LGTM

ValentinVignal · 2025-09-05T15:26:45Z

packages/flutter/test/material/input_decorator_test.dart

+          buildInputDecorator(decoration: const InputDecoration(error: Text(errorText))),
+        );
+
+        expect(findError(), findsOneWidget);


Reading the documentation of findsOneWidget, it is written that

This is equivalent to the preferred [findsOne] method.

Should we be using findsOne instead of findsOneWidget?

Should we be using findsOne instead of findsOneWidget?

Interesting question!
Searching through the codebase:

findsOne: 8218

findsOneWidget: 7610

In input_decorator_test.dart file, there are no occurences of findsOne, only findsOneWidget.
The reason is probably because findsOne was introduced somewhat recently, see #127137.
I would say using findsOneWidget when we are looking for a Widget is ok, but maybe @justinmc has some thinking about this.

I did some major archaeology here and my conclusion is that we should actually be using findsOne and not findsOneWidget! See these two comment threads:

Adds SemanticsNode Finders for searching the semantics tree #127137 (comment)

Adds SemanticsNode Finders for searching the semantics tree #127137 (comment)

It seems like there was a long-term plan to deprecate findsOneWidget, but the people involved are no longer working on Flutter.

So I guess strictly this PR should be changed to use findsOne. And I should stop using findsOneWidget like I have been for all my time on Flutter.

But in reality, both are equivalent and it doesn't really matter. I'll just keep this fact in my head in case anyone ever comes along with the motivation to clean up these duplicate methods and do the deprecation.

I see, thank you for those insights @justinmc. Is there something blocking us from deprecated findsOneWidget and other similar finders today?

If not, I could open PRs to deprecate them and migrate to findsOne and similar finders

justinmc

LGTM 👍. Sorry for the delay on this! Treat my comment below as a total nit.

justinmc · 2025-09-17T21:58:08Z

packages/flutter/test/material/input_decorator_test.dart

+          buildInputDecorator(decoration: const InputDecoration(error: Text(errorText))),
+        );
+
+        expect(findError(), findsOneWidget);


I did some major archaeology here and my conclusion is that we should actually be using findsOne and not findsOneWidget! See these two comment threads:

Adds SemanticsNode Finders for searching the semantics tree #127137 (comment)

Adds SemanticsNode Finders for searching the semantics tree #127137 (comment)

It seems like there was a long-term plan to deprecate findsOneWidget, but the people involved are no longer working on Flutter.

So I guess strictly this PR should be changed to use findsOne. And I should stop using findsOneWidget like I have been for all my time on Flutter.

But in reality, both are equivalent and it doesn't really matter. I'll just keep this fact in my head in case anyone ever comes along with the motivation to clean up these duplicate methods and do the deprecation.

bleroux · 2025-09-18T06:37:14Z

LGTM 👍. Sorry for the delay on this! Treat my comment below as a total nit.

Thanks for the review 🙏
I will let the findsOneWidget for the moment as it would be better to replace all occurrences in this test file at once.

…tter/flutter#174787)

Roll Flutter from 8f94cb0d8f01 to 9ff2767f3cb6 (56 revisions) flutter/flutter@8f94cb0...9ff2767 2025-09-20 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from 0_jKqLGnkILvQ5C8a... to CcCe3HpQtBYhTZscb... (flutter/flutter#175698) 2025-09-20 engine-flutter-autoroll@skia.org Roll Dart SDK from e6e9248aee4f to 9e943fe076c8 (1 revision) (flutter/flutter#175697) 2025-09-20 32538273+ValentinVignal@users.noreply.github.com Add `menuController` to `DropdownMenu` (flutter/flutter#175039) 2025-09-20 engine-flutter-autoroll@skia.org Roll Skia from 1dae085e2f31 to a38a531dec1d (3 revisions) (flutter/flutter#175694) 2025-09-20 bruno.leroux@gmail.com [a11y] TimePicker clock is unnecessarily announced (flutter/flutter#175570) 2025-09-20 engine-flutter-autoroll@skia.org Roll Dart SDK from 78e68d1a7dbf to e6e9248aee4f (4 revisions) (flutter/flutter#175690) 2025-09-19 engine-flutter-autoroll@skia.org Roll Skia from b56003bf2c20 to 1dae085e2f31 (1 revision) (flutter/flutter#175674) 2025-09-19 matanlurey@users.noreply.github.com Update `CODEOWNERS` (for dev-tooling) (flutter/flutter#175201) 2025-09-19 sokolovskyi.konstantin@gmail.com [a11y-app] Add label to TextFormField in AutoCompleteUseCase. (flutter/flutter#175576) 2025-09-19 sokolovskyi.konstantin@gmail.com Fix RadioGroup single selection check. (flutter/flutter#175654) 2025-09-19 engine-flutter-autoroll@skia.org Roll Packages from f2a65fd to 3d5c419 (2 revisions) (flutter/flutter#175668) 2025-09-19 engine-flutter-autoroll@skia.org Roll Skia from c74d2bdbd93c to b56003bf2c20 (2 revisions) (flutter/flutter#175665) 2025-09-19 32538273+ValentinVignal@users.noreply.github.com Add `CupertinoLinearActivityIndicator` (flutter/flutter#170108) 2025-09-19 bkonyi@google.com [ Widget Preview ] Don't update filtered preview set when selecting non-source files (flutter/flutter#175596) 2025-09-19 engine-flutter-autoroll@skia.org Roll Dart SDK from 2c79803c97db to 78e68d1a7dbf (3 revisions) (flutter/flutter#175646) 2025-09-19 mdebbar@google.com Delete unused web_unicode library (flutter/flutter#174896) 2025-09-19 engine-flutter-autoroll@skia.org Roll Skia from 684f3a831216 to c74d2bdbd93c (2 revisions) (flutter/flutter#175644) 2025-09-19 engine-flutter-autoroll@skia.org Roll Skia from 462bdece17bf to 684f3a831216 (3 revisions) (flutter/flutter#175641) 2025-09-19 engine-flutter-autoroll@skia.org Roll Skia from a2c38aa9df80 to 462bdece17bf (11 revisions) (flutter/flutter#175629) 2025-09-18 1961493+harryterkelsen@users.noreply.github.com fix(tool): Use merge-base for content hash in detached HEAD (flutter/flutter#175554) 2025-09-18 1961493+harryterkelsen@users.noreply.github.com [web] Unskip Cupertino datepicker golden tests in Skwasm (flutter/flutter#174666) 2025-09-18 ryjohn@google.com Update rules to include extension rules (flutter/flutter#175618) 2025-09-18 Breakthrough@users.noreply.github.com [engine] Cleanup Fuchsia FDIO library dependencies (flutter/flutter#174847) 2025-09-18 ahmedsameha1@gmail.com Make sure that a CloseButton doesn't crash in 0x0 environment (flutter/flutter#172902) 2025-09-18 bkonyi@google.com [ Tool ] Serve DevTools from DDS, remove ResidentDevToolsHandler (flutter/flutter#174580) 2025-09-18 Breakthrough@users.noreply.github.com [engine][fuchsia] Update to Fuchsia API level 28 and roll latest GN SDK (flutter/flutter#175425) 2025-09-18 jessiewong401@gmail.com Added a 36 device for Firebase Lab Testing (flutter/flutter#175613) 2025-09-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 09a101793af4 to 2c79803c97db (2 revisions) (flutter/flutter#175608) 2025-09-18 louisehsu@google.com Engine Support for Dynamic View Resizing (flutter/flutter#173610) 2025-09-18 engine-flutter-autoroll@skia.org Roll Packages from fdee698 to f2a65fd (3 revisions) (flutter/flutter#175594) 2025-09-18 15619084+vashworth@users.noreply.github.com Connect the FlutterEngine to the FlutterSceneDelegate (flutter/flutter#174910) 2025-09-18 engine-flutter-autoroll@skia.org Roll Dart SDK from de5dd0f1530f to 09a101793af4 (2 revisions) (flutter/flutter#175583) 2025-09-18 engine-flutter-autoroll@skia.org Roll Skia from 7b9fe91446ee to a2c38aa9df80 (1 revision) (flutter/flutter#175579) 2025-09-18 engine-flutter-autoroll@skia.org Roll Skia from ab1b10547461 to 7b9fe91446ee (4 revisions) (flutter/flutter#175569) 2025-09-18 bruno.leroux@gmail.com [a11y-app] Fix form field label and error message (flutter/flutter#174831) 2025-09-18 bruno.leroux@gmail.com Fix InputDecoration does not apply errorStyle to error (flutter/flutter#174787) 2025-09-18 32538273+ValentinVignal@users.noreply.github.com Migrate to `WidgetPropertyResolver` (flutter/flutter#175397) 2025-09-18 32538273+ValentinVignal@users.noreply.github.com Migrate to WidgetState (flutter/flutter#175396) 2025-09-18 engine-flutter-autoroll@skia.org Roll Skia from 79ec8dfcd9d4 to ab1b10547461 (17 revisions) (flutter/flutter#175561) 2025-09-18 30870216+gaaclarke@users.noreply.github.com Removes NOTICES from licenses input (flutter/flutter#174967) 2025-09-18 engine-flutter-autoroll@skia.org Roll Dart SDK from 116f7fe72839 to de5dd0f1530f (2 revisions) (flutter/flutter#175557) 2025-09-17 1961493+harryterkelsen@users.noreply.github.com [reland][web] Refactor renderers to use the same frontend code #174588 (flutter/flutter#175392) 2025-09-17 erickzanardoo@gmail.com feat: Enable WidgetStateColor to be used in ChipThemeData.deleteIconColor (flutter/flutter#171646) 2025-09-17 15619084+vashworth@users.noreply.github.com Filter out unexpected process logs on iOS with better regex matching. (flutter/flutter#175452) 2025-09-17 victorsanniay@gmail.com CupertinoContextMenu child respects available screen width (flutter/flutter#175300) 2025-09-17 38427679+xVemu@users.noreply.github.com Correct documentation in PredictiveBackFullscreenPageTransitionsBuilder (flutter/flutter#174362) ...

## Description This PR fixes `InpuDecorator` not applying `InputDecoration.errorStyle` to `InputDecoration.error`. ## Before Text from `InputDecoration.error` is not styled correctly: <img width="239" height="75" alt="image" src="https://github.com/user-attachments/assets/9b27e029-f431-4448-9d2c-9a28f52087f8" /> ## After Text from `InputDecoration.error` is styled correctly: <img width="239" height="75" alt="image" src="https://github.com/user-attachments/assets/9b0ac7da-4933-4ee8-a3ae-d7b4db7ca218" /> ## Related Issue Fixes [InputDecorator does not apply errorStyle to error](flutter#174784) ## Tests Adds 1 test.

bleroux requested a review from justinmc September 1, 2025 09:33

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Sep 1, 2025

gemini-code-assist bot reviewed Sep 1, 2025

View reviewed changes

packages/flutter/test/material/input_decorator_test.dart Show resolved Hide resolved

bleroux mentioned this pull request Sep 2, 2025

[a11y-app] Fix form field label and error message #174831

Merged

bleroux force-pushed the fix_input_decoration_does_not_apply_errorStyle_to_error branch 2 times, most recently from 2de498c to 5281771 Compare September 4, 2025 12:10

ValentinVignal approved these changes Sep 5, 2025

View reviewed changes

Fix InputDecoration does not apply errorStyle to error

0dc7383

bleroux force-pushed the fix_input_decoration_does_not_apply_errorStyle_to_error branch from 5281771 to 0dc7383 Compare September 17, 2025 06:10

justinmc approved these changes Sep 17, 2025

View reviewed changes

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2025

auto-submit bot added this pull request to the merge queue Sep 18, 2025

Merged via the queue into flutter:master with commit c0360ee Sep 18, 2025
79 checks passed

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 18, 2025

bleroux deleted the fix_input_decoration_does_not_apply_errorStyle_to_error branch September 18, 2025 07:46

engine-flutter-autoroll mentioned this pull request Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to ef6c1d185190 (25 revisions) flutter/packages#10031

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

c53da4d

…tter/flutter#174787)

engine-flutter-autoroll mentioned this pull request Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to ba2bcd62dc5f (26 revisions) flutter/packages#10032

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

f9c716b

…tter/flutter#174787)

engine-flutter-autoroll mentioned this pull request Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to 1dc51dbf6a7e (27 revisions) flutter/packages#10033

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

658a728

…tter/flutter#174787)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 18, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

fab45c0

…tter/flutter#174787)

This was referenced Sep 18, 2025

Roll Flutter from 8f94cb0d8f01 to b683af0cecc0 (28 revisions) flutter/packages#10034

Closed

Roll Flutter from 8f94cb0d8f01 to 7ade3f344755 (39 revisions) flutter/packages#10035

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

7adf3ce

…tter/flutter#174787)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to 242958f8bad5 (42 revisions) flutter/packages#10036

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

b371e5d

…tter/flutter#174787)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to f930c8105beb (43 revisions) flutter/packages#10037

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

40bc818

…tter/flutter#174787)

engine-flutter-autoroll mentioned this pull request Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to d12d8a409a7b (44 revisions) flutter/packages#10038

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

4b1356e

…tter/flutter#174787)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 19, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

a2af015

…tter/flutter#174787)

This was referenced Sep 19, 2025

Roll Flutter from 8f94cb0d8f01 to cdbfd49962cf (45 revisions) flutter/packages#10040

Closed

Roll Flutter from 8f94cb0d8f01 to 9ff2767f3cb6 (56 revisions) flutter/packages#10041

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 20, 2025

c0360ee0c Fix InputDecoration does not apply errorStyle to error (flu…

291469e

…tter/flutter#174787)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix InputDecoration does not apply errorStyle to error #174787

Fix InputDecoration does not apply errorStyle to error #174787

Uh oh!

bleroux commented Sep 1, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

bleroux commented Sep 4, 2025

Uh oh!

ValentinVignal left a comment

Uh oh!

ValentinVignal Sep 5, 2025

Uh oh!

bleroux Sep 5, 2025

Uh oh!

justinmc Sep 17, 2025

Uh oh!

ValentinVignal Sep 18, 2025

Uh oh!

justinmc left a comment

Uh oh!

justinmc Sep 17, 2025

Uh oh!

bleroux commented Sep 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Fix InputDecoration does not apply errorStyle to error #174787

Fix InputDecoration does not apply errorStyle to error #174787

Uh oh!

Conversation

bleroux commented Sep 1, 2025

Description

Before

After

Related Issue

Tests

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

bleroux commented Sep 4, 2025

Uh oh!

ValentinVignal left a comment

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

bleroux Sep 5, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc Sep 17, 2025

Choose a reason for hiding this comment

Uh oh!

bleroux commented Sep 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants