Skip to content

[web] Deprecate --pwa-strategy #177613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 29, 2025
Merged

[web] Deprecate --pwa-strategy #177613

merged 8 commits into from
Oct 29, 2025
+145 −21

Conversation

@mdebbar
Copy link
Contributor

@mdebbar mdebbar commented Oct 27, 2025

  • Hide the --pwa-strategy flag.
  • Add deprecation note to the help text.
  • Print deprecation warning if passed explicitly.

Towards #156910

@mdebbar mdebbar requested review from ditman and kevmoo October 27, 2025 20:19
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 27, 2025
gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 27, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deprecates the --pwa-strategy flag for web builds. The changes include hiding the flag, adding a deprecation note to the help text, and printing a warning if the flag is explicitly used. The implementation is sound and includes corresponding test updates. I've found a minor typo in the new deprecation warning message.

kevmoo
kevmoo approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@github-actions github-actions bot added engine flutter/engine related. See also e: labels. platform-web Web applications specifically labels Oct 28, 2025
@mdebbar mdebbar added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Oct 29, 2025
Merged via the queue into flutter:master with commit c065595 Oct 29, 2025
186 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2025
@engine-flutter-autoroll
c06559584 [web] Deprecate --pwa-strategy (flutter/flutter#177613)
1c58151
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2025
@engine-flutter-autoroll
c06559584 [web] Deprecate --pwa-strategy (flutter/flutter#177613)
c52e254
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2025
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2025
@engine-flutter-autoroll
c06559584 [web] Deprecate --pwa-strategy (flutter/flutter#177613)
a0779d1
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Oct 29, 2025
@engine-flutter-autoroll
Roll Flutter from 7cf0dc1be72e to df72035ba8c5 (23 revisions) (#10322)
1a7075b 
flutter/flutter@7cf0dc1...df72035

2025-10-29 engine-flutter-autoroll@skia.org Roll Packages from c8ba0cc to 41c6b3d (3 revisions) (flutter/flutter#177725)
2025-10-29 43054281+camsim99@users.noreply.github.com [Android] Remove unecessary `spy` in `FlutterActivityAndFragmentDelegateTest` (flutter/flutter#177120)
2025-10-29 stuartmorgan@google.com Add discussion of federated plugin documentation (flutter/flutter#177659)
2025-10-29 mdebbar@google.com [web] Deprecate --pwa-strategy (flutter/flutter#177613)
2025-10-29 engine-flutter-autoroll@skia.org Roll Skia from 53b8b802bbc4 to 0a0c9f8c704f (1 revision) (flutter/flutter#177701)
2025-10-29 alex.medinsh@gmail.com Add `Navigator.popUntilWithResult` (flutter/flutter#169341)
2025-10-29 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` with  `withValues` in `text_style.dart` (flutter/flutter#177537)
2025-10-29 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated withOpacity in `radio.1.dart` example (flutter/flutter#177606)
2025-10-29 engine-flutter-autoroll@skia.org Roll Skia from 4408d8ea88b0 to 53b8b802bbc4 (2 revisions) (flutter/flutter#177698)
2025-10-29 robert.ancell@canonical.com Remove generated file from template manifest (flutter/flutter#177034)
2025-10-29 engine-flutter-autoroll@skia.org Roll Skia from e582a5594b6f to 4408d8ea88b0 (5 revisions) (flutter/flutter#177691)
2025-10-28 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from ir6J2isKAYa1jNLyJ... to 3EF6k6lqXPWDwrdyj... (flutter/flutter#177682)
2025-10-28 jesswon@google.com [Gradle 9] Fix Engine Deps (flutter/flutter#177623)
2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `focus_scope.0.dart‎` example  (flutter/flutter#177542)
2025-10-28 bruno.leroux@gmail.com Fix EditableText _justResumed is not accurate (flutter/flutter#177658)
2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `interactive_viewer.builder.0.dart` (flutter/flutter#177541)
2025-10-28 bruno.leroux@gmail.com Fix TextButton.icon breaks focus traversal and ink effect when toggling icon (flutter/flutter#176579)
2025-10-28 jesswon@google.com [Android 16] Update Engine `ci.yaml` to test against Java 21 (flutter/flutter#177677)
2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace deprecated `withOpacity` in `interactive_viewer.constrained.0.dart` (flutter/flutter#177540)
2025-10-28 116356835+AbdeMohlbi@users.noreply.github.com Replace opacity from random color in navigation bar test (flutter/flutter#177490)
2025-10-28 engine-flutter-autoroll@skia.org Roll Skia from e4d3d8f31aef to e582a5594b6f (6 revisions) (flutter/flutter#177679)
2025-10-28 matej.knopp@gmail.com Workaround for lag when dragging window titlebar on Windows (flutter/flutter#177597)
2025-10-28 engine-flutter-autoroll@skia.org Roll Packages from bbf96a0 to c8ba0cc (2 revisions) (flutter/flutter#177672)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@mdebbar mdebbar deleted the pwa_deprecation branch October 29, 2025 20:22
walley892 pushed a commit to walley892/flutter that referenced this pull request Oct 30, 2025
@mdebbar @walley892
[web] Deprecate --pwa-strategy (flutter#177613)
6d7f30d 
- Hide the `--pwa-strategy` flag.
- Add deprecation note to the help text.
- Print deprecation warning if passed explicitly.

Towards flutter#156910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevmoo kevmoo kevmoo approved these changes

@ditman ditman Awaiting requested review from ditman

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdebbar @kevmoo