Skip to content

Conversation

@HansMuller
Copy link
Contributor

Updating flutter's translations per Google's "translation console" team.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@@ -25,7 +25,7 @@ const Map<String, dynamic> dateSymbols = <String, dynamic>{
r'''س''',
r'''ك''',
r'''ب''',
r'''د''',
r'''د'''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of trailing commas intentional (did the generator script change to cause this?)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not intentional and gen_localizations.dart didn't change in a way that would cause this. The app uses dartfmt which may have changed.

@HansMuller HansMuller merged commit fb3094a into flutter:master Mar 12, 2019
@HansMuller HansMuller deleted the update_l10n branch March 12, 2019 23:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants