[flutter_test] new WidgetTester API based on finder objects #3288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
We might want to have a tester.renderObjectOf(...) function similar to the tester.stateOf function.
Contributor
Author
There was a problem hiding this comment.
Done. Also added tester.elementOf(...)
Contributor
|
LGTM I'd probably add a renderObjectOf before landing. I'm sure we'll iterate on this after landing, but it's such a big patch that you'll probably want to get it in before it gets out of date. After landing, please email flutter-dev explaining how to use the new system and giving some pointers about converting old tests to the new system. Thanks! |
yjbanov
force-pushed
the
finder-objects
branch
4 times, most recently
from
c9dce82 to
cd0d42d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
package:flutter_testAPI according to the new design based on finder objects.