Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update several HTML links #33539

Merged
merged 1 commit into from
May 30, 2019
Merged

Fix/update several HTML links #33539

merged 1 commit into from
May 30, 2019

Conversation

tvolkert
Copy link
Contributor

Description

This updates several links in our codebase to point to the new domain name where appropriate and to avoid hard-coding a domain name at all when possible.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@tvolkert tvolkert requested a review from a14n May 29, 2019 21:37
@tvolkert tvolkert mentioned this pull request May 29, 2019
9 tasks
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the team Infra upgrades, team productivity, code health, technical debt. See also team: labels. label May 29, 2019
@tvolkert tvolkert merged commit ca13add into flutter:master May 30, 2019
@tvolkert tvolkert deleted the links branch May 30, 2019 03:14
kiku-jw pushed a commit to kiku-jw/flutter that referenced this pull request Jun 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants