New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xcconfigs from template Copy Bundle Resources build phases #38724

Merged

jmagman merged 1 commit into flutter:master from jmagman:resources

Aug 19, 2019

Member

jmagman commented Aug 16, 2019

Description

xcconfigs should not be copied into the final app bundle Resources directory. This (slightly) increases app size, and also causes a Xcode "Update to recommended settings" warning on newly created Flutter Xcode projects:

Related Issues

Fixes #26096

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

Yes, this is a breaking change (Please read [Handling breaking changes]). Replace this with a link to the e-mail where you asked for input on this proposed change.
No, this is not a breaking change.


          Remove xcconfigs from template Copy Bundle Resources build phases

0814cc9

jmagman added platform-ios tool t: xcode labels

jmagman requested a review from xster

August 16, 2019 23:39

jmagman self-assigned this

fluttergithubbot added d: examples team customer: gallery labels

googlebot added the cla: yes label

Member

xster commented Aug 17, 2019

oh, interesting. LGTM

Member Author

jmagman commented Aug 19, 2019

Landing this, Cirrus is really mad and saying the build is red but it's just cranky it ran out of compute credits.

jmagman merged commit 4d81b0c into flutter:master

jmagman deleted the resources branch

August 19, 2019 23:23

This was referenced Sep 24, 2019

Flutter Create template has 2 XCode issues #41223

Closed

Update and migrate iOS examples projects flutter/plugins#2086

Closed

[android_alarm_manager] Update and migrate iOS example project flutter/plugins#2087

Merged

[android_intent] Update and migrate iOS example project flutter/plugins#2088

Merged

[battery] Update and migrate iOS example project flutter/plugins#2089

Merged

[camera] Update and migrate iOS example project flutter/plugins#2090

Merged

[connectivity] Update and migrate iOS example project flutter/plugins#2091

Merged

[device_info] Update and migrate iOS example project flutter/plugins#2092

Merged

[google_maps_flutter] Update and migrate iOS example project flutter/plugins#2093

Merged

[google_sign_in] Update and migrate iOS example project flutter/plugins#2094

Merged

[image_picker] Update and migrate iOS example project flutter/plugins#2095

Merged

[in_app_purchase] Update and migrate iOS example project flutter/plugins#2096

Merged

[local_auth] Update and migrate iOS example project flutter/plugins#2097

Merged

[package_info] Update and migrate iOS example project flutter/plugins#2098

Merged

[path_provider] Update and migrate iOS example project flutter/plugins#2099

Merged

[quick_actions] Update and migrate iOS example project flutter/plugins#2100

Merged

This was referenced Sep 25, 2019

[sensors] Update and migrate iOS example project flutter/plugins#2101

Merged

[share] Update and migrate iOS example project flutter/plugins#2102

Merged

[shared_preferences] Update and migrate iOS example project flutter/plugins#2103

Merged

[url_launcher] Update and migrate iOS example project flutter/plugins#2109

Merged

[video_player] Update and migrate iOS example project flutter/plugins#2110

Merged

mklim pushed a commit to flutter/plugins that referenced this pull request


          [android_intent] Update and migrate iOS example project (#2088)

e2466bc

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error

mklim pushed a commit to flutter/plugins that referenced this pull request


          [camera] Update and migrate iOS example project (#2090)

86d245f

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)
7. Looks like this was last run with `use_frameworks!`?  Let CocoaPods build as libraries instead of frameworks.
8. Remove ARCHS, which was causing a compilation error

mklim pushed a commit to flutter/plugins that referenced this pull request


          [in_app_purchase] Update and migrate iOS example project (#2096)

00e1936

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove extraneous framework outputs flutter/flutter#20685

mklim pushed a commit to flutter/plugins that referenced this pull request


          [url_launcher] Update and migrate iOS example project (#2109)

a394c13

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove extraneous framework outputs flutter/flutter#20685

mklim pushed a commit to flutter/plugins that referenced this pull request


          [device_info] Update and migrate iOS example project (#2092)

7fe6934

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error

Vallasc pushed a commit to Vallasc/camera_plugin that referenced this pull request


          [camera] Update and migrate iOS example project (#2090)

0b39130

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)
7. Looks like this was last run with `use_frameworks!`?  Let CocoaPods build as libraries instead of frameworks.
8. Remove ARCHS, which was causing a compilation error

mormih pushed a commit to mormih/plugins that referenced this pull request


          [android_intent] Update and migrate iOS example project (flutter#2088)

5e20aae

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error

mormih pushed a commit to mormih/plugins that referenced this pull request


          [camera] Update and migrate iOS example project (flutter#2090)

38e2125

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)
7. Looks like this was last run with `use_frameworks!`?  Let CocoaPods build as libraries instead of frameworks.
8. Remove ARCHS, which was causing a compilation error

mormih pushed a commit to mormih/plugins that referenced this pull request


          [in_app_purchase] Update and migrate iOS example project (flutter#2096)

a7ea38e

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove extraneous framework outputs flutter/flutter#20685

mormih pushed a commit to mormih/plugins that referenced this pull request


          [url_launcher] Update and migrate iOS example project (flutter#2109)

b78d0b5

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove extraneous framework outputs flutter/flutter#20685

mormih pushed a commit to mormih/plugins that referenced this pull request


          [device_info] Update and migrate iOS example project (flutter#2092)

8eaeae9

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request


          [android_intent] Update and migrate iOS example project (flutter#2088)

ff547f9

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request


          [camera] Update and migrate iOS example project (flutter#2090)

89acdfb

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove DEVELOPMENT_TEAM references since having those provisioning profiles should not be required to run the examples (most examples don't have one)
7. Looks like this was last run with `use_frameworks!`?  Let CocoaPods build as libraries instead of frameworks.
8. Remove ARCHS, which was causing a compilation error

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request


          [in_app_purchase] Update and migrate iOS example project (flutter#2096)

ce0a87e

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove extraneous framework outputs flutter/flutter#20685

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request


          [url_launcher] Update and migrate iOS example project (flutter#2109)

bf95f6e

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove extraneous framework outputs flutter/flutter#20685

sungmin-park pushed a commit to sungmin-park/flutter-plugins that referenced this pull request


          [device_info] Update and migrate iOS example project (flutter#2092)

9e8d48d

1. Let flutter/flutter#26630 flutter_assets migrator run
2. Run `pod install` so flutter_assets is removed from the asset copy build phase
3. Migrate deprecated "English" to "en" language
4. Allow Xcode to remove extraneous xcconfigs, see flutter/flutter#38724
5. Let Xcode 11 update build settings
6. Remove ARCHS, which was causing a compilation error

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

customer: gallery d: examples platform-ios t: xcode team tool