fix an exception while parsing a services file #4302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
cdotstout
pushed a commit
to cdotstout/flutter
that referenced
this pull request
Apr 3, 2018
This change exposes the view safe area insets (introduced in iOS 11) to the framework via MediaQuery.of(context).padding. Safe area insets are the view insets (padding) inside of which content can be relied on to display without truncation/clipping, as would occur with e.g. the iPhone X sensor notch. As this API was added in iOS 11, we place it behind a runtime guard checking OS level. Until the runtime support for @avialable lands in the next Fuchsia buildtools rev, ignore -Wunguarded-availability-new around the safe area insets check and use an FML runtime check instead.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an exception that occurs when parsing a services file (https://github.com/flutter/google_sign_in/blob/master/lib/flutter_services.yaml); fix #4294.