Detect when isolate reload is barred and inform the user #5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
johnmccutchan
commented
Aug 24, 2016
johnmccutchan
commented
- React to the signal from the VM that an isolate is barred from performing a hot reload and must be restarted.
- Roll the engine forward
|
I think some of the engine artifacts aren't yet available on google storage. |
| @@ -445,9 +445,18 @@ class HotRunner extends ResidentRunner { | |||
| } else { | |||
| flutterUsage.sendEvent('hot', 'reload'); | |||
| } | |||
| } catch (errorMessage, st) { | |||
| } catch (error, st) { | |||
There was a problem hiding this comment.
Should we ensure that we're only catching a Map here (on Map)?
|
lgtm, but you probably want to wait to land this until all the engine artifacts build through. |
|
A lot of breakages caused by this PR (dashboard, sample log file) |
yjbanov
added a commit
to yjbanov/flutter
that referenced
this pull request
Aug 24, 2016
…tter#5582)" This reverts commit 09e68c3. AOT snapshotter is broken at this engine rev. https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahNzfmZsdXR0ZXItZGFzaGJvYXJkclgLEglDaGVja2xpc3QiOGZsdXR0ZXIvZmx1dHRlci8wOWU2OGMzM2NjZGIzNTVmZWRkNzVhODcxNmRlMDU1MWM3NzJmMmRlDAsSBFRhc2sYgICAgICAwAgM
|
Rolling it back in #5590 |
|
Thanks Yegor! |
yjbanov
added a commit
that referenced
this pull request
Aug 24, 2016
…)" (#5590) This reverts commit 09e68c3. AOT snapshotter is broken at this engine rev. https://flutter-dashboard.appspot.com/api/get-log?ownerKey=ahNzfmZsdXR0ZXItZGFzaGJvYXJkclgLEglDaGVja2xpc3QiOGZsdXR0ZXIvZmx1dHRlci8wOWU2OGMzM2NjZGIzNTVmZWRkNzVhODcxNmRlMDU1MWM3NzJmMmRlDAsSBFRhc2sYgICAgICAwAgM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.