Skip to content

Take screenshots of wirelessly paired iOS devices #60623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2020

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Jun 30, 2020

Description

idevicescreenshot 1.3.0 supports the --network flag to take screenshots of wirelessly paired iOS devices. Pipe the flag through based on the detected device interface.

Related Issues

Next part of #15072.

Tests

idevicescreenshot captures and returns network screenshot

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman added the platform-ios iOS applications specifically label Jun 30, 2020
@jmagman jmagman self-assigned this Jun 30, 2020
@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 30, 2020
@jmagman jmagman force-pushed the wireless-screenshot branch from 050bb68 to 45b2266 Compare June 30, 2020 18:40
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented Jul 1, 2020

TAP failure is:

flutter_tools/lib/src/ios/mac.dart:27
  Unused import: 'devices.dart'. #unused_import

But it definitely is used, not sure what to do about that... I wonder if it would show up in a roll or if this is frob being so far behind.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman jmagman merged commit 11bf7f0 into flutter:master Jul 6, 2020
@jmagman jmagman deleted the wireless-screenshot branch July 8, 2020 22:43
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants