Support Xcode variable substitution in Info.plist #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
xcode_var_subst
branch
from
e6d5a51 to
37c4918
Compare
|
lgtm. Does the Info.plist in the new project template need to be updated? |
cbracken
force-pushed
the
xcode_var_subst
branch
3 times, most recently
from
293863f to
b532fe7
Compare
|
Good call. Done. |
As of Xcode 7, Apple recommends setting CFBundleIdentifier to $(PRODUCT_BUNDLE_IDENTIFIER).
As of Xcode 7, Apple recommends setting the bundle identifier in the PRODUCT_BUNDLE_IDENTIFIER build variable and setting CFBundleIdentifier to that variable in Info.plist. As of Xcode 8, CLANG_WARN_INFINITE_RECURSION and CLANG_WARN_SUSPICIOUS_MOVE are recommended settings.
cbracken
force-pushed
the
xcode_var_subst
branch
from
b532fe7 to
eb1ac86
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6067